From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75B29C4BA18 for ; Wed, 26 Feb 2020 17:12:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 27B12206E2 for ; Wed, 26 Feb 2020 17:12:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="oX9nzWXo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27B12206E2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CD4D66B0008; Wed, 26 Feb 2020 12:12:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C5DEC6B000E; Wed, 26 Feb 2020 12:12:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4DF96B0010; Wed, 26 Feb 2020 12:12:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0145.hostedemail.com [216.40.44.145]) by kanga.kvack.org (Postfix) with ESMTP id 993CA6B0008 for ; Wed, 26 Feb 2020 12:12:30 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 93A813AB7 for ; Wed, 26 Feb 2020 17:12:30 +0000 (UTC) X-FDA: 76532922060.18.hate77_67ac13b340502 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id 0B7FE10095BC8 for ; Wed, 26 Feb 2020 17:05:13 +0000 (UTC) X-HE-Tag: hate77_67ac13b340502 X-Filterd-Recvd-Size: 2403 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Wed, 26 Feb 2020 17:05:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RoCLmknvsOG65QXIhh4xiHuf4xfOWj6VnF+GxnaICfs=; b=oX9nzWXovMYD4UTYLkNhs6PXBa oIB9l5x5rtHW1JoDiVI6sOyxW7pJ+HyHEsqAwBDopdMOX7IegyH2lw3JVaGwbReLlEYe8saCtdFib M7Wpw/yMgU+xN7ib/6htSPNuyVSh8XVMA942gkBCgwUqvdbj2PwflJ2ei/wXMKFoREUPGZLiBoFPK 1KgJZHw9KD6DbIQSIwjsPjElCP3rOgFw7aIr7acjWVWU83b6RP6rL50zYGbqiD5lL7hZbwE/dzxfk 2uEaq3GU9vyXSZqJ2PbKMXlmDRBpvqc22XRN+TzMCxrEOJXNLtrFXf3lpGMd1qTNR4zkO5cza/wX3 aydJpzDg==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j707P-0007Yw-IT; Wed, 26 Feb 2020 17:05:07 +0000 Date: Wed, 26 Feb 2020 09:05:07 -0800 From: Christoph Hellwig To: Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, linux-xfs@vger.kernel.org Subject: Re: [PATCH v8 17/25] btrfs: Convert from readpages to readahead Message-ID: <20200226170507.GC22837@infradead.org> References: <20200225214838.30017-1-willy@infradead.org> <20200225214838.30017-18-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200225214838.30017-18-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 25, 2020 at 01:48:30PM -0800, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > Implement the new readahead method in btrfs. Add a readahead_page_batch() > to optimise fetching a batch of pages at once. readahead_page_batch() isn't added in this patch anymore. Otherwise this looks good to me, although I don't feel confident enough to give a Reviewed-by for btrfs code.