From: Andrew Morton <akpm@linux-foundation.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
mgorman@techsingularity.net, linux-mm@kvack.org
Subject: Re: [bug report] mm, compaction: capture a page under direct compaction
Date: Wed, 26 Feb 2020 17:56:14 -0800 [thread overview]
Message-ID: <20200226175614.5dfe21b53cad9f8bca084a2b@linux-foundation.org> (raw)
In-Reply-To: <82147552-be4c-84cc-53d8-f00711859427@suse.cz>
On Wed, 26 Feb 2020 18:04:56 +0100 Vlastimil Babka <vbabka@suse.cz> wrote:
> On 2/24/20 7:35 AM, Dan Carpenter wrote:
> > Hello Mel Gorman,
> >
> > This is a semi-automatic email about new static checker warnings.
> >
> > The patch 5e1f0f098b46: "mm, compaction: capture a page under direct
> > compaction" from Mar 5, 2019, leads to the following Smatch complaint:
> >
> > mm/compaction.c:2321 compact_zone_order()
> > error: we previously assumed 'capture' could be null (see line 2313)
> >
>
> ----8<----
> >From fb264bb52576a0582e8a92952cf91e8b61d105c3 Mon Sep 17 00:00:00 2001
> From: Vlastimil Babka <vbabka@suse.cz>
> Date: Wed, 26 Feb 2020 17:53:54 +0100
> Subject: [PATCH] mm, compaction: fully assume capture can be NULL in
> compact_zone_order()
>
> Dan reports:
>
> The patch 5e1f0f098b46: "mm, compaction: capture a page under direct
> compaction" from Mar 5, 2019, leads to the following Smatch complaint:
>
> mm/compaction.c:2321 compact_zone_order()
> error: we previously assumed 'capture' could be null (see line 2313)
>
> mm/compaction.c
> 2288 static enum compact_result compact_zone_order(struct zone *zone, int order,
> 2289 gfp_t gfp_mask, enum compact_priority prio,
> 2290 unsigned int alloc_flags, int classzone_idx,
> 2291 struct page **capture)
> ^^^^^^^
>
> 2313 if (capture)
> ^^^^^^^
> Check for NULL
>
> 2314 current->capture_control = &capc;
> 2315
> 2316 ret = compact_zone(&cc, &capc);
> 2317
> 2318 VM_BUG_ON(!list_empty(&cc.freepages));
> 2319 VM_BUG_ON(!list_empty(&cc.migratepages));
> 2320
> 2321 *capture = capc.page;
> ^^^^^^^^
> Unchecked dereference.
>
> 2322 current->capture_control = NULL;
> 2323
>
> In practice this is not an issue, as the only caller path passes non-NULL
> capture:
>
> __alloc_pages_direct_compact()
> struct page *page = NULL;
> try_to_compact_pages(capture = &page);
> compact_zone_order(capture = capture);
>
> Hence no stable tag needed, but let's make this more robust and remove the
> warning by assuming capture might be NULL in the second dereference.
>
> ...
>
> --- mm/compaction.c
> +++ mm/compaction.c
> @@ -2318,8 +2318,10 @@ static enum compact_result compact_zone_order(struct zone *zone, int order,
> VM_BUG_ON(!list_empty(&cc.freepages));
> VM_BUG_ON(!list_empty(&cc.migratepages));
>
> - *capture = capc.page;
> - current->capture_control = NULL;
> + if (capture) {
> + *capture = capc.page;
> + current->capture_control = NULL;
> + }
>
> return ret;
> }
Why don't we instead remove the first check for NULL? Remove some dead
code instead of adding some?
next prev parent reply other threads:[~2020-02-27 1:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 6:35 [bug report] mm, compaction: capture a page under direct compaction Dan Carpenter
2020-02-26 17:04 ` Vlastimil Babka
2020-02-27 1:56 ` Andrew Morton [this message]
2020-02-27 7:45 ` Vlastimil Babka
2020-02-28 13:47 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226175614.5dfe21b53cad9f8bca084a2b@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).