From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: linux-next@vger.kernel.org, akpm@linux-foundation.org
Cc: borntraeger@de.ibm.com, david@redhat.com, aarcange@redhat.com,
linux-mm@kvack.org, frankja@linux.ibm.com, sfr@canb.auug.org.au,
jhubbard@nvidia.com, linux-kernel@vger.kernel.org,
linux-s390@vger.kernel.org
Subject: [RFC v1 1/2] fixup for 9947ea2c1e608e32669d5caeb67b3e3fba3309e8 "mm/gup: track FOLL_PIN pages"
Date: Fri, 28 Feb 2020 16:43:20 +0100 [thread overview]
Message-ID: <20200228154322.329228-2-imbrenda@linux.ibm.com> (raw)
In-Reply-To: <20200228154322.329228-1-imbrenda@linux.ibm.com>
in case pin fails, we need to unpin, just a put_page will not be enough
Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
---
mm/gup.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/mm/gup.c b/mm/gup.c
index f589299b0d4a..0b9a806898f3 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -2134,7 +2134,10 @@ static int gup_pte_range(pmd_t pmd, unsigned long addr, unsigned long end,
goto pte_unmap;
if (unlikely(pte_val(pte) != pte_val(*ptep))) {
- put_page(head);
+ if (flags & FOLL_GET)
+ put_page(head);
+ else if (flags & FOLL_PIN)
+ unpin_user_page(head);
goto pte_unmap;
}
--
2.24.1
next prev parent reply other threads:[~2020-02-28 15:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 15:43 [RFC v1 0/2] add callbacks for inaccessible pages Claudio Imbrenda
2020-02-28 15:43 ` Claudio Imbrenda [this message]
2020-02-28 15:45 ` [RFC v1 1/2] fixup for 9947ea2c1e608e32669d5caeb67b3e3fba3309e8 "mm/gup: track FOLL_PIN pages" Claudio Imbrenda
2020-02-28 15:43 ` [RFC v1 1/2] mm/gup: fixup for 9947ea2c1e608e32 " Claudio Imbrenda
2020-02-28 23:08 ` John Hubbard
2020-02-29 10:51 ` Claudio Imbrenda
2020-02-29 20:09 ` John Hubbard
2020-03-02 13:46 ` Michal Hocko
2020-02-28 15:43 ` [RFC v1 2/2] mm/gup/writeback: add callbacks for inaccessible pages Claudio Imbrenda
2020-02-28 16:08 ` Christian Borntraeger
2020-02-29 0:08 ` John Hubbard
2020-02-29 10:49 ` Claudio Imbrenda
2020-02-29 20:07 ` John Hubbard
2020-03-01 3:47 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200228154322.329228-2-imbrenda@linux.ibm.com \
--to=imbrenda@linux.ibm.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).