archive mirror
 help / color / mirror / Atom feed
* [PATCH] loop: Fix irq lock ordering bug
@ 2020-02-28 16:18 Dan Schatzberg
  0 siblings, 0 replies; only message in thread
From: Dan Schatzberg @ 2020-02-28 16:18 UTC (permalink / raw)
  Cc: Jens Axboe, Andrew Morton, Johannes Weiner, Qian Cai,
	open list:BLOCK LAYER,
	open list, Dan Schatzberg

"loop: Use worker per cgroup instead of kworker" in patch series
"Charge loop device i/o to issuing cgroup", v3.  introduced a lock
ordering bug. The previously existing lo->lo_lock was always acquired
as spin_lock_irq but never actually used in irq context. The above
patch started to use this lock in irq context which triggered a
lockdep warning on sysfs reading.

Fix this by executing file_path outside of the lock.

Signed-off-by: Dan Schatzberg <>
 drivers/block/loop.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index eb766db48685..366658e60064 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -768,12 +768,18 @@ static ssize_t loop_attr_backing_file_show(struct loop_device *lo, char *buf)
 	ssize_t ret;
 	char *p = NULL;
+	struct file *filp = NULL;
 	if (lo->lo_backing_file)
-		p = file_path(lo->lo_backing_file, buf, PAGE_SIZE - 1);
+		filp = get_file(lo->lo_backing_file);
+	if (filp) {
+		p = file_path(filp, buf, PAGE_SIZE - 1);
+		fput(filp);
+	}
 	if (IS_ERR_OR_NULL(p))
 		ret = PTR_ERR(p);
 	else {

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-02-28 16:19 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-28 16:18 [PATCH] loop: Fix irq lock ordering bug Dan Schatzberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).