From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 004A7C3F2D2 for ; Fri, 28 Feb 2020 22:48:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B3C32246AE for ; Fri, 28 Feb 2020 22:48:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j+rSunlK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3C32246AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4A15C6B0005; Fri, 28 Feb 2020 17:48:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4520F6B0006; Fri, 28 Feb 2020 17:48:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 367BB6B0007; Fri, 28 Feb 2020 17:48:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0243.hostedemail.com [216.40.44.243]) by kanga.kvack.org (Postfix) with ESMTP id 1E1386B0005 for ; Fri, 28 Feb 2020 17:48:07 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id CB3D9824556B for ; Fri, 28 Feb 2020 22:48:06 +0000 (UTC) X-FDA: 76541025372.23.ant74_c97413563b52 X-HE-Tag: ant74_c97413563b52 X-Filterd-Recvd-Size: 3375 Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Fri, 28 Feb 2020 22:48:06 +0000 (UTC) Received: by mail-lj1-f196.google.com with SMTP id e3so5071400lja.10 for ; Fri, 28 Feb 2020 14:48:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=A+iUf1q8MEClAw7zFCnu1KfnBswurqalqrfaVPpzjIg=; b=j+rSunlKdN/kAKRGhPOnBPNtnuI4mJopAbdUyGTJVlTjTub2un8qOnqwPv0YgE327y aHY+108Xztjp2qF2LhuHT6nccbHZNBGB5FJzBvYjdS5l5b2lsuomSPRsrzhTJ9jo4gRd umBQ2OnCPDzOfVSNC9+xSQ0efZmNxy+tzDek9wGXEvZtd+CxFFw5e8JTMEMeNc5NQxEd ktEuCd1EhHWWONd53x+zIsL6rBEZJY3XEH6gpfymR1A5ppGZDrfG4TBxmtuIS85mN/y1 O+DNi7nOPllLZK5Ypxu4IUVxQxzrn8lbLiHxSNUK+oFRDetF9rvKIbwASP1I4iUK0NI9 kbjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=A+iUf1q8MEClAw7zFCnu1KfnBswurqalqrfaVPpzjIg=; b=c6p2h7uGipUs4G4bJHYsIV1zYoHjHg8jFq4eRyN/jL5sH+edhCM/eKkfiJ+fklMD73 Fs5MAsXj2d04JyFApJLenyKybptW6IyWMCYQj0iWM+H7rOMkgD6tM9xNyH5vYig4Dct1 nz3rUCAuN0CBWZVMCCmOvOS7Q4C9TAIuyPKUBPcg+dfsMWwb3+43bST7OwDFpD6Emvg5 Kcg87dRmqqyK6ufIIEJmXD2AoD3O4a9WxqrhIwy7eytiZgm+6OKh+5gqxBzpVloNBpzl +MoGvFs4rHpj4JqgS/6NW2TwZkyq/qR7SI9iztC9q6tLs/C1rn0rBq37/Q2Ne2TUoK63 TENw== X-Gm-Message-State: ANhLgQ3TSJfwVonFEgk/NuMDZn9gc1O8BdpLQB466xk+XecANTtiBmwC bky2qLizO1CIOx9XtTrCprbtLPxwXlH/xw== X-Google-Smtp-Source: ADFU+vuV1zQy8PJeKk+iZ5PNWS05sKhzzSQ5rg4vPdWweL9ZumRLjGymkVf+izwZf1z47RUFlXh+Hg== X-Received: by 2002:a2e:b892:: with SMTP id r18mr4268976ljp.252.1582930084594; Fri, 28 Feb 2020 14:48:04 -0800 (PST) Received: from localhost.localdomain (188.146.100.83.nat.umts.dynamic.t-mobile.pl. [188.146.100.83]) by smtp.gmail.com with ESMTPSA id w24sm5424340ljh.26.2020.02.28.14.48.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 14:48:03 -0800 (PST) From: mateusznosek0@gmail.com To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Mateusz Nosek , akpm@linux-foundation.org Subject: [PATCH] mm/mm_init.c: Clean code. Use BUILD_BUG_ON when comparing compile time constant Date: Fri, 28 Feb 2020 23:46:17 +0100 Message-Id: <20200228224617.11343-1-mateusznosek0@gmail.com> X-Mailer: git-send-email 2.17.1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.035194, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Mateusz Nosek MAX_ZONELISTS is compile time constant, so it should be compared using BUILD_BUG_ON not BUG_ON. Signed-off-by: Mateusz Nosek --- mm/mm_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/mm_init.c b/mm/mm_init.c index 5c918388de99..7da6991d9435 100644 --- a/mm/mm_init.c +++ b/mm/mm_init.c @@ -37,7 +37,7 @@ void __init mminit_verify_zonelist(void) struct zonelist *zonelist; int i, listid, zoneid; - BUG_ON(MAX_ZONELISTS > 2); + BUILD_BUG_ON(MAX_ZONELISTS > 2); for (i = 0; i < MAX_ZONELISTS * MAX_NR_ZONES; i++) { /* Identify the zone and nodelist */ -- 2.17.1