From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7218AC3F2D7 for ; Mon, 2 Mar 2020 22:11:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2F57F24677 for ; Mon, 2 Mar 2020 22:11:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="0q18elEU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F57F24677 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A3F6C6B0005; Mon, 2 Mar 2020 17:11:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9EF0C6B0006; Mon, 2 Mar 2020 17:11:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DDBD6B0007; Mon, 2 Mar 2020 17:11:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0198.hostedemail.com [216.40.44.198]) by kanga.kvack.org (Postfix) with ESMTP id 74AF26B0005 for ; Mon, 2 Mar 2020 17:11:47 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 59FFB12F57 for ; Mon, 2 Mar 2020 22:11:47 +0000 (UTC) X-FDA: 76551820254.11.gold68_f92bea69e60d X-HE-Tag: gold68_f92bea69e60d X-Filterd-Recvd-Size: 2796 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Mon, 2 Mar 2020 22:11:46 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 46D4921739; Mon, 2 Mar 2020 22:11:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583187105; bh=nmmuEpxmCjc0aKsztvjVXQXja7/rg6W/P3XUJuNzzKc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=0q18elEUkRaxUtioBVBS0syNq3bikiyHmmqzQeYjY9AB/5R2JiOBn5bl54IyRZzmt nLXzchT4MCXx8AoVjhcjC4USN/LyuG9qHeJn15K86f757YVqpUM0rb9wmH5F0hqdSj AWBD+bnAAE4uWywcgoAr66YGhiWsV1IXA2regTt8= Date: Mon, 2 Mar 2020 14:11:44 -0800 From: Andrew Morton To: Alex Shi Cc: cgroups@vger.kernel.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com, willy@infradead.org, hannes@cmpxchg.org, lkp@intel.com, Michal Hocko , Vladimir Davydov , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v9 07/20] mm/lru: introduce TestClearPageLRU Message-Id: <20200302141144.b30abe0d89306fd387e13a92@linux-foundation.org> In-Reply-To: <1583146830-169516-8-git-send-email-alex.shi@linux.alibaba.com> References: <1583146830-169516-1-git-send-email-alex.shi@linux.alibaba.com> <1583146830-169516-8-git-send-email-alex.shi@linux.alibaba.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 2 Mar 2020 19:00:17 +0800 Alex Shi wrote: > Combined PageLRU check and ClearPageLRU into one function by new > introduced func TestClearPageLRU. This function will be used as page > isolation precondition. > > No functional change yet. > > ... > > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -2588,9 +2588,8 @@ static void commit_charge(struct page *page, struct mem_cgroup *memcg, > pgdat = page_pgdat(page); > spin_lock_irq(&pgdat->lru_lock); > > - if (PageLRU(page)) { > + if (TestClearPageLRU(page)) { > lruvec = mem_cgroup_page_lruvec(page, pgdat); > - ClearPageLRU(page); > del_page_from_lru_list(page, lruvec, page_lru(page)); > } else The code will now get exclusive access of the page->flags cacheline and will dirty that cacheline, even for !PageLRU() pages. What is the performance impact of this?