From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6939BC3F2C6 for ; Wed, 4 Mar 2020 01:03:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 162EF2073B for ; Wed, 4 Mar 2020 01:03:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="zvxaHgXP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 162EF2073B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 955F36B0003; Tue, 3 Mar 2020 20:03:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8DF986B0005; Tue, 3 Mar 2020 20:03:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CF8B6B0006; Tue, 3 Mar 2020 20:03:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0199.hostedemail.com [216.40.44.199]) by kanga.kvack.org (Postfix) with ESMTP id 612606B0003 for ; Tue, 3 Mar 2020 20:03:16 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 38ED813087 for ; Wed, 4 Mar 2020 01:03:16 +0000 (UTC) X-FDA: 76555881192.23.neck58_73cec97ba7f0b X-HE-Tag: neck58_73cec97ba7f0b X-Filterd-Recvd-Size: 7044 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Wed, 4 Mar 2020 01:03:15 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B1B1820728; Wed, 4 Mar 2020 01:03:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583283794; bh=wtaO/pKMMUDzLrcxYJqrsr8I03g03AsdEGU1dD+/zTw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zvxaHgXPUFELzY4ukBeTY6RmIqLxdISibnCk2y+0Nj4w3XjkuvZRT4JNzaoefoUnn mX5JzeRlnkDgXGkpY9ANastjjY+/qTe9Q1/m2IWUfdi1N9fMHzICONHjczq4BWO4Hq vv6JPXz5OUUyK+Eu1Iw72n+4EKr8AII+NOsZdFy8= Date: Tue, 3 Mar 2020 17:03:14 -0800 From: Andrew Morton To: kbuild test robot Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com, Linux Memory Management List , Mike Rapoport , Catalin Marinas Subject: Re: [linux-next:master 5946/5967] arch/arm64/mm/mmu.c:827:21: error: incompatible pointer types passing 'pgd_t *' to parameter of type 'p4d_t *' Message-Id: <20200303170314.9a6684e8191250275b1d8bdf@linux-foundation.org> In-Reply-To: <202003031105.xcoYRe6W%lkp@intel.com> References: <202003031105.xcoYRe6W%lkp@intel.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 3 Mar 2020 11:18:12 +0800 kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: b56557c8e5210c25b008da636ef804b228967aa6 > commit: 87d900aef3e229a891438c88debc533a8a1fa976 [5946/5967] arm/arm64: add support for folded p4d page tables > config: arm64-allyesconfig (attached as .config) > compiler: clang version 11.0.0 (git://gitmirror/llvm_project 211fb91f1067ecdf7c0b8a019bcf76554d813129) > reproduce: > # FIXME the reproduce steps for clang is not ready yet > > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot > > All errors (new ones prefixed by >>): (cc Mike & Catalin) Did we already fix this? arm-arm64-add-support-for-folded-p4d-page-tables-fix-fix.patch (http://lkml.kernel.org/r/20200302174553.GC4166275@arrakis.emea.arm.com) seems to be fixing a different issue? > >> arch/arm64/mm/mmu.c:827:21: error: incompatible pointer types passing 'pgd_t *' to parameter of type 'p4d_t *' [-Werror,-Wincompatible-pointer-types] > pudp = pud_offset(pgdp, addr); > ^~~~ > include/asm-generic/pgtable-nopud.h:45:40: note: passing argument to parameter 'p4d' here > static inline pud_t *pud_offset(p4d_t *p4d, unsigned long address) > ^ > arch/arm64/mm/mmu.c:955:21: error: incompatible pointer types passing 'pgd_t *' to parameter of type 'p4d_t *' [-Werror,-Wincompatible-pointer-types] > pudp = pud_offset(pgdp, addr); > ^~~~ > include/asm-generic/pgtable-nopud.h:45:40: note: passing argument to parameter 'p4d' here > static inline pud_t *pud_offset(p4d_t *p4d, unsigned long address) > ^ > arch/arm64/mm/mmu.c:975:20: error: incompatible pointer types passing 'pgd_t *' to parameter of type 'p4d_t *' [-Werror,-Wincompatible-pointer-types] > pudp = pud_offset(pgdp, 0UL); > ^~~~ > include/asm-generic/pgtable-nopud.h:45:40: note: passing argument to parameter 'p4d' here > static inline pud_t *pud_offset(p4d_t *p4d, unsigned long address) > ^ > 3 errors generated. > > vim +827 arch/arm64/mm/mmu.c > > de323e651df4680 Anshuman Khandual 2020-02-13 818 > de323e651df4680 Anshuman Khandual 2020-02-13 819 static void unmap_hotplug_pud_range(pgd_t *pgdp, unsigned long addr, > de323e651df4680 Anshuman Khandual 2020-02-13 820 unsigned long end, bool free_mapped) > de323e651df4680 Anshuman Khandual 2020-02-13 821 { > de323e651df4680 Anshuman Khandual 2020-02-13 822 unsigned long next; > de323e651df4680 Anshuman Khandual 2020-02-13 823 pud_t *pudp, pud; > de323e651df4680 Anshuman Khandual 2020-02-13 824 > de323e651df4680 Anshuman Khandual 2020-02-13 825 do { > de323e651df4680 Anshuman Khandual 2020-02-13 826 next = pud_addr_end(addr, end); > de323e651df4680 Anshuman Khandual 2020-02-13 @827 pudp = pud_offset(pgdp, addr); > de323e651df4680 Anshuman Khandual 2020-02-13 828 pud = READ_ONCE(*pudp); > de323e651df4680 Anshuman Khandual 2020-02-13 829 if (pud_none(pud)) > de323e651df4680 Anshuman Khandual 2020-02-13 830 continue; > de323e651df4680 Anshuman Khandual 2020-02-13 831 > de323e651df4680 Anshuman Khandual 2020-02-13 832 WARN_ON(!pud_present(pud)); > de323e651df4680 Anshuman Khandual 2020-02-13 833 if (pud_sect(pud)) { > de323e651df4680 Anshuman Khandual 2020-02-13 834 pud_clear(pudp); > de323e651df4680 Anshuman Khandual 2020-02-13 835 > de323e651df4680 Anshuman Khandual 2020-02-13 836 /* > de323e651df4680 Anshuman Khandual 2020-02-13 837 * One TLBI should be sufficient here as the PUD_SIZE > de323e651df4680 Anshuman Khandual 2020-02-13 838 * range is mapped with a single block entry. > de323e651df4680 Anshuman Khandual 2020-02-13 839 */ > de323e651df4680 Anshuman Khandual 2020-02-13 840 flush_tlb_kernel_range(addr, addr + PAGE_SIZE); > de323e651df4680 Anshuman Khandual 2020-02-13 841 if (free_mapped) > de323e651df4680 Anshuman Khandual 2020-02-13 842 free_hotplug_page_range(pud_page(pud), > de323e651df4680 Anshuman Khandual 2020-02-13 843 PUD_SIZE); > de323e651df4680 Anshuman Khandual 2020-02-13 844 continue; > de323e651df4680 Anshuman Khandual 2020-02-13 845 } > de323e651df4680 Anshuman Khandual 2020-02-13 846 WARN_ON(!pud_table(pud)); > de323e651df4680 Anshuman Khandual 2020-02-13 847 unmap_hotplug_pmd_range(pudp, addr, next, free_mapped); > de323e651df4680 Anshuman Khandual 2020-02-13 848 } while (addr = next, addr < end); > de323e651df4680 Anshuman Khandual 2020-02-13 849 } > de323e651df4680 Anshuman Khandual 2020-02-13 850 > > :::::: The code at line 827 was first introduced by commit > :::::: de323e651df46808081eeb17268054f77932a119 arm64/mm: Enable memory hot remove > > :::::: TO: Anshuman Khandual > :::::: CC: Catalin Marinas > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org