From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07182C3F2D1 for ; Tue, 3 Mar 2020 20:21:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BE4A120842 for ; Tue, 3 Mar 2020 20:21:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE4A120842 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6F2826B0008; Tue, 3 Mar 2020 15:21:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C9846B000A; Tue, 3 Mar 2020 15:21:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 605BB6B000C; Tue, 3 Mar 2020 15:21:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0106.hostedemail.com [216.40.44.106]) by kanga.kvack.org (Postfix) with ESMTP id 493956B0008 for ; Tue, 3 Mar 2020 15:21:01 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B1B9E181AC9BF for ; Tue, 3 Mar 2020 20:21:00 +0000 (UTC) X-FDA: 76555169880.05.brick26_7d2f93c60e55a X-HE-Tag: brick26_7d2f93c60e55a X-Filterd-Recvd-Size: 2396 Received: from Galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Tue, 3 Mar 2020 20:21:00 +0000 (UTC) Received: from bigeasy by Galois.linutronix.de with local (Exim 4.80) (envelope-from ) id 1j9E2A-0005uZ-As; Tue, 03 Mar 2020 21:20:54 +0100 Date: Tue, 3 Mar 2020 21:20:54 +0100 From: Sebastian Andrzej Siewior To: Andrew Morton Cc: Vlastimil Babka , linux-mm@kvack.org, Thomas Gleixner , Luis Chamberlain , Kees Cook , Iurii Zaikin , Mel Gorman , Linux API Subject: [PATCH 1/2] =?utf-8?B?PT9VVEYtOD9xP21tL2NvbXBhY3Rpb246PTIwUmVh?= =?utf-8?B?bGx5PTIwbGltaXQ9MjBjb21wYWN0Pz0gPT9VVEYtOD9xPz01RnVuZXZpY3Rh?= =?utf-8?B?YmxlPTVGYWxsb3dlZD0yMHRvPTIwMD1FMj04MD1BNjE/PQ==?= Message-ID: <20200303202054.gsosv7fsx2ma3cic@linutronix.de> References: <20200115161035.893221-1-bigeasy@linutronix.de> <4cf4507b-0632-34e6-5985-df933559af9f@suse.cz> <20200302173516.iysuejilava37psk@linutronix.de> <20200302132531.59a2c9dffe2515d78abaf909@linux-foundation.org> <20200303175910.ichnkjkgmz5y2ipb@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200303175910.ichnkjkgmz5y2ipb@linutronix.de> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The proc file `compact_unevictable_allowed' should allow 0 and 1 only, the `extra*' attribues have been set properly but without proc_dointvec_minmax() as the `proc_handler' the limit will not be enforced. Use proc_dointvec_minmax() as the `proc_handler' to enfoce the valid specified range. Signed-off-by: Sebastian Andrzej Siewior --- kernel/sysctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sysctl.c b/kernel/sysctl.c index ad5b88a53c5a8..982203101f961 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -1484,7 +1484,7 @@ static struct ctl_table vm_table[] = { .data = &sysctl_compact_unevictable_allowed, .maxlen = sizeof(int), .mode = 0644, - .proc_handler = proc_dointvec, + .proc_handler = proc_dointvec_minmax, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE, }, -- 2.25.1