From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBE62C3F2D1 for ; Wed, 4 Mar 2020 09:27:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B51CA20732 for ; Wed, 4 Mar 2020 09:27:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B51CA20732 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6076F6B0003; Wed, 4 Mar 2020 04:27:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C04E6B0005; Wed, 4 Mar 2020 04:27:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CCBB6B0006; Wed, 4 Mar 2020 04:27:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0156.hostedemail.com [216.40.44.156]) by kanga.kvack.org (Postfix) with ESMTP id 36EC16B0003 for ; Wed, 4 Mar 2020 04:27:51 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id BF1A1181AC9BF for ; Wed, 4 Mar 2020 09:27:50 +0000 (UTC) X-FDA: 76557152700.03.women05_a3c1665b1050 X-HE-Tag: women05_a3c1665b1050 X-Filterd-Recvd-Size: 2219 Received: from Galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Wed, 4 Mar 2020 09:27:50 +0000 (UTC) Received: from bigeasy by Galois.linutronix.de with local (Exim 4.80) (envelope-from ) id 1j9QJg-0007su-3L; Wed, 04 Mar 2020 10:27:48 +0100 Date: Wed, 4 Mar 2020 10:27:48 +0100 From: Sebastian Andrzej Siewior To: Vlastimil Babka Cc: Andrew Morton , linux-mm@kvack.org, Thomas Gleixner , Luis Chamberlain , Kees Cook , Iurii Zaikin , Mel Gorman , Linux API Subject: Re: [PATCH 2/2 v3] mm/compaction: Disable compact_unevictable_allowed on RT Message-ID: <20200304092748.dz5m57hmwirpk65y@linutronix.de> References: <20200115161035.893221-1-bigeasy@linutronix.de> <4cf4507b-0632-34e6-5985-df933559af9f@suse.cz> <20200302173516.iysuejilava37psk@linutronix.de> <20200302132531.59a2c9dffe2515d78abaf909@linux-foundation.org> <20200303175910.ichnkjkgmz5y2ipb@linutronix.de> <20200303202054.gsosv7fsx2ma3cic@linutronix.de> <20200303202225.nhqc3v5gwlb7x6et@linutronix.de> <20200303155635.1955cb90451abd3ef8bfba63@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2020-03-04 09:19:21 [+0100], Vlastimil Babka wrote: > >> + WARN_ONCE(old != *(int *)table->data, "sysctl attribute %s changed.", > >> + table->procname); > > > > The WARN will include a stack trace which just isn't interesting. A > > pr_warn() would be better? > > Yeah, the only interesting part of full WARN would possibly be, which process > changed it. That might be useful to print. Yes, the stack trace and register dump isn't interesting. But as Vlastimil says, the task and pid are informative. So if that is too much I could extract those two informations and include it in a pr_warn(). Sebastian