From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5FA5C10DCE for ; Sun, 8 Mar 2020 12:23:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AE2EE20663 for ; Sun, 8 Mar 2020 12:23:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="rmplbdTF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE2EE20663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3E0746B0005; Sun, 8 Mar 2020 08:23:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 390346B0006; Sun, 8 Mar 2020 08:23:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A7336B0007; Sun, 8 Mar 2020 08:23:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0038.hostedemail.com [216.40.44.38]) by kanga.kvack.org (Postfix) with ESMTP id 104036B0005 for ; Sun, 8 Mar 2020 08:23:54 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C9EE34DD4 for ; Sun, 8 Mar 2020 12:23:53 +0000 (UTC) X-FDA: 76572111546.10.lift59_21fde23ca7c58 X-HE-Tag: lift59_21fde23ca7c58 X-Filterd-Recvd-Size: 2020 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Sun, 8 Mar 2020 12:23:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wCXz+x1ft7rAIL79rT7+q98H2g8TNTjE65lqoZAWVuQ=; b=rmplbdTFEEtiz3rSZtlGt9xtwh PBeKf2QiSbhs7PclQ5nvILOBfUfue6AYsZvlXjtf42igC9momRQ9GyAHd/jTkmjeQ51m0rfMz4/dZ O7rnRHKf4lIkJqVjTP2U/fGSPT5VHBQ0wu13G3vpQLT13KtV6SFEAAuNuig0wXGtJKjXTvJaRHECD cqknKNfYV4oyEQAsTxBWB2ENYuYlJmTXm2sHSDuTsh2UAf8JAXUpu9ifXm2ReAIVAiZLfEeg2tg0Y o43L7NqOEDfZ8Ncdmdt0cOeq0wgZGfhRVfNIFOfvgSfdX59gDoKRdD+JjYFBPo9+D+k0GXveGLf46 fI8ig4og==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jAuyC-0005YD-65; Sun, 08 Mar 2020 12:23:48 +0000 Date: Sun, 8 Mar 2020 05:23:48 -0700 From: Matthew Wilcox To: qiwuchen55@gmail.com Cc: akpm@linux-foundation.org, linux-mm@kvack.org, chenqiwu Subject: Re: [PATCH] mm/page_alloc: simplify page_is_buddy() for better code readability Message-ID: <20200308122348.GF31215@bombadil.infradead.org> References: <1583655036-5025-1-git-send-email-qiwuchen55@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1583655036-5025-1-git-send-email-qiwuchen55@gmail.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Mar 08, 2020 at 04:10:36PM +0800, qiwuchen55@gmail.com wrote: > From: chenqiwu > > Simplify page_is_buddy() to reduce the redundant code for better > code readability. > > Signed-off-by: chenqiwu Yes, this makes sense. It's fascinating looking at the git history for how we got here. Reviewed-by: Matthew Wilcox (Oracle)