archive mirror
 help / color / mirror / Atom feed
From: chenqiwu <>
To: Matthew Wilcox <>
	chenqiwu <>
Subject: Re: [PATCH] mm/page_alloc: use free_area_empty() instead of open-coding
Date: Sun, 8 Mar 2020 21:27:08 +0800	[thread overview]
Message-ID: <20200308132708.GA7587@cqw-OptiPlex-7050> (raw)
In-Reply-To: <>

On Sun, Mar 08, 2020 at 05:29:55AM -0700, Matthew Wilcox wrote:
> On Sun, Mar 08, 2020 at 08:01:45PM +0800, wrote:
> >  		if (alloc_harder &&
> > -			!list_empty(&area->free_list[MIGRATE_HIGHATOMIC]))
> > +		    !free_area_empty(area, MIGRATE_HIGHATOMIC))
> I think these can now be one line?
> Also, I think free_area_empty() and a number of related functions can move
> from mmzone.h to mm/internal.h.  This will benefit all of us since mmzone.h
> is included from mm.h and so is widely seen throughout the kernel.

I agree.

      reply	other threads:[~2020-03-08 13:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-08 12:01 [PATCH] mm/page_alloc: use free_area_empty() instead of open-coding qiwuchen55
2020-03-08 12:29 ` Matthew Wilcox
2020-03-08 13:27   ` chenqiwu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200308132708.GA7587@cqw-OptiPlex-7050 \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).