From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FCA3C10F25 for ; Mon, 9 Mar 2020 06:20:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1CC9720728 for ; Mon, 9 Mar 2020 06:20:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oLuNqixN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1CC9720728 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A0D3F6B0003; Mon, 9 Mar 2020 02:20:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9BC776B0006; Mon, 9 Mar 2020 02:20:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8ABB46B0007; Mon, 9 Mar 2020 02:20:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 72BF26B0003 for ; Mon, 9 Mar 2020 02:20:51 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3EF8C6100 for ; Mon, 9 Mar 2020 06:20:51 +0000 (UTC) X-FDA: 76574825502.11.sort25_7bd2ee210d53c X-HE-Tag: sort25_7bd2ee210d53c X-Filterd-Recvd-Size: 4563 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Mon, 9 Mar 2020 06:20:50 +0000 (UTC) Received: by mail-pl1-f195.google.com with SMTP id w3so3560963plz.5 for ; Sun, 08 Mar 2020 23:20:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=g75Qh0w0IMlX/zV9hQvw54yKT3VrtMDkZu/Q14Db4QQ=; b=oLuNqixNl1JxNVT152qOq/xNxOVKrrzZ6dbHvCBWH/+3doPheUSai4W8Asav3nC6uU qdEv2xwxy2lA/KdtQMkqQ5FFkvz4Q5F7Cq598Htvjw6tVym6ZXB5wFlesntytgI8+TSj 3T0R+fC5Fyk9OrD2EaoizKfpnsFYktFYpsuD8L4qYUQvATxVO8f5L1/ezu7ZNh8U4a47 4XEYWEVzUzKzoycFQQi+5nySgzPSrZQWph39MGZ5OJMn2QV0b/knhiraNQexExmY02pg yI5Ed4aPCD/hqzR2JiRjsQhrkwxv8OVH12+aZ9NL25gytbe/L7taOxw0caVyRszKWETB kR8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=g75Qh0w0IMlX/zV9hQvw54yKT3VrtMDkZu/Q14Db4QQ=; b=f6T6fXIfFJ7k+Rn+Q9SAmUSvjaZckr426Jdlc5SmoZrs2lpyyq+ejKwRI+l3uoSZ1X rReTPEMpQgcv815dcwLxxF7Z3Nz/sSF4aBodiEkpofcVUQdsYEVcy2ijFgMugqXMRkQW 6epq4GHaT54QNp983SGb9VZtq/C+a1X8hD7UeTcEaMzg1NI40HS2Du46EF22FP04lh5G Bn36S6SIh4hjOtbMmEOCKDMUvbLBA19VidaCjgmZDUUqmeCtPblnHXnS30QUz1kh7XbN 080PADqHc+1+U/BlKAT0oQ5zfDLA9haXdtdjHidA9bFCSCAyLMHsqHf+p0cc9Cagd3Vm ygMA== X-Gm-Message-State: ANhLgQ1KfwssD1Iy/L5UOft/DOLOS2W/njOXeOjAoBGppbBo76hdAUih Yt36NjRi4xU8I4k6sfuihfo= X-Google-Smtp-Source: ADFU+vuTacwZljz++7mnGUt/1ePVmD3eBqPVSmeedFPkE4WHnu5hOKP7jdOfQMZ9g3/9NHhJm+yNiA== X-Received: by 2002:a17:902:70c8:: with SMTP id l8mr14211162plt.89.1583734849681; Sun, 08 Mar 2020 23:20:49 -0700 (PDT) Received: from localhost ([2401:fa00:8f:203:5bbb:c872:f2b1:f53b]) by smtp.gmail.com with ESMTPSA id l189sm3156157pga.64.2020.03.08.23.20.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Mar 2020 23:20:48 -0700 (PDT) Date: Mon, 9 Mar 2020 15:20:46 +0900 From: Sergey Senozhatsky To: Joe Perches Cc: Sergey Senozhatsky , Andrew Morton , Johannes Weiner , Michal Hocko , Vladimir Davydov , Hugh Dickins , Minchan Kim , Nitin Gupta , Sergey Senozhatsky , linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH] mm: Use fallthrough; Message-ID: <20200309062046.GA46830@google.com> References: <20200308031825.GB1125@jagdpanzerIV.localdomain> <5f297e8995b22c9ccf06d4d0a04f7d9a37d3cd77.camel@perches.com> <20200309041551.GA1765@jagdpanzerIV.localdomain> <84f3c9891d4e89909d5537f34ea9d75de339c415.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <84f3c9891d4e89909d5537f34ea9d75de339c415.camel@perches.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (20/03/08 21:51), Joe Perches wrote: > On Mon, 2020-03-09 at 13:15 +0900, Sergey Senozhatsky wrote: > > On (20/03/07 19:54), Joe Perches wrote: > > > On Sun, 2020-03-08 at 12:18 +0900, Sergey Senozhatsky wrote: > > > > On (20/03/06 23:58), Joe Perches wrote: > > > > [..] [..] > > > Consecutive case labels do not need an interleaving fallthrough; > > > > > > ie: ditto > > > > I see. Shall this be mentioned in the commit message, maybe? > > I've no real opinion about that necessity. > > fallthrough commments are relatively rarely used as a > separating element between case labels. > > It's by far most common to just have consecutive case labels > without any other content. > > It's somewhere between 500:1 to 1000:1 in the kernel. I thought that those labels were used by some static code analysis tools, so that the removal of some labels raised questions. But I don't think I have opinions otherwise. -ss