From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68E6DC10F27 for ; Mon, 9 Mar 2020 06:48:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0957420674 for ; Mon, 9 Mar 2020 06:48:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B6pVr9Ug" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0957420674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 75F9B6B0003; Mon, 9 Mar 2020 02:48:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 70F9D6B0006; Mon, 9 Mar 2020 02:48:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64D6B6B0007; Mon, 9 Mar 2020 02:48:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0175.hostedemail.com [216.40.44.175]) by kanga.kvack.org (Postfix) with ESMTP id 4C1376B0003 for ; Mon, 9 Mar 2020 02:48:11 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 08E3B180AD801 for ; Mon, 9 Mar 2020 06:48:11 +0000 (UTC) X-FDA: 76574894382.14.noise53_4767adaeab132 X-HE-Tag: noise53_4767adaeab132 X-Filterd-Recvd-Size: 4724 Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Mon, 9 Mar 2020 06:48:10 +0000 (UTC) Received: by mail-pf1-f195.google.com with SMTP id i13so4386288pfe.3 for ; Sun, 08 Mar 2020 23:48:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Y4UxGHAQZzEPyQy0KsfAI6f3ElLxET+uiuIqagGiKHY=; b=B6pVr9UgIF/7hOkq20mC2Tt8jES/c+2rAZeqAcgLBjERCMe3+hq3EpMlarZK9XW4j2 7Z4TjxwS3LhKwveWSWHGBN9wdcb2nxb4Epj0ixu30KrLq+maqRWnbOMn4UcEr8Dg9ipz yTnNGYdcXhxzg5vMpI9Oe2I+lC4Wq0sreAnJZMQqU7vBHps1ykJ26WyKrNCXxtN9hJ4N uybpbMx7yoss9Xln3TAb7zP+3CmV8CCEvfro2zQCJ8uMjQqQ/QSbBRJnWl02a1YUZo+E 2PftO9hM/qgTcb5zBGVg/hAnXyOVtN46PMS7R8nTLJcl4/mIjWOK5T+VEKNLfzuCOW4c pRjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Y4UxGHAQZzEPyQy0KsfAI6f3ElLxET+uiuIqagGiKHY=; b=KgVIziLanV1sKsdtdKicR8AsvrjLYjY0tddvMV3S4K/NnCe37hN9boVw3mMW2fR3KJ MA0RO8qFMfa6qXIMikJiS9ynEDqZbz6L6fOdAklWhoPZa39xCGR95Zz8GtWpuQs2LGrx UdoLBtpKL7TKo3+AwA7kfzSYG6YVChYbgD10MSmASRzyRu4CrqfPH1Exs4LPtunbeypx gFaxNWSGgfMaGlnbJZWZCMiw5RrjB/LDpXe5KyAm77qpCPFdmylzZCewlRluoxATYagj ubuWE4AmdP9xYeRcHZXYiuNdd7h2SqlHNlYjgne9PMp9nxmRgAQccc5xRYyrim6ulaH/ tiAg== X-Gm-Message-State: ANhLgQ3jBdws7D0DsX6DGMc42OYraRocoDkuj/GV7fROOqUshkY4a2JE pB/xn+E3WpHYDyBzQnpbokY= X-Google-Smtp-Source: ADFU+vuVCZqOpqiIus66R6ENXtbIH475h/jg+dfhpjNike4CDEGgLvQhXhpPqwTpSWgWrxGZp+umNA== X-Received: by 2002:aa7:87ca:: with SMTP id i10mr15040880pfo.169.1583736489516; Sun, 08 Mar 2020 23:48:09 -0700 (PDT) Received: from localhost ([2401:fa00:8f:203:5bbb:c872:f2b1:f53b]) by smtp.gmail.com with ESMTPSA id g20sm17126776pjv.20.2020.03.08.23.48.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Mar 2020 23:48:08 -0700 (PDT) Date: Mon, 9 Mar 2020 15:48:06 +0900 From: Sergey Senozhatsky To: Joe Perches Cc: Sergey Senozhatsky , Andrew Morton , Johannes Weiner , Michal Hocko , Vladimir Davydov , Hugh Dickins , Minchan Kim , Nitin Gupta , linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH] mm: Use fallthrough; Message-ID: <20200309064806.GB46830@google.com> References: <20200308031825.GB1125@jagdpanzerIV.localdomain> <5f297e8995b22c9ccf06d4d0a04f7d9a37d3cd77.camel@perches.com> <20200309041551.GA1765@jagdpanzerIV.localdomain> <84f3c9891d4e89909d5537f34ea9d75de339c415.camel@perches.com> <20200309062046.GA46830@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200309062046.GA46830@google.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (20/03/09 15:20), Sergey Senozhatsky wrote: [..] > > I've no real opinion about that necessity. > > > > fallthrough commments are relatively rarely used as a > > separating element between case labels. > > > > It's by far most common to just have consecutive case labels > > without any other content. > > > > It's somewhere between 500:1 to 1000:1 in the kernel. > > I thought that those labels were used by some static code analysis > tools, so that the removal of some labels raised questions. But I > don't think I have opinions otherwise. ... I guess GCC counts as a static code analysis tool :) Looking at previous commits, people wanted to have proper 'fall through' Replace "fallthru" with a proper "fall through" annotation. This fix is part of the ongoing efforts to enabling -Wimplicit-fallthrough --- - case ZPOOL_MM_RW: /* fallthru */ + case ZPOOL_MM_RW: /* fall through */ --- > Consecutive case labels do not need an interleaving fallthrough; I suppose this means that GCC -Wimplicit-fallthrough handles it? -ss