From: Andrew Morton <akpm@linux-foundation.org>
To: Wei Yang <richard.weiyang@linux.alibaba.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Tim Chen <tim.c.chen@linux.intel.com>
Subject: Re: [PATCH] mm/swap_slots.c: don't reset the cache slot after use
Date: Mon, 9 Mar 2020 17:48:54 -0700 [thread overview]
Message-ID: <20200309174854.b6b8c7f019c3dde048c28f94@linux-foundation.org> (raw)
In-Reply-To: <20200309090940.34130-1-richard.weiyang@linux.alibaba.com>
On Mon, 9 Mar 2020 17:09:40 +0800 Wei Yang <richard.weiyang@linux.alibaba.com> wrote:
> Currently we would clear the cache slot if it is used. While this is not
> necessary, since this entry would not be used until refilled.
>
> Leave it untouched and assigned the value directly to entry which makes
> the code little more neat.
>
> Also this patch merges the else and if, since this is the only case we
> refill and repeat swap cache.
cc Tim, who can hopefully remember how this code works ;)
> --- a/mm/swap_slots.c
> +++ b/mm/swap_slots.c
> @@ -309,7 +309,7 @@ int free_swap_slot(swp_entry_t entry)
>
> swp_entry_t get_swap_page(struct page *page)
> {
> - swp_entry_t entry, *pentry;
> + swp_entry_t entry;
> struct swap_slots_cache *cache;
>
> entry.val = 0;
> @@ -336,13 +336,10 @@ swp_entry_t get_swap_page(struct page *page)
> if (cache->slots) {
> repeat:
> if (cache->nr) {
> - pentry = &cache->slots[cache->cur++];
> - entry = *pentry;
> - pentry->val = 0;
> + entry = cache->slots[cache->cur++];
> cache->nr--;
> - } else {
> - if (refill_swap_slots_cache(cache))
> - goto repeat;
> + } else if (refill_swap_slots_cache(cache)) {
> + goto repeat;
> }
> }
> mutex_unlock(&cache->alloc_lock);
> --
> 2.20.1 (Apple Git-117)
next prev parent reply other threads:[~2020-03-10 0:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 9:09 [PATCH] mm/swap_slots.c: don't reset the cache slot after use Wei Yang
2020-03-10 0:48 ` Andrew Morton [this message]
2020-03-10 18:13 ` Tim Chen
2020-03-10 22:20 ` Wei Yang
2020-03-10 23:03 ` Tim Chen
2020-03-11 1:17 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200309174854.b6b8c7f019c3dde048c28f94@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=richard.weiyang@linux.alibaba.com \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).