From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: SeongJae Park <sjpark@amazon.com>
Cc: <akpm@linux-foundation.org>, SeongJae Park <sjpark@amazon.de>,
<aarcange@redhat.com>, <yang.shi@linux.alibaba.com>,
<acme@kernel.org>, <alexander.shishkin@linux.intel.com>,
<amit@kernel.org>, <brendan.d.gregg@gmail.com>,
<brendanhiggins@google.com>, <cai@lca.pw>,
<colin.king@canonical.com>, <corbet@lwn.net>, <dwmw@amazon.com>,
<jolsa@redhat.com>, <kirill@shutemov.name>,
<mark.rutland@arm.com>, <mgorman@suse.de>, <minchan@kernel.org>,
<mingo@redhat.com>, <namhyung@kernel.org>, <peterz@infradead.org>,
<rdunlap@infradead.org>, <rientjes@google.com>,
<rostedt@goodmis.org>, <shuah@kernel.org>, <sj38.park@gmail.com>,
<vbabka@suse.cz>, <vdavydov.dev@gmail.com>, <linux-mm@kvack.org>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 05/14] mm/damon: Implement callbacks
Date: Tue, 10 Mar 2020 09:01:16 +0000 [thread overview]
Message-ID: <20200310090116.0000723f@Huawei.com> (raw)
In-Reply-To: <20200224123047.32506-6-sjpark@amazon.com>
On Mon, 24 Feb 2020 13:30:38 +0100
SeongJae Park <sjpark@amazon.com> wrote:
> From: SeongJae Park <sjpark@amazon.de>
>
> This commit implements callbacks for DAMON. Using this, DAMON users can
> install their callbacks for each step of the access monitoring so that
> they can do something interesting with the monitored access pattrns
patterns
> online. For example, callbacks can report the monitored patterns to
> users or do some access pattern based memory management such as
> proactive reclamations or access pattern based THP promotions/demotions
> decision makings.
>
> Signed-off-by: SeongJae Park <sjpark@amazon.de>
> ---
> mm/damon.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/mm/damon.c b/mm/damon.c
> index 6a17408e83c2..554720778e8a 100644
> --- a/mm/damon.c
> +++ b/mm/damon.c
> @@ -83,6 +83,10 @@ struct damon_ctx {
> struct rnd_state rndseed;
>
> struct list_head tasks_list; /* 'damon_task' objects */
> +
> + /* callbacks */
> + void (*sample_cb)(struct damon_ctx *context);
> + void (*aggregate_cb)(struct damon_ctx *context);
> };
>
> /* Get a random number in [l, r) */
> @@ -814,9 +818,13 @@ static int kdamond_fn(void *data)
> }
> mmput(mm);
> }
> + if (ctx->sample_cb)
> + ctx->sample_cb(ctx);
>
> if (kdamond_aggregate_interval_passed(ctx)) {
> kdamond_merge_regions(ctx, max_nr_accesses / 10);
> + if (ctx->aggregate_cb)
> + ctx->aggregate_cb(ctx);
> kdamond_flush_aggregated(ctx);
> kdamond_split_regions(ctx);
> }
next prev parent reply other threads:[~2020-03-10 9:01 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 12:30 [PATCH v6 00/14] Introduce Data Access MONitor (DAMON) SeongJae Park
2020-02-24 12:30 ` [PATCH v6 01/14] mm: " SeongJae Park
2020-03-10 8:54 ` Jonathan Cameron
2020-03-10 11:50 ` SeongJae Park
2020-02-24 12:30 ` [PATCH v6 02/14] mm/damon: Implement region based sampling SeongJae Park
2020-03-10 8:57 ` Jonathan Cameron
2020-03-10 11:52 ` SeongJae Park
2020-03-10 15:55 ` Jonathan Cameron
2020-03-10 16:22 ` SeongJae Park
2020-03-10 17:39 ` Jonathan Cameron
2020-03-12 9:20 ` SeongJae Park
2020-03-13 17:29 ` Jonathan Cameron
2020-03-13 20:16 ` SeongJae Park
2020-03-17 11:32 ` SeongJae Park
2020-02-24 12:30 ` [PATCH v6 03/14] mm/damon: Adaptively adjust regions SeongJae Park
2020-03-10 8:57 ` Jonathan Cameron
2020-03-10 11:53 ` SeongJae Park
2020-02-24 12:30 ` [PATCH v6 04/14] mm/damon: Apply dynamic memory mapping changes SeongJae Park
2020-03-10 9:00 ` Jonathan Cameron
2020-03-10 11:53 ` SeongJae Park
2020-02-24 12:30 ` [PATCH v6 05/14] mm/damon: Implement callbacks SeongJae Park
2020-03-10 9:01 ` Jonathan Cameron [this message]
2020-03-10 11:55 ` SeongJae Park
2020-02-24 12:30 ` [PATCH v6 06/14] mm/damon: Implement access pattern recording SeongJae Park
2020-03-10 9:01 ` Jonathan Cameron
2020-03-10 11:55 ` SeongJae Park
2020-02-24 12:30 ` [PATCH v6 07/14] mm/damon: Implement kernel space API SeongJae Park
2020-03-10 9:01 ` Jonathan Cameron
2020-03-10 11:56 ` SeongJae Park
2020-02-24 12:30 ` [PATCH v6 08/14] mm/damon: Add debugfs interface SeongJae Park
2020-03-10 9:02 ` Jonathan Cameron
2020-03-10 11:56 ` SeongJae Park
2020-02-24 12:30 ` [PATCH v6 09/14] mm/damon: Add a tracepoint for result writing SeongJae Park
2020-03-10 9:03 ` Jonathan Cameron
2020-03-10 11:57 ` SeongJae Park
2020-02-24 12:30 ` [PATCH v6 10/14] tools: Add a minimal user-space tool for DAMON SeongJae Park
2020-02-24 12:30 ` [PATCH v6 11/14] Documentation/admin-guide/mm: Add a document " SeongJae Park
2020-03-10 9:03 ` Jonathan Cameron
2020-03-10 11:57 ` SeongJae Park
2020-02-24 12:30 ` [PATCH v6 12/14] mm/damon: Add kunit tests SeongJae Park
2020-02-24 12:30 ` [PATCH v6 13/14] mm/damon: Add user selftests SeongJae Park
2020-02-24 12:30 ` [PATCH v6 14/14] MAINTAINERS: Update for DAMON SeongJae Park
2020-03-02 11:35 ` [PATCH v6 00/14] Introduce Data Access MONitor (DAMON) SeongJae Park
2020-03-09 10:23 ` SeongJae Park
2020-03-10 17:21 ` Shakeel Butt
2020-03-12 10:07 ` SeongJae Park
2020-03-12 10:43 ` SeongJae Park
2020-03-18 19:52 ` Shakeel Butt
2020-03-19 9:03 ` SeongJae Park
2020-03-23 17:29 ` Shakeel Butt
2020-03-24 8:34 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200310090116.0000723f@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=aarcange@redhat.com \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=amit@kernel.org \
--cc=brendan.d.gregg@gmail.com \
--cc=brendanhiggins@google.com \
--cc=cai@lca.pw \
--cc=colin.king@canonical.com \
--cc=corbet@lwn.net \
--cc=dwmw@amazon.com \
--cc=jolsa@redhat.com \
--cc=kirill@shutemov.name \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=sj38.park@gmail.com \
--cc=sjpark@amazon.com \
--cc=sjpark@amazon.de \
--cc=vbabka@suse.cz \
--cc=vdavydov.dev@gmail.com \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).