From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CF99C10F27 for ; Tue, 10 Mar 2020 10:10:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 35FE920637 for ; Tue, 10 Mar 2020 10:10:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35FE920637 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BDFEB6B0005; Tue, 10 Mar 2020 06:10:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B690D6B0006; Tue, 10 Mar 2020 06:10:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A30706B0007; Tue, 10 Mar 2020 06:10:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0063.hostedemail.com [216.40.44.63]) by kanga.kvack.org (Postfix) with ESMTP id 8823E6B0005 for ; Tue, 10 Mar 2020 06:10:48 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 548B8181AC9CB for ; Tue, 10 Mar 2020 10:10:48 +0000 (UTC) X-FDA: 76579033776.11.prose63_6fd124f44b17 X-HE-Tag: prose63_6fd124f44b17 X-Filterd-Recvd-Size: 3370 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Tue, 10 Mar 2020 10:10:47 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id 25so641645wmk.3 for ; Tue, 10 Mar 2020 03:10:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=w1muF95flLMeOHW3vwFj3CGt+CE8hwju5evxMy9X1pY=; b=ZrVMX3xL8QpT5pj7Uvs/VHlCOQkAsrfT5hjLvl8I4+TqV7IaMczzfmv7e/OwlJCBfb OgjXmcNijcRDGthCm5LNO4V6WJQuJrM0X/rRV+YDgqZ3AXGkcry3imZnTfMTDmcT95rb uuXluMhA+CX32IZlcsaDOvQOd4FHzj2t4zJjDleQZHLDjPc9eU5aIAX5bONN2gNp24w8 mpoIgGubecorTnTIH3njRPrCgEpdAARJjlSg6MErmiIErH1KBS4zczV8IoseukUHwByb ZTinfKo/J2jaYdkio7gBwkkPv6L5XOb+1eY1iXvk0pdQan48pfG26Cd9oT90rA9ZrPPn rDZw== X-Gm-Message-State: ANhLgQ3ztw1xCKlgPHydxIuqmTqQPqosY9oxeaDP7tysmji3Ec2o3BNk 4cVP4lRUA5VihmELb6bziQaTTMTy X-Google-Smtp-Source: ADFU+vvw4aVKgyY94Ay1EuF0rQhBEU+88Lja8aXifwqEBvY2KByO+ZUAAMMA8lve4IU+xtfx6wGBog== X-Received: by 2002:a1c:a502:: with SMTP id o2mr1391124wme.94.1583835046625; Tue, 10 Mar 2020 03:10:46 -0700 (PDT) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id u1sm46731381wrt.78.2020.03.10.03.10.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2020 03:10:45 -0700 (PDT) Date: Tue, 10 Mar 2020 11:10:44 +0100 From: Michal Hocko To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, x86@kernel.org Subject: Re: [PATCH] x86/mm: Remove the redundant conditional check Message-ID: <20200310101044.GE8447@dhcp22.suse.cz> References: <20200308013511.12792-1-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200308013511.12792-1-bhe@redhat.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun 08-03-20 09:35:11, Baoquan He wrote: > In commit f70029bbaacbfa8f0 ("mm, memory_hotplug: drop CONFIG_MOVABLE_NODE"), > the dependency on CONFIG_MOVABLE_NODE was removed for N_MEMORY, so the > conditional check in paging_init() doesn't make any sense any more. > Remove it. Please expand more. I would really have to refresh the intention of the code but from a quick look at the code CONFIG_HIGHMEM still makes N_MEMORY != N_NORMAL_MEMORY. So what what does this change mean for that config? > Signed-off-by: Baoquan He > --- > arch/x86/mm/init_64.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c > index abbdecb75fad..0a14711d3a93 100644 > --- a/arch/x86/mm/init_64.c > +++ b/arch/x86/mm/init_64.c > @@ -818,8 +818,7 @@ void __init paging_init(void) > * will not set it back. > */ > node_clear_state(0, N_MEMORY); > - if (N_MEMORY != N_NORMAL_MEMORY) > - node_clear_state(0, N_NORMAL_MEMORY); > + node_clear_state(0, N_NORMAL_MEMORY); > > zone_sizes_init(); > } > -- > 2.17.2 > -- Michal Hocko SUSE Labs