From: Michal Hocko <mhocko@kernel.org>
To: David Hildenbrand <david@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
virtio-dev@lists.oasis-open.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
"Michael S . Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Oscar Salvador <osalvador@suse.de>,
Igor Mammedov <imammedo@redhat.com>,
Dave Young <dyoung@redhat.com>,
Dan Williams <dan.j.williams@intel.com>,
Pavel Tatashin <pasha.tatashin@soleen.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH v1 07/11] virtio-mem: Allow to offline partially unplugged memory blocks
Date: Tue, 10 Mar 2020 12:43:12 +0100 [thread overview]
Message-ID: <20200310114312.GG8447@dhcp22.suse.cz> (raw)
In-Reply-To: <20200302134941.315212-8-david@redhat.com>
On Mon 02-03-20 14:49:37, David Hildenbrand wrote:
[...]
> +static void virtio_mem_notify_going_offline(struct virtio_mem *vm,
> + unsigned long mb_id)
> +{
> + const unsigned long nr_pages = PFN_DOWN(vm->subblock_size);
> + unsigned long pfn;
> + int sb_id, i;
> +
> + for (sb_id = 0; sb_id < vm->nb_sb_per_mb; sb_id++) {
> + if (virtio_mem_mb_test_sb_plugged(vm, mb_id, sb_id, 1))
> + continue;
> + /*
> + * Drop our reference to the pages so the memory can get
> + * offlined and add the unplugged pages to the managed
> + * page counters (so offlining code can correctly subtract
> + * them again).
> + */
> + pfn = PFN_DOWN(virtio_mem_mb_id_to_phys(mb_id) +
> + sb_id * vm->subblock_size);
> + adjust_managed_page_count(pfn_to_page(pfn), nr_pages);
> + for (i = 0; i < nr_pages; i++)
> + page_ref_dec(pfn_to_page(pfn + i));
Is there ever situation this might be a different than 1->0 transition?
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2020-03-10 11:43 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 13:49 [PATCH v1 00/11] virtio-mem: paravirtualized memory David Hildenbrand
2020-03-02 13:49 ` [PATCH v1 01/11] ACPI: NUMA: export pxm_to_node David Hildenbrand
2020-03-02 14:03 ` Michal Hocko
2020-03-02 14:09 ` David Hildenbrand
2020-03-02 13:49 ` [PATCH v1 02/11] virtio-mem: Paravirtualized memory hotplug David Hildenbrand
2020-03-03 2:24 ` kbuild test robot
2020-03-03 8:06 ` David Hildenbrand
2020-03-02 13:49 ` [PATCH v1 03/11] virtio-mem: Paravirtualized memory hotunplug part 1 David Hildenbrand
2020-03-02 13:49 ` [PATCH v1 04/11] mm: Export alloc_contig_range() / free_contig_range() David Hildenbrand
2020-03-02 14:05 ` Michal Hocko
2020-03-02 14:17 ` David Hildenbrand
2020-03-02 13:49 ` [PATCH v1 05/11] virtio-mem: Paravirtualized memory hotunplug part 2 David Hildenbrand
2020-03-02 13:49 ` [PATCH v1 06/11] mm: Allow to offline unmovable PageOffline() pages via MEM_GOING_OFFLINE David Hildenbrand
2020-03-02 17:40 ` Alexander Duyck
2020-03-02 18:41 ` David Hildenbrand
2020-03-10 11:47 ` Michal Hocko
2020-03-10 11:48 ` David Hildenbrand
2020-03-02 13:49 ` [PATCH v1 07/11] virtio-mem: Allow to offline partially unplugged memory blocks David Hildenbrand
2020-03-10 11:43 ` Michal Hocko [this message]
2020-03-10 11:46 ` David Hildenbrand
2020-03-10 11:59 ` Michal Hocko
2020-03-10 12:09 ` David Hildenbrand
2020-03-02 13:49 ` [PATCH v1 08/11] mm/memory_hotplug: Introduce offline_and_remove_memory() David Hildenbrand
2020-03-02 14:27 ` Michal Hocko
2020-03-02 13:49 ` [PATCH v1 09/11] virtio-mem: Offline and remove completely unplugged memory blocks David Hildenbrand
2020-03-02 13:49 ` [PATCH v1 10/11] virtio-mem: Better retry handling David Hildenbrand
2020-03-02 13:49 ` [PATCH v1 11/11] MAINTAINERS: Add myself as virtio-mem maintainer David Hildenbrand
2020-03-02 18:15 ` [PATCH v1 00/11] virtio-mem: paravirtualized memory David Hildenbrand
2020-03-02 18:29 ` Michal Hocko
2020-03-02 18:41 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200310114312.GG8447@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=dyoung@redhat.com \
--cc=imammedo@redhat.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mst@redhat.com \
--cc=osalvador@suse.de \
--cc=pasha.tatashin@soleen.com \
--cc=stefanha@redhat.com \
--cc=vbabka@suse.cz \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).