From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E357C10F27 for ; Tue, 10 Mar 2020 12:48:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 518602468D for ; Tue, 10 Mar 2020 12:48:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="D3NA9npq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 518602468D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E26FC6B0005; Tue, 10 Mar 2020 08:48:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DD6B36B0006; Tue, 10 Mar 2020 08:48:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC55B6B0007; Tue, 10 Mar 2020 08:48:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0034.hostedemail.com [216.40.44.34]) by kanga.kvack.org (Postfix) with ESMTP id AEA096B0005 for ; Tue, 10 Mar 2020 08:48:31 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id BEE083CEA for ; Tue, 10 Mar 2020 12:48:31 +0000 (UTC) X-FDA: 76579431222.04.kite38_49f932a3ab031 X-HE-Tag: kite38_49f932a3ab031 X-Filterd-Recvd-Size: 2360 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Tue, 10 Mar 2020 12:48:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YVB057vmEw7bmDKbUVmH778DYj3K42QSsHVDfEy6JF8=; b=D3NA9npqg/p2ly6eNHaUyaOezq R/IfhLt+dFMIL8a98ni3yYmG4zn6w6PjYmc0gmpc4V4HGI5yhOpd/JenmAARQPAAM6h4yQ4/P4EDk 97C7hxw8WnS/bFntXintPxSyqfZtLWs7HOymAQ10mE2nUhhNphWaT+zSDyqnIHJ1USovIfmGrjkNq 82ezB4/x8002OuzjoTI9evjJy5QqL9YyF3QnNvSgZgvXT2OtPhMsI+Wzoen5/NWsMwFFTiuPwlX8x P7+EdHr1X6mwrt6xYL/tc/LN+nHgPVmiLqHXLkBjJ/LbwDE8ZUkd68bi5ZP0DkRvc1Xati3Z5K/u4 uBfef0DA==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBeIz-0002In-3Y; Tue, 10 Mar 2020 12:48:17 +0000 Date: Tue, 10 Mar 2020 05:48:17 -0700 From: Matthew Wilcox To: qiwuchen55@gmail.com Cc: akpm@linux-foundation.org, vbabka@suse.cz, pankaj.gupta.linux@gmail.com, alexander.duyck@gmail.com, bhe@redhat.com, linux-mm@kvack.org, chenqiwu Subject: Re: [PATCH v3] mm/page_alloc: simplify page_is_buddy() for better code readability Message-ID: <20200310124817.GA22433@bombadil.infradead.org> References: <1583831729-14383-1-git-send-email-qiwuchen55@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1583831729-14383-1-git-send-email-qiwuchen55@gmail.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 10, 2020 at 05:15:29PM +0800, qiwuchen55@gmail.com wrote: > Simplify page_is_buddy() to reduce the redundant code for better code > readability. If you're making these larger changes, then ... > @@ -794,29 +794,23 @@ static inline void set_page_order(struct page *page, unsigned int order) > static inline int page_is_buddy(struct page *page, struct page *buddy, > unsigned int order) Ideally this should return 'bool'. > + /* > + * zone check is done late to avoid uselessly > + * calculating zone/node ids for pages that could > + * never merge. > + */ This comment could be reflowed onto fewer lines.