From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C5F6C10F27 for ; Tue, 10 Mar 2020 18:56:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B69B420637 for ; Tue, 10 Mar 2020 18:56:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="VEOUllcI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B69B420637 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6D1F56B0005; Tue, 10 Mar 2020 14:56:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A8A16B0006; Tue, 10 Mar 2020 14:56:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5BF256B0007; Tue, 10 Mar 2020 14:56:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0100.hostedemail.com [216.40.44.100]) by kanga.kvack.org (Postfix) with ESMTP id 3FEEA6B0005 for ; Tue, 10 Mar 2020 14:56:13 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id F1B45180AD806 for ; Tue, 10 Mar 2020 18:56:12 +0000 (UTC) X-FDA: 76580357784.23.fire47_5359f33d41e0b X-HE-Tag: fire47_5359f33d41e0b X-Filterd-Recvd-Size: 2658 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Tue, 10 Mar 2020 18:56:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=A+/aOzWG8LHRacyap8ZCXfmxiwfWZVIWCRbwBZQmtTI=; b=VEOUllcIWKDzfG7QeEtjVSno+3 PfrPgtTQxYOpv8+Zma0ksgX3muvFp/28b++IsmMAVQY7r8XFBkej6G3jHlRlVSnkKGh8RgInuLtAo Mr/JyE9Z94f496vd4FABj3wj4kkpo5Y+IPwHqldD1wCATNN0wnWY5eAQ+CJtQS9lSDrHBqKsafqee rfDhSetleWubwsi0muNv0kWJtFgb1YL/c62c/i17CFqTu6WdNPbD5Th02QiR80SO+45m+3HwThzv4 UtEhpwGdrgKuklYOPlKITxSFyQIJi64/rWeJLoGODlIQ/SeclzHl+DdgMUIOnmeyp2tWIbLW7dK+k T0S0Gz8g==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBk31-0003qM-36; Tue, 10 Mar 2020 18:56:11 +0000 From: Matthew Wilcox To: Andrew Morton , Vlastimil Babka , linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" Subject: [PATCH] mm: Make PageType more efficient Date: Tue, 10 Mar 2020 11:56:09 -0700 Message-Id: <20200310185609.5401-1-willy@infradead.org> X-Mailer: git-send-email 2.21.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: "Matthew Wilcox (Oracle)" PageType is a little hard for GCC to reason about, By checking ((~A) & flag) instead of (flag & (A | MASK) =3D=3D MASK), GCC can do better optimisations, saving 652 bytes in page_alloc.o (which is a heavy user of PageBuddy). Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/page-flags.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h index 1bf83c8fcaa7..8fc0876e2794 100644 --- a/include/linux/page-flags.h +++ b/include/linux/page-flags.h @@ -725,14 +725,14 @@ PAGEFLAG_FALSE(DoubleMap) #define PG_table 0x00000400 #define PG_guard 0x00000800 =20 -#define PageType(page, flag) \ - ((page->page_type & (PAGE_TYPE_BASE | flag)) =3D=3D PAGE_TYPE_BASE) - static inline int page_has_type(struct page *page) { return (int)page->page_type < PAGE_MAPCOUNT_RESERVE; } =20 +#define PageType(page, flag) \ + (page_has_type(page) && (~page->page_type & flag)) + #define PAGE_TYPE_OPS(uname, lname) \ static __always_inline int Page##uname(struct page *page) \ { \ --=20 2.25.1