From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.4 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, FSL_HELO_FAKE,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EBEFC18E5A for ; Tue, 10 Mar 2020 22:24:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E25EB2071B for ; Tue, 10 Mar 2020 22:24:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KkWPHp8F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E25EB2071B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 830D56B0003; Tue, 10 Mar 2020 18:24:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B9EF6B0006; Tue, 10 Mar 2020 18:24:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 681626B0007; Tue, 10 Mar 2020 18:24:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0141.hostedemail.com [216.40.44.141]) by kanga.kvack.org (Postfix) with ESMTP id 4CCC46B0003 for ; Tue, 10 Mar 2020 18:24:13 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 25AB1878D for ; Tue, 10 Mar 2020 22:24:13 +0000 (UTC) X-FDA: 76580881986.24.chain25_7afe9493fa46 X-HE-Tag: chain25_7afe9493fa46 X-Filterd-Recvd-Size: 5245 Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Tue, 10 Mar 2020 22:24:12 +0000 (UTC) Received: by mail-pj1-f65.google.com with SMTP id a16so1046816pju.3 for ; Tue, 10 Mar 2020 15:24:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=VHQdCYc7HG4lQiYGqYUT5UP51+C0gUPiE/s2rIkKRtU=; b=KkWPHp8FUpWnyRN0umq7ZqUU6jx3hk5cpOiUL4uPzrawKLv6TEL2yRPitkww/xZ7ya XOqwqFZQsUEJKkK9U20KiQTHiu14dxVnrL5+EOQzVZSz7hs4StJIAXm3kZxcD9RmNGNM emB5EPlE9QfM63BvIiGnpUSAhQrvLunoPAx/lobQa872nLgOuNWUbPUy+Q5Jjhwr/p5n D/xRRguId/b38RtD6CE8iZYcd4wFGQHNxmkw98D+feGYjCGUmbc1CZf558wu+g47zvNu NfS+KuzM9qvdrLwUlx4Vu+cZ9QOUraHCYo+HIc/IDhoNFUxm2SmtLEbSOIvA5KAuaFR/ fPuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=VHQdCYc7HG4lQiYGqYUT5UP51+C0gUPiE/s2rIkKRtU=; b=j0K4pyksF/AFLUHsd7Ojmt/gImP/lP2n3zVU1VzVoGm8vF+yLSrYxGIbhQ5DFi/tM4 WD99NtxyE112bq633XiWtQSMeWTMXAmYGyi9aCvdxg94ph8uHbbLpI1C0dy3uY1GvlTy k/oCzbfpAe9wwxWxHifCLJWhzPeFSKsGiBn6XfFBscPzSkNVaMaepfpuE2UueAhypxAZ uDjBgGlF49xsv/phvEksf0uLQOpiUiOoaOBxPsm2eeF6lhdu8eO+lOwQuLLtIoXlUdUd koc+l1guKIr37XnW/PMrBvyR2aa8pJtKWc0UIcw4igXRkv7TiUUYUfag8jUBe+kRLquQ 6UTQ== X-Gm-Message-State: ANhLgQ3+HviHTdpXMFyWnK4owj2Llb9uYdGpy7pWjfei/F3LzpJsjhQc +vAryw0Pp2fKDFBjEql3CRs= X-Google-Smtp-Source: ADFU+vscvd0WY2fsGo8nNRttNgBNSpAdv2WUgdhACEYKmMYI3pA4z6251Yz9qfEoSYIvhhu71/jlYg== X-Received: by 2002:a17:90a:2ec7:: with SMTP id h7mr138998pjs.107.1583879051429; Tue, 10 Mar 2020 15:24:11 -0700 (PDT) Received: from google.com ([2620:15c:211:1:3e01:2939:5992:52da]) by smtp.gmail.com with ESMTPSA id 139sm25480434pfy.70.2020.03.10.15.24.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2020 15:24:10 -0700 (PDT) Date: Tue, 10 Mar 2020 15:24:08 -0700 From: Minchan Kim To: Vlastimil Babka Cc: Andrew Morton , LKML , linux-mm , linux-api@vger.kernel.org, oleksandr@redhat.com, Suren Baghdasaryan , Tim Murray , Daniel Colascione , Sandeep Patil , Sonny Rao , Brian Geffon , Michal Hocko , Johannes Weiner , Shakeel Butt , John Dias , Joel Fernandes , Jann Horn , alexander.h.duyck@linux.intel.com, sj38.park@gmail.com Subject: Re: [PATCH v7 3/7] mm: check fatal signal pending of target process Message-ID: <20200310222408.GC72963@google.com> References: <20200302193630.68771-1-minchan@kernel.org> <20200302193630.68771-4-minchan@kernel.org> <2f3a9530-483d-0861-3844-bc12d212dd93@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2f3a9530-483d-0861-3844-bc12d212dd93@suse.cz> User-Agent: Mutt/1.12.2 (2019-09-21) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 06, 2020 at 11:22:07AM +0100, Vlastimil Babka wrote: > On 3/2/20 8:36 PM, Minchan Kim wrote: > > Bail out to prevent unnecessary CPU overhead if target process has > > pending fatal signal during (MADV_COLD|MADV_PAGEOUT) operation. > > > > Reviewed-by: Suren Baghdasaryan > > Signed-off-by: Minchan Kim > > Reviewed-by: Vlastimil Babka > > Nit below: > > > --- > > mm/madvise.c | 29 +++++++++++++++++++++-------- > > 1 file changed, 21 insertions(+), 8 deletions(-) > > > > diff --git a/mm/madvise.c b/mm/madvise.c > > index 349473fc6683..6543f2bfc3d8 100644 > > --- a/mm/madvise.c > > +++ b/mm/madvise.c > > @@ -36,6 +36,7 @@ > > struct madvise_walk_private { > > struct mmu_gather *tlb; > > bool pageout; > > + struct task_struct *target_task; > > }; > > > > /* > > @@ -316,6 +317,10 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd, > > if (fatal_signal_pending(current)) > > return -EINTR; > > > > + if (private->target_task && > > + fatal_signal_pending(private->target_task)) > > + return -EINTR; > > With madvise(2) private->target_task will be current, thus current will be > tested twice. Not wrong, but maybe add a "private->target_task != current" > condition? It was in old series but removed because reviewer(IIRC, suren) wanted it. I am not strong preference either way. Since you said it's nit and considering other reviewer wanted to remove it, I will not change further. Thanks!