From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, FSL_HELO_FAKE,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 720F7C10DCE for ; Tue, 10 Mar 2020 22:28:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1EB752051A for ; Tue, 10 Mar 2020 22:28:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RwSdSfQX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1EB752051A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AECAE6B0003; Tue, 10 Mar 2020 18:28:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A9CF46B0006; Tue, 10 Mar 2020 18:28:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98C5C6B0007; Tue, 10 Mar 2020 18:28:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0148.hostedemail.com [216.40.44.148]) by kanga.kvack.org (Postfix) with ESMTP id 7EC236B0003 for ; Tue, 10 Mar 2020 18:28:19 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 49C8C8135 for ; Tue, 10 Mar 2020 22:28:19 +0000 (UTC) X-FDA: 76580892318.26.power26_2b813477da90d X-HE-Tag: power26_2b813477da90d X-Filterd-Recvd-Size: 5971 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Tue, 10 Mar 2020 22:28:18 +0000 (UTC) Received: by mail-pf1-f193.google.com with SMTP id l184so140923pfl.7 for ; Tue, 10 Mar 2020 15:28:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=VFg3q0grHf1UJPJBnQv+kbuTClZa3VwGIYfaQUbxb0M=; b=RwSdSfQXspQhwN8CTBXVxGFwOeubmgD36ZRj+zPgQ5bDLNVgBhJn0KKdKUubjIr/4z WWnYDKwHju68X14pD0oqQD0ZThVwXSlA2ITsaotTEfuUi6wxYEtOKV6z5Tl1Dqy9PRXA 5s143nTEfkJln7Jy6/OrTGAg7ecTOBOGBGSnsXiyNOI7b6z1Gc922x7Bj4onH4f5CFuT +u5JYJbv7Fvl7HlRDGabTULLfxxiQ+t/jbgFv9PojrfZONVgPuz+k/rY1sjguzbn8W12 KKaH26PRG0TbZSKYDkCvoYqu9jaA0ZjKvhgjvPXUoTIcN3H4Q8l1rqqIFc17w5RK/qKF 4v/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=VFg3q0grHf1UJPJBnQv+kbuTClZa3VwGIYfaQUbxb0M=; b=X5N0kwot13qCCm2xukgOSVPNrOmrzSUdVS/tJmfYCJBiLj873c9sIepq84QpASRRuo JW1cM6bYtmgqdP1++vd+cnGS/iWPTtbJVxtzaAmtwbve06z8cqiffEuvw++aau9z2rpE WxjRJhnI6pfX5vCgPK9EMotdLo2abmmBgvz/I0yxhITQsrPQm2svsLNL/qHlNNFxOi2/ PIOeMYdpuqbX2HkVJalYXqaxYNzeel17mHGHaloA70LdXkkAyDjLhr0is85X3cgOTECL sxz/R+lNlNGvmdkqSJ7ED5zG1ysSYn/NVHsiDUdjKfPTrm3XoOuutGPSOtbcxLngIIgl 2vdg== X-Gm-Message-State: ANhLgQ1vWeBUT+M3U7DTMaaSaK4ANCUK3tYMTrsjjN58t2IsttNUqH1M P1yh4YgI06kJyM55BbQn9Jg= X-Google-Smtp-Source: ADFU+vsH6xyex3g3JYae9c8u5H/eF0+Q/hnTxWXi2RQIsrRas5S/3RLdKPogUdLuQvtAajmbzJqVPA== X-Received: by 2002:a63:2e49:: with SMTP id u70mr22485024pgu.202.1583879297724; Tue, 10 Mar 2020 15:28:17 -0700 (PDT) Received: from google.com ([2620:15c:211:1:3e01:2939:5992:52da]) by smtp.gmail.com with ESMTPSA id q15sm12160875pgn.68.2020.03.10.15.28.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2020 15:28:16 -0700 (PDT) Date: Tue, 10 Mar 2020 15:28:15 -0700 From: Minchan Kim To: Oleksandr Natalenko Cc: Vlastimil Babka , Andrew Morton , LKML , linux-mm , linux-api@vger.kernel.org, Suren Baghdasaryan , Tim Murray , Daniel Colascione , Sandeep Patil , Sonny Rao , Brian Geffon , Michal Hocko , Johannes Weiner , Shakeel Butt , John Dias , Joel Fernandes , Jann Horn , alexander.h.duyck@linux.intel.com, sj38.park@gmail.com Subject: Re: [PATCH v7 6/7] mm/madvise: employ mmget_still_valid for write lock Message-ID: <20200310222815.GD72963@google.com> References: <20200302193630.68771-1-minchan@kernel.org> <20200302193630.68771-7-minchan@kernel.org> <20200306130303.kztv64f52qknxb6k@butterfly.localdomain> <86fc8d7b-ad6b-1691-b022-025d01e9e8e3@suse.cz> <20200309123045.o4cwni3ra6zq6ha2@butterfly.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200309123045.o4cwni3ra6zq6ha2@butterfly.localdomain> User-Agent: Mutt/1.12.2 (2019-09-21) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 09, 2020 at 01:30:45PM +0100, Oleksandr Natalenko wrote: > On Fri, Mar 06, 2020 at 05:03:50PM +0100, Vlastimil Babka wrote: > > On 3/6/20 2:03 PM, Oleksandr Natalenko wrote: > > > Hello. > > > > > > On Fri, Mar 06, 2020 at 01:52:07PM +0100, Vlastimil Babka wrote: > > >> > diff --git a/mm/madvise.c b/mm/madvise.c > > >> > index e794367f681e..e77c6c1fad34 100644 > > >> > --- a/mm/madvise.c > > >> > +++ b/mm/madvise.c > > >> > @@ -1118,6 +1118,8 @@ int do_madvise(struct task_struct *target_task, struct mm_struct *mm, > > >> > if (write) { > > >> > if (down_write_killable(&mm->mmap_sem)) > > >> > return -EINTR; > > >> > + if (current->mm != mm && !mmget_still_valid(mm)) > > >> > + goto skip_mm; > > >> > > >> This will return 0, is that correct? Shoudln't there be a similar error e.g. as > > >> when finding the task by pid fails (-ESRCH ?), because IIUC the task here is > > >> going away and dumping the core? > > > > > > Yeah. > > > > > > Something like this then: > > > > > > === > > > diff --git a/mm/madvise.c b/mm/madvise.c > > > index 48d1da08c160..7ed2f4d13924 100644 > > > --- a/mm/madvise.c > > > +++ b/mm/madvise.c > > > @@ -1122,6 +1122,10 @@ int do_madvise(struct task_struct *target_task, struct mm_struct *mm, > > > if (write) { > > > if (down_write_killable(&mm->mmap_sem)) > > > return -EINTR; > > > + if (current->mm != mm && !mmget_still_valid(mm)) { > > > + error = -ESRCH; > > > + goto skip_mm; > > > + } > > > } else { > > > down_read(&mm->mmap_sem); > > > } > > > @@ -1173,6 +1177,7 @@ int do_madvise(struct task_struct *target_task, struct mm_struct *mm, > > > } > > > out: > > > blk_finish_plug(&plug); > > > +skip_mm: > > > if (write) > > > up_write(&mm->mmap_sem); > > > else > > > > > > === > > > > > > ? > > > > Yep, thanks. > > > > Minchan, shall you take this change into the next submission, or you'd > prefer me sending it to you as a new patch? I should send patchset again so I will take it. Thanks!