From: Baoquan He <bhe@redhat.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, david@redhat.com,
richardw.yang@linux.intel.com, dan.j.williams@intel.com,
osalvador@suse.de, rppt@linux.ibm.com
Subject: Re: [PATCH v3 5/7] mm/sparse.c: add note about only VMEMMAP supporting sub-section support
Date: Wed, 11 Mar 2020 12:20:52 +0800 [thread overview]
Message-ID: <20200311042052.GI27711@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20200310144616.GM8447@dhcp22.suse.cz>
On 03/10/20 at 03:46pm, Michal Hocko wrote:
> On Sat 07-03-20 16:42:27, Baoquan He wrote:
> > And tell check_pfn_span() gating the porper alignment and size of
> > hot added memory region.
> >
> > And also move the code comments from inside section_deactivate()
> > to being above it. The code comments are reasonable for the whole
> > function, and the moving makes code cleaner.
> >
> > Signed-off-by: Baoquan He <bhe@redhat.com>
>
> Acked-by: Michal Hocko <mhocko@suse.com>
>
> I have glanced through other patches and they seem sane but I do not
> have time to go deeper to give an ack. I like this one though because it
> really makes the intention clearer.
Thanks for your reviewing and providing ack on this patch.
I will post a new version to rebase on the top of patch 1 and its
appended fix, then address those concerns from David.
next prev parent reply other threads:[~2020-03-11 4:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-07 8:42 [PATCH v3 0/7] mm/hotplug: Only use subsection map for VMEMMAP Baoquan He
2020-03-07 8:42 ` [PATCH v3 1/7] mm/hotplug: fix hot remove failure in SPARSEMEM|!VMEMMAP case Baoquan He
2020-03-07 20:59 ` Andrew Morton
2020-03-07 22:55 ` Baoquan He
2020-03-09 8:56 ` David Hildenbrand
2020-03-09 8:58 ` David Hildenbrand
2020-03-09 13:18 ` Baoquan He
2020-03-09 13:22 ` David Hildenbrand
2020-03-09 10:13 ` Pankaj Gupta
2020-03-09 12:56 ` Michal Hocko
2020-03-07 8:42 ` [PATCH v3 2/7] mm/sparse.c: introduce new function fill_subsection_map() Baoquan He
2020-03-07 8:42 ` [PATCH v3 3/7] mm/sparse.c: introduce a new function clear_subsection_map() Baoquan He
2020-03-09 8:59 ` David Hildenbrand
2020-03-09 13:32 ` Baoquan He
2020-03-09 13:38 ` David Hildenbrand
2020-03-09 14:07 ` Baoquan He
2020-03-07 8:42 ` [PATCH v3 4/7] mm/sparse.c: only use subsection map in VMEMMAP case Baoquan He
2020-03-09 9:00 ` David Hildenbrand
2020-03-07 8:42 ` [PATCH v3 5/7] mm/sparse.c: add note about only VMEMMAP supporting sub-section support Baoquan He
2020-03-07 11:55 ` Baoquan He
2020-03-10 14:46 ` Michal Hocko
2020-03-11 4:20 ` Baoquan He [this message]
2020-03-07 8:42 ` [PATCH v3 6/7] mm/sparse.c: move subsection_map related codes together Baoquan He
2020-03-09 9:08 ` David Hildenbrand
2020-03-09 13:41 ` Baoquan He
2020-03-07 8:42 ` [PATCH v3 7/7] mm/sparse.c: Use __get_free_pages() instead in populate_section_memmap() Baoquan He
2020-03-10 14:56 ` Michal Hocko
2020-03-10 14:59 ` David Hildenbrand
2020-03-11 9:31 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311042052.GI27711@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=osalvador@suse.de \
--cc=richardw.yang@linux.intel.com \
--cc=rppt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).