[linux-next:master 7020/7467] drivers/mtd/mtdpart.c:318:5: sparse: sparse: symbol '__del_mtd_partitions' was not declared. Should it be static?

[linux-next:master 7020/7467] drivers/mtd/mtdpart.c:318:5: sparse: sparse: symbol '__del_mtd_partitions' was not declared. Should it be static?

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   134546626849cd6852d6d4bf8f207b5fbc54261b
commit: 57b8b2d03dbd17e5d3c03489d7cd7985ea8286a0 [7020/7467] mtd: implement proper partition handling
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-174-g094d5a94-dirty
        git checkout 57b8b2d03dbd17e5d3c03489d7cd7985ea8286a0
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> drivers/mtd/mtdpart.c:318:5: sparse: sparse: symbol '__del_mtd_partitions' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[RFC PATCH linux-next] mtd: __del_mtd_partitions() can be static

[kbuild test robot]

Fixes: 57b8b2d03dbd ("mtd: implement proper partition handling")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 mtdpart.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c
index 93ef8fdf1634b0..3f6025684f5890 100644
--- a/drivers/mtd/mtdpart.c
+++ b/drivers/mtd/mtdpart.c
@@ -315,7 +315,7 @@ static int __mtd_del_partition(struct mtd_info *mtd)
  * This function unregisters and destroy all slave MTD objects which are
  * attached to the given MTD object, recursively.
  */
-int __del_mtd_partitions(struct mtd_info *mtd)
+static int __del_mtd_partitions(struct mtd_info *mtd)
 {
 	struct mtd_info *child, *next;
 	LIST_HEAD(tmp_list);

Re: [linux-next:master 7020/7467] drivers/mtd/mtdpart.c:318:5: sparse: sparse: symbol '__del_mtd_partitions' was not declared. Should it be static?

[Andrew Morton]

On Wed, 11 Mar 2020 08:12:05 +0800 kbuild test robot <lkp@intel.com> wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   134546626849cd6852d6d4bf8f207b5fbc54261b
> commit: 57b8b2d03dbd17e5d3c03489d7cd7985ea8286a0 [7020/7467] mtd: implement proper partition handling
> reproduce:
>         # apt-get install sparse
>         # sparse version: v0.6.1-174-g094d5a94-dirty
>         git checkout 57b8b2d03dbd17e5d3c03489d7cd7985ea8286a0
>         make ARCH=x86_64 allmodconfig
>         make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> 
> sparse warnings: (new ones prefixed by >>)
> 
> >> drivers/mtd/mtdpart.c:318:5: sparse: sparse: symbol '__del_mtd_partitions' was not declared. Should it be static?
> 
> Please review and possibly fold the followup patch.
> 

Something has gone screwy lately.  This is not a -mm patch and I've
never seen it before!

Let's Cc the author, Miquel.

Re: [linux-next:master 7020/7467] drivers/mtd/mtdpart.c:318:5: sparse: sparse: symbol '__del_mtd_partitions' was not declared. Should it be static?

[Miquel Raynal]

Hello,

Andrew Morton <akpm@linux-foundation.org> wrote on Tue, 10 Mar 2020
18:33:08 -0700:

> On Wed, 11 Mar 2020 08:12:05 +0800 kbuild test robot <lkp@intel.com> wrote:
> 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head:   134546626849cd6852d6d4bf8f207b5fbc54261b
> > commit: 57b8b2d03dbd17e5d3c03489d7cd7985ea8286a0 [7020/7467] mtd: implement proper partition handling
> > reproduce:
> >         # apt-get install sparse
> >         # sparse version: v0.6.1-174-g094d5a94-dirty
> >         git checkout 57b8b2d03dbd17e5d3c03489d7cd7985ea8286a0
> >         make ARCH=x86_64 allmodconfig
> >         make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
> > 
> > If you fix the issue, kindly add following tag
> > Reported-by: kbuild test robot <lkp@intel.com>
> > 
> > 
> > sparse warnings: (new ones prefixed by >>)
> >   
> > >> drivers/mtd/mtdpart.c:318:5: sparse: sparse: symbol '__del_mtd_partitions' was not declared. Should it be static?  
> > 
> > Please review and possibly fold the followup patch.
> >   
> 
> Something has gone screwy lately.  This is not a -mm patch and I've
> never seen it before!
> 
> Let's Cc the author, Miquel.

This is indeed a patch that I applied recently on mtd/next, pulled in
linux-next. I have no idea why you did receive this bug report though
:)

That was actually the first time working with sparse for me, it took me
some time (and a lot of build time) to figure out that I had to use the
exact same sparse version has you in order to get the warning (I was
using Ubuntu's stable 0.6.0-3 version).

However I got it working and fixed this trivial but real issue in my
code.


Thanks,
Miquèl