From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88FE9C18E5A for ; Wed, 11 Mar 2020 13:57:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 510A121D56 for ; Wed, 11 Mar 2020 13:57:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 510A121D56 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EE93B6B0007; Wed, 11 Mar 2020 09:57:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E73996B0008; Wed, 11 Mar 2020 09:57:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D61746B000A; Wed, 11 Mar 2020 09:57:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0222.hostedemail.com [216.40.44.222]) by kanga.kvack.org (Postfix) with ESMTP id B936B6B0007 for ; Wed, 11 Mar 2020 09:57:33 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 91FE66115 for ; Wed, 11 Mar 2020 13:57:33 +0000 (UTC) X-FDA: 76583233986.30.drug91_7b3477934d3a X-HE-Tag: drug91_7b3477934d3a X-Filterd-Recvd-Size: 3060 Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Mar 2020 13:57:32 +0000 (UTC) Received: from xps13 (lfbn-tou-1-1473-158.w90-89.abo.wanadoo.fr [90.89.41.158]) (Authenticated sender: miquel.raynal@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 85AA8100006; Wed, 11 Mar 2020 13:57:30 +0000 (UTC) Date: Wed, 11 Mar 2020 14:57:29 +0100 From: Miquel Raynal To: Andrew Morton Cc: kbuild test robot , kbuild-all@lists.01.org, Linux Memory Management List Subject: Re: [linux-next:master 7020/7467] drivers/mtd/mtdpart.c:318:5: sparse: sparse: symbol '__del_mtd_partitions' was not declared. Should it be static? Message-ID: <20200311145729.4bf95be4@xps13> In-Reply-To: <20200310183308.fc664e38002f1ff596b1ddb1@linux-foundation.org> References: <202003110814.gCNrCX7Y%lkp@intel.com> <20200310183308.fc664e38002f1ff596b1ddb1@linux-foundation.org> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello, Andrew Morton wrote on Tue, 10 Mar 2020 18:33:08 -0700: > On Wed, 11 Mar 2020 08:12:05 +0800 kbuild test robot wrot= e: >=20 > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next= .git master > > head: 134546626849cd6852d6d4bf8f207b5fbc54261b > > commit: 57b8b2d03dbd17e5d3c03489d7cd7985ea8286a0 [7020/7467] mtd: imple= ment proper partition handling > > reproduce: > > # apt-get install sparse > > # sparse version: v0.6.1-174-g094d5a94-dirty > > git checkout 57b8b2d03dbd17e5d3c03489d7cd7985ea8286a0 > > make ARCH=3Dx86_64 allmodconfig > > make C=3D1 CF=3D'-fdiagnostic-prefix -D__CHECK_ENDIAN__' > >=20 > > If you fix the issue, kindly add following tag > > Reported-by: kbuild test robot > >=20 > >=20 > > sparse warnings: (new ones prefixed by >>) > > =20 > > >> drivers/mtd/mtdpart.c:318:5: sparse: sparse: symbol '__del_mtd_parti= tions' was not declared. Should it be static? =20 > >=20 > > Please review and possibly fold the followup patch. > > =20 >=20 > Something has gone screwy lately. This is not a -mm patch and I've > never seen it before! >=20 > Let's Cc the author, Miquel. This is indeed a patch that I applied recently on mtd/next, pulled in linux-next. I have no idea why you did receive this bug report though :) That was actually the first time working with sparse for me, it took me some time (and a lot of build time) to figure out that I had to use the exact same sparse version has you in order to get the warning (I was using Ubuntu's stable 0.6.0-3 version). However I got it working and fixed this trivial but real issue in my code. Thanks, Miqu=C3=A8l