From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89B7EC0044D for ; Mon, 16 Mar 2020 08:54:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4849020663 for ; Mon, 16 Mar 2020 08:54:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ogCPnHc8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4849020663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C1CFE6B0003; Mon, 16 Mar 2020 04:54:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BCC5E6B0005; Mon, 16 Mar 2020 04:54:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A942B6B0007; Mon, 16 Mar 2020 04:54:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0202.hostedemail.com [216.40.44.202]) by kanga.kvack.org (Postfix) with ESMTP id 8E4906B0003 for ; Mon, 16 Mar 2020 04:54:19 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 591F7824556B for ; Mon, 16 Mar 2020 08:54:19 +0000 (UTC) X-FDA: 76600613838.13.spade33_7d03de3542600 X-HE-Tag: spade33_7d03de3542600 X-Filterd-Recvd-Size: 2359 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Mon, 16 Mar 2020 08:54:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YMlc//ixq3XAz7bfU0iD/j/ZWWxHdyHVImyXy4+oj0w=; b=ogCPnHc8p7k5lQZBIXRcSs4Vtj hSpr0xLcM6zm2Q96u233tsR/wyxtUEzekj5Cc5cl6ro8AbRkl7dwiuVs2cv99SY2DERFiokTi7Ql6 WoDNj23VZ3e9297ZfSxiKEcfRGPdeVxoEzd4uDWjDf2gQdLAtLU5EvSAwTf+ucjjwLvDRV3vLkVoD pDnK4L/kNyqnmK+yL8xW6e1VPius7Qi3ze3rWSPCuIOcefGMbjJ/ctX4e+hlng47ZPNSqUXCzMaIe XWYVrMgAZA/+lKQGCI8a3rIOU5Dyr9acWqr8LgvRjJDMRBAo6/WN04LT5217b+J1MtIMA+T1ql2xw 4LMc1Ehg==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jDlVl-0001ty-Hu; Mon, 16 Mar 2020 08:54:13 +0000 Date: Mon, 16 Mar 2020 01:54:13 -0700 From: Christoph Hellwig To: Pingfan Liu Cc: linux-mm@kvack.org, Ira Weiny , Andrew Morton , Mike Rapoport , Dan Williams , Matthew Wilcox , John Hubbard , "Aneesh Kumar K.V" , Christoph Hellwig , Shuah Khan , linux-kernel@vger.kernel.org Subject: Re: [PATCHv6 1/3] mm/gup: rename nr as nr_pinned in get_user_pages_fast() Message-ID: <20200316085413.GA1831@infradead.org> References: <1584333244-10480-1-git-send-email-kernelfans@gmail.com> <1584333244-10480-2-git-send-email-kernelfans@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1584333244-10480-2-git-send-email-kernelfans@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 16, 2020 at 12:34:02PM +0800, Pingfan Liu wrote: > To better reflect the held state of pages and make code self-explaining, > rename nr as nr_pinned. Looks good, Reviewed-by: Christoph Hellwig