From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2B33C0044D for ; Mon, 16 Mar 2020 16:21:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AD32E20658 for ; Mon, 16 Mar 2020 16:21:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="BIdRz1p8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD32E20658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5C2846B000A; Mon, 16 Mar 2020 12:21:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 573256B000C; Mon, 16 Mar 2020 12:21:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 488FF6B000D; Mon, 16 Mar 2020 12:21:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0148.hostedemail.com [216.40.44.148]) by kanga.kvack.org (Postfix) with ESMTP id 301A96B000A for ; Mon, 16 Mar 2020 12:21:31 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 920A6EFA6 for ; Mon, 16 Mar 2020 16:21:30 +0000 (UTC) X-FDA: 76601740740.21.hate34_64703f82dec5c X-HE-Tag: hate34_64703f82dec5c X-Filterd-Recvd-Size: 4296 Received: from mail-qv1-f66.google.com (mail-qv1-f66.google.com [209.85.219.66]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Mon, 16 Mar 2020 16:21:30 +0000 (UTC) Received: by mail-qv1-f66.google.com with SMTP id a10so9147107qvq.8 for ; Mon, 16 Mar 2020 09:21:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9klmvsCDbXb5UYRZlQllkDdUD0lGfzdSvUkSWWRacQo=; b=BIdRz1p8gE7zQuk9C9oV2HUNArw5x43uMFazoWlkrlXCvsSeUsivCaSdXGEbbFTYjy nVHA9sJZ7eETinHItrBU4wkyITu/QJh0Hk7+Zg4PL5xep7s0jQVsZRD4ZWsnd5ipJD9v sapWytPkQe7cpFo/rwKJ+7zg+T6UXo8doO5npkHb/HZMK7ZCgLKDLWa4AJ94FFjM+cx2 RbztSybf9OHQoAu+GbPdpNc0d7bgoYECl7ZfwdX1uisQIF3JKgd5exWrQzIH8FwYxLvK 7LoFUX9bkY1j/teBAy37KVGtZTsTa3q/X6cjYnD7zY79l6KnHy70ahkT8I/rVjcAcc1z pwiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9klmvsCDbXb5UYRZlQllkDdUD0lGfzdSvUkSWWRacQo=; b=PlKaZ1Of+qYYx4ka4NF761WVHc6NjCvlHA8XVwVNY3gpu9pNLWzUQpVn7J4NcrWeJa j78WQrXyLY+cX0abVgXLSObhjYkPPija3PPAkc46gHDINEFd3QWgLV36wUOeUPYQoEsY R/7LVOtix4oRFEQrIDm6VLUsB1k6izdszq1JEjtpbYOlSzeYHL/K3WKCrCHZloa3khr4 4cRIg7Re0y0Px+YNlG5yZtjYEV46FUaB/rJwuuCMpSkHkvRHkC2qkxBZpxL4srgmIJvN t8iGc5Jli1d7t/EfG/tRDZtRzF0HedbxEstwtshcV0JPcgVTPUts2S8C1Jd99iOlBODZ +ROA== X-Gm-Message-State: ANhLgQ1I9oQKKAAsaGPQi7aEYHlHvPzEUE+J/gLec1DAx37zDW2EZsj2 Xh0hW2U+MbL3NBdxYoTzElZlHQ== X-Google-Smtp-Source: ADFU+vt/P7ZURa36l2KZQ/dCMCuB9sP/P1NIhNUnoYuUrITCwV6n9U2JPEM6tTD4GaQXZXYkNktwxw== X-Received: by 2002:ad4:57a8:: with SMTP id g8mr584591qvx.78.1584375689499; Mon, 16 Mar 2020 09:21:29 -0700 (PDT) Received: from localhost (70.44.39.90.res-cmts.bus.ptd.net. [70.44.39.90]) by smtp.gmail.com with ESMTPSA id z19sm85599qts.86.2020.03.16.09.21.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2020 09:21:28 -0700 (PDT) Date: Mon, 16 Mar 2020 12:21:28 -0400 From: Johannes Weiner To: Chris Down Cc: Andrew Morton , Tejun Heo , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 2/2] mm, memcg: Throttle allocators based on ancestral memory.high Message-ID: <20200316162128.GF67986@cmpxchg.org> References: <80780887060514967d414b3cd91f9a316a16ab98.1584036142.git.chris@chrisdown.name> <8cd132f84bd7e16cdb8fde3378cdbf05ba00d387.1584036142.git.chris@chrisdown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8cd132f84bd7e16cdb8fde3378cdbf05ba00d387.1584036142.git.chris@chrisdown.name> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 12, 2020 at 06:03:04PM +0000, Chris Down wrote: > Prior to this commit, we only directly check the affected cgroup's > memory.high against its usage. However, it's possible that we are being > reclaimed as a result of hitting an ancestor memory.high and should be > penalised based on that, instead. > > This patch changes memory.high overage throttling to use the largest > overage in its ancestors when considering how many penalty jiffies to > charge. This makes sure that we penalise poorly behaving cgroups in the > same way regardless of at what level of the hierarchy memory.high was > breached. > > Fixes: 0e4b01df8659 ("mm, memcg: throttle allocators when failing reclaim over memory.high") > Reported-by: Johannes Weiner > Signed-off-by: Chris Down > Cc: Andrew Morton > Cc: Tejun Heo > Cc: linux-mm@kvack.org > Cc: cgroups@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: kernel-team@fb.com > Cc: stable@vger.kernel.org # 5.4.x Acked-by: Johannes Weiner