From: Bharata B Rao <bharata@linux.ibm.com>
To: linux-mm@kvack.org
Cc: Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@ozlabs.org, aneesh.kumar@linux.ibm.com,
srikar@linux.vnet.ibm.com
Subject: Re: Slub: Increased mem consumption on cpu,mem-less node powerpc guest
Date: Tue, 17 Mar 2020 17:23:39 +0530 [thread overview]
Message-ID: <20200317115339.GA26049@in.ibm.com> (raw)
In-Reply-To: <20200317092624.GB22538@in.ibm.com>
On Tue, Mar 17, 2020 at 02:56:28PM +0530, Bharata B Rao wrote:
> Case 1: 2 node NUMA, node0 empty
> ================================
> # numactl -H
> available: 2 nodes (0-1)
> node 0 cpus:
> node 0 size: 0 MB
> node 0 free: 0 MB
> node 1 cpus: 0 1 2 3 4 5 6 7
> node 1 size: 16294 MB
> node 1 free: 15453 MB
> node distances:
> node 0 1
> 0: 10 40
> 1: 40 10
>
> diff --git a/mm/slub.c b/mm/slub.c
> index 17dc00e33115..888e4d245444 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -1971,10 +1971,8 @@ static void *get_partial(struct kmem_cache *s, gfp_t flags, int node,
> void *object;
> int searchnode = node;
>
> - if (node == NUMA_NO_NODE)
> + if (node == NUMA_NO_NODE || !node_present_pages(node))
> searchnode = numa_mem_id();
> - else if (!node_present_pages(node))
> - searchnode = node_to_mem_node(node);
For the above topology, I see this:
node_to_mem_node(1) = 1
node_to_mem_node(0) = 0
node_to_mem_node(NUMA_NO_NODE) = 0
Looks like the last two cases (returning memory-less node 0) is the
problem here?
Regards,
Bharata.
next prev parent reply other threads:[~2020-03-17 11:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 9:26 Slub: Increased mem consumption on cpu,mem-less node powerpc guest Bharata B Rao
2020-03-17 11:53 ` Bharata B Rao [this message]
2020-03-17 15:56 ` Vlastimil Babka
2020-03-17 16:25 ` Srikar Dronamraju
2020-03-17 16:45 ` Vlastimil Babka
2020-03-18 3:20 ` Srikar Dronamraju
2020-03-18 4:46 ` Bharata B Rao
2020-03-18 10:18 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317115339.GA26049@in.ibm.com \
--to=bharata@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).