From: Michal Hocko <mhocko@kernel.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Yang Shi <yang.shi@linux.alibaba.com>,
shakeelb@google.com, vbabka@suse.cz, akpm@linux-foundation.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [v3 PATCH 1/2] mm: swap: make page_evictable() inline
Date: Wed, 18 Mar 2020 09:15:51 +0100 [thread overview]
Message-ID: <20200318081551.GC21362@dhcp22.suse.cz> (raw)
In-Reply-To: <20200317190411.GD22433@bombadil.infradead.org>
On Tue 17-03-20 12:04:11, Matthew Wilcox wrote:
[...]
> In fact, since it's only called by those three files, perhaps it should
> be in mm/internal.h? I don't see it becoming a terribly popular function
> to call outside of the core mm code.
Agreed. I do not see any strong reasons why anything outside of the core
MM should care about evictability. So if moving it to internal.h is
reasonable without too much churn then I would that way.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2020-03-18 8:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 17:42 [v3 PATCH 1/2] mm: swap: make page_evictable() inline Yang Shi
2020-03-17 17:42 ` [v3 PATCH 2/2] mm: swap: use smp_mb__after_atomic() to order LRU bit set Yang Shi
2020-03-17 19:04 ` [v3 PATCH 1/2] mm: swap: make page_evictable() inline Matthew Wilcox
2020-03-17 19:28 ` Yang Shi
2020-03-18 8:15 ` Michal Hocko [this message]
2020-03-17 19:21 ` Matthew Wilcox
2020-03-17 19:29 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318081551.GC21362@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shakeelb@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).