From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7065C4332B for ; Thu, 19 Mar 2020 18:50:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7A92B2070A for ; Thu, 19 Mar 2020 18:50:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="O+T+k7Qc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A92B2070A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1370C6B0003; Thu, 19 Mar 2020 14:50:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E82F6B0005; Thu, 19 Mar 2020 14:50:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F3F246B0007; Thu, 19 Mar 2020 14:50:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0112.hostedemail.com [216.40.44.112]) by kanga.kvack.org (Postfix) with ESMTP id DA26B6B0003 for ; Thu, 19 Mar 2020 14:50:18 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 8132745D8 for ; Thu, 19 Mar 2020 18:50:18 +0000 (UTC) X-FDA: 76613002116.08.sound76_77145aa5a3114 X-HE-Tag: sound76_77145aa5a3114 X-Filterd-Recvd-Size: 4357 Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Thu, 19 Mar 2020 18:50:18 +0000 (UTC) Received: by mail-qt1-f194.google.com with SMTP id i9so2157754qtw.7 for ; Thu, 19 Mar 2020 11:50:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+iQmmyqtxCtarJ4YRBKb0yWGqnthI8hUUC43IFJE2lc=; b=O+T+k7QcGsKIEHBjgipyL31XPaNddanzbawgGU863gdvDPNIX7LYi3WVs/mOCkQatM kp3xPR0l9A+vuyX750Q+3/7jJVu4icOVMoEC/ohdQ5GVvA3ARolXe4ZZVnWtakCYOGal boy4qnC1A6on3cpFaP6DgucabbLC6sHg+E7Qo7m9ag0aas++wv/SLWln/6E5qDazux78 cdzi7JujpLBWCBJqNIB5d7eOJ93n7akLN+Ctr6uYuANCJPwzugp1TU5/0Zr3jU0FqhYQ 5GF51y82KW0QITwSWN2Y1KbEajR7yA6aP5DQTQFmk2rLd5pBravF6IH6lq8HScNN4zv7 xo1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+iQmmyqtxCtarJ4YRBKb0yWGqnthI8hUUC43IFJE2lc=; b=ZJEy08HmwonrCUaSdJO1sNRfAgDyA1ayYE0JikQgmWr4UFOUOTOJilzdi7oSTlSra/ 7MIt91aqDW2iC6nCWCKoTXucC0jekIk8b5GoKYoJev106vsdQvhnVUMUExA928bptxFw u8IkaMwva8fa3v+MRDGvZrlTjveubRFYYrhuOlvs+cJasmzvdK0D3+0ywwRrDlo8wwmY XOzsWXUcwo6IeN4JC57DQ87+8a7jiCOSH9WNexLFyJgijjX2LTNe5DEeuQ3+v2mU83q3 WvXwVJmAjIYBxEWA5jOthK0t7aWMl2lZmEO0i30ETmximWhEga9rhBSoMPdn2CRbfXhQ 8Oeg== X-Gm-Message-State: ANhLgQ2nUL2tZZuxvUzKWrvVKTxKwH6CBp/vYQih0kbrheKwAn1smNjv LydW4TDLVGBaVa+exyEzA1MBpg== X-Google-Smtp-Source: ADFU+vvq32in5Qjs8YAHdFEpYAPgT41J1WfLa2uHLd4XxlB1EmISPkcd3J2y54DRcA2TER5nFwTi4A== X-Received: by 2002:ac8:4548:: with SMTP id z8mr4613857qtn.188.1584643817615; Thu, 19 Mar 2020 11:50:17 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id 82sm2177475qkd.62.2020.03.19.11.50.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Mar 2020 11:50:16 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jF0FD-0004NT-Vw; Thu, 19 Mar 2020 15:50:15 -0300 Date: Thu, 19 Mar 2020 15:50:15 -0300 From: Jason Gunthorpe To: Christoph Hellwig Cc: Dan Williams , Bharata B Rao , Christian =?utf-8?B?S8O2bmln?= , Ben Skeggs , Jerome Glisse , kvm-ppc@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-mm@kvack.org Subject: Re: ensure device private pages have an owner v2 Message-ID: <20200319185015.GM20941@ziepe.ca> References: <20200316193216.920734-1-hch@lst.de> <20200319002849.GG20941@ziepe.ca> <20200319071633.GA32522@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200319071633.GA32522@lst.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000425, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 19, 2020 at 08:16:33AM +0100, Christoph Hellwig wrote: > On Wed, Mar 18, 2020 at 09:28:49PM -0300, Jason Gunthorpe wrote: > > > Changes since v1: > > > - split out the pgmap->owner addition into a separate patch > > > - check pgmap->owner is set for device private mappings > > > - rename the dev_private_owner field in struct migrate_vma to src_owner > > > - refuse to migrate private pages if src_owner is not set > > > - keep the non-fault device private handling in hmm_range_fault > > > > I'm happy enough to take this, did you have plans for a v3? > > I think the only open question is if merging 3 and 4 might make sense. > It's up to you if you want it resent that way or not. Okay, I kept it as is and elaborated the commit messages a bit based on the discussion It doesn't seem like the changes outside hmm are significant enough to need more acks Thanks, Jason