From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 847A8C4332B for ; Fri, 20 Mar 2020 17:37:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 26B2920767 for ; Fri, 20 Mar 2020 17:37:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="avAm79Pa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 26B2920767 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9B7916B0008; Fri, 20 Mar 2020 13:37:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9682B6B000A; Fri, 20 Mar 2020 13:37:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 880826B000C; Fri, 20 Mar 2020 13:37:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0229.hostedemail.com [216.40.44.229]) by kanga.kvack.org (Postfix) with ESMTP id 6E5386B0008 for ; Fri, 20 Mar 2020 13:37:38 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id F238162C4 for ; Fri, 20 Mar 2020 17:37:37 +0000 (UTC) X-FDA: 76616447754.06.judge50_7cca569668a19 X-HE-Tag: judge50_7cca569668a19 X-Filterd-Recvd-Size: 2680 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Fri, 20 Mar 2020 17:37:37 +0000 (UTC) Received: from sol.localdomain (c-107-3-166-239.hsd1.ca.comcast.net [107.3.166.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4B72C20722; Fri, 20 Mar 2020 17:37:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584725856; bh=G2+3MpD3WslFGLdp5NjeBbtVtx2oUkFUbLAe3FrGwo4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=avAm79PauNq7Mi8lepE1M+q8L6UcKnW/aDKz8d+iWcwGM0xSpN0CPodVkw5n7hjxI bmniaSQH/oDhJBhhL3LaO1e96w9j3KKiHwDmuCEMBhf2iB3BNRVYn0F6PNaJNIKpU0 QA85GNq47i8AcHSpCY4OouI56lflivWj/ICnBfM4= Date: Fri, 20 Mar 2020 10:37:34 -0700 From: Eric Biggers To: Matthew Wilcox Cc: Andrew Morton , linux-xfs@vger.kernel.org, William Kucharski , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-mm@kvack.org, ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-btrfs@vger.kernel.org Subject: Re: [PATCH v9 20/25] ext4: Convert from readpages to readahead Message-ID: <20200320173734.GD851@sol.localdomain> References: <20200320142231.2402-1-willy@infradead.org> <20200320142231.2402-21-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200320142231.2402-21-willy@infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 20, 2020 at 07:22:26AM -0700, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > Use the new readahead operation in ext4 > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: William Kucharski > --- > fs/ext4/ext4.h | 3 +-- > fs/ext4/inode.c | 21 +++++++++------------ > fs/ext4/readpage.c | 22 ++++++++-------------- > 3 files changed, 18 insertions(+), 28 deletions(-) > Reviewed-by: Eric Biggers > + if (rac) { > + page = readahead_page(rac); > prefetchw(&page->flags); > - list_del(&page->lru); > - if (add_to_page_cache_lru(page, mapping, page->index, > - readahead_gfp_mask(mapping))) > - goto next_page; > } Maybe the prefetchw(&page->flags) should be included in readahead_page()? Most of the callers do it. - Eric