From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE4B8C4332B for ; Sat, 21 Mar 2020 00:43:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5B02E20732 for ; Sat, 21 Mar 2020 00:43:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="aOsZlCeA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B02E20732 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E6D956B0003; Fri, 20 Mar 2020 20:43:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E1E1F6B0005; Fri, 20 Mar 2020 20:43:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D34B66B0007; Fri, 20 Mar 2020 20:43:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0132.hostedemail.com [216.40.44.132]) by kanga.kvack.org (Postfix) with ESMTP id B8F916B0003 for ; Fri, 20 Mar 2020 20:43:03 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 7C65A5820 for ; Sat, 21 Mar 2020 00:43:03 +0000 (UTC) X-FDA: 76617519846.06.fly34_37c53bbbbc213 X-HE-Tag: fly34_37c53bbbbc213 X-Filterd-Recvd-Size: 3078 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Sat, 21 Mar 2020 00:43:03 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0AC9A2070A; Sat, 21 Mar 2020 00:43:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584751382; bh=RMdVaaFoWYmJQObfafJvTOBmbJaXgAiO0R5VPh72khM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aOsZlCeAu65kAEmKdsY/rSeOmtv5d+prwQas0jsyj3cb7nNI6Bts4Iuil9+ngCkcV kOlM5EP4fUCDI0bJA7AyyTM5+KfwkTWLRtuR9F2xsjpxJyzERMLBs7jMLxX1qMjE5C gi+loVMV2QWjz8neluu5CMFMGq12tTUg0qPDowxw= Date: Fri, 20 Mar 2020 17:43:01 -0700 From: Andrew Morton To: John Hubbard Cc: Vlastimil Babka , Claudio Imbrenda , Linux MM , Randy Dunlap Subject: Re: mm/gup: track FOLL_PIN squash-candidate patches are not squashed (yet?) Message-Id: <20200320174301.e832b7f477d5069d7ae6651f@linux-foundation.org> In-Reply-To: <3be1130a-eca8-e9f8-a3c4-6afb492f639e@nvidia.com> References: <5cb7b72e-39e3-5d34-eec0-610d7250ebc8@nvidia.com> <887429b4-7b36-9f51-5bbd-0ae47c1156f9@suse.cz> <3be1130a-eca8-e9f8-a3c4-6afb492f639e@nvidia.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 20 Mar 2020 10:49:53 -0700 John Hubbard wrote: > On 3/20/20 10:22 AM, Vlastimil Babka wrote: > > On 3/19/20 7:04 PM, John Hubbard wrote: > >> Hi Andrew, > >> > >> I see the following commits in linux-next. I'm wondering if all is well, because > >> I understood that these were all going to be squashed into the first commit > >> (3d37f4aceb31), yes? > >> > >> (This is the first time I've participated in the "squash" aspect of linux-mm workflow, > >> as you can probably tell.) > > > > AFAIK Andrew (or his scripts) does the squashing only at the last moment before > > sending patches to Linus. The mmotm import to -next could do it as well I guess, > > but do you expect a benefit e.g. for bisects? > > > Squashing would only help very slightly in this case, for bisects. That's because > 08baf249e844 fixes a build warning. And I don't think it's necessary to do it any > sooner than usual. I just thought it was accidentally overlooked, because I didn't > know that the squashing is done at the last minute. > > All is well, then. > Yes, I like to have the whole history there for my final review before sending upstream. The bisection issue could be a hassle, but the various buildbots seem to have figured out that if foo.patch is immediately followed by foo-fix.patch then do the obvious thing.