From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B2CBC4332B for ; Sat, 21 Mar 2020 21:55:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A117F206F9 for ; Sat, 21 Mar 2020 21:55:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="QXg0ZNos" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A117F206F9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E5B826B0003; Sat, 21 Mar 2020 17:55:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E0C4E6B0005; Sat, 21 Mar 2020 17:55:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D21356B0007; Sat, 21 Mar 2020 17:55:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0197.hostedemail.com [216.40.44.197]) by kanga.kvack.org (Postfix) with ESMTP id BBA7F6B0003 for ; Sat, 21 Mar 2020 17:55:08 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 2C7453D13 for ; Sat, 21 Mar 2020 21:55:08 +0000 (UTC) X-FDA: 76620725496.23.truck99_66fe14b5e9f1f X-HE-Tag: truck99_66fe14b5e9f1f X-Filterd-Recvd-Size: 5466 Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Sat, 21 Mar 2020 21:55:07 +0000 (UTC) Received: by mail-qt1-f193.google.com with SMTP id t9so4461640qto.9 for ; Sat, 21 Mar 2020 14:55:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=CmG5rzS1VTJ/Gtn12pCRpchEX5vnXgpD/KCibm4JPWQ=; b=QXg0ZNos1/J6d1p0hrWrf/BNlal1wCBZAa4x4E5PIa8BDk8jeEY0GblJxuI4oFmQT/ NEFlXQButDNW6Sy8rWCrWEBqBlDVBmAq88Oe1Os3P4X8W9sHapEqJpHApMkG11UZBuGc b5c/Qy70trzWRO+uM2yXpARmvj2AlCEyD9eXx6cUiReoJKwIlahoUDHxSd5sVQiu5kWj lVf+vPf/2xCoROinRkXtRalmj0jS8jiUcIn3LB1fR12o0e5z5NIXXdxa+F/1bZGwg4Ye oRdVryO7nhpz8T7n1j5VtSpK27aodaU2eCFv/2TbkyAf3cxW7xJHjI725K50b1LhbcfF k1dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=CmG5rzS1VTJ/Gtn12pCRpchEX5vnXgpD/KCibm4JPWQ=; b=MpwL0v/Uaa/lKgfUUMaXhZ3WTn6Oi0OeuDnGOu9C1L3R88Vo0JsjhSVuIu3lYbdQJV zG3tzh+7MX7i4Fi/vSr1AKgT7+D1xmfGTZqggyj9XQASkTAP1fcTPj+qXxJWNVAokjKi xHtTgYZEN2TUYMnIp9fpmyIsCDdO/2kQiZGbzhlmfGyDRMj51N8B7GoZWf8A6RbzRYcV fkkt5Aoiy0B5QlT5sbfbMOOLeQmEi6SXOYkyT+mYhvD2cL54Zvmb3kD6pOA8viWVme0/ WfEMDp1tnr7i/JZ4IHNrnlPz2v2avno0iayj5PnHp9iM8f9PEzSRVdxQHuRfw52mH08V IRyA== X-Gm-Message-State: ANhLgQ0fG1RMkGWj0qXwdkYx7p5sLwqk36FN1RvXAq6eTnVQankmmGru m+G2ZkG8Mnw1TBh009wIp+hCtQ== X-Google-Smtp-Source: ADFU+vv/Zh+hyXfiOpNLqojKXOQJzZZr2FWGVPNjpoK48D71dPO0p426cqJtcyzUzhZk5VY+Qlxcbw== X-Received: by 2002:ac8:7499:: with SMTP id v25mr15399957qtq.237.1584827707243; Sat, 21 Mar 2020 14:55:07 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id p191sm7884005qke.6.2020.03.21.14.55.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 21 Mar 2020 14:55:06 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jFm5B-0002J4-FR; Sat, 21 Mar 2020 18:55:05 -0300 Date: Sat, 21 Mar 2020 18:55:05 -0300 From: Jason Gunthorpe To: Ralph Campbell Cc: Leon Romanovsky , Jerome Glisse , John Hubbard , Christoph Hellwig , Andrew Morton , Shuah Khan , linux-rdma@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v8 0/3] mm/hmm/test: add self tests for HMM Message-ID: <20200321215505.GW20941@ziepe.ca> References: <20200321003108.22941-1-rcampbell@nvidia.com> <20200321090047.GM514123@unreal> <396f0c30-4a49-6a18-ff02-a73ee1a09883@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <396f0c30-4a49-6a18-ff02-a73ee1a09883@nvidia.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Mar 21, 2020 at 10:27:46AM -0700, Ralph Campbell wrote: > > On 3/21/20 2:00 AM, Leon Romanovsky wrote: > > On Fri, Mar 20, 2020 at 05:31:05PM -0700, Ralph Campbell wrote: > > > This series adds basic self tests for HMM and are intended for Jason > > > Gunthorpe's rdma tree which has a number of HMM patches applied. > > > > > > Changes v7 -> v8: > > > Rebased to Jason's rdma/hmm tree, plus Jason's 6 patch series > > > "Small hmm_range_fault() cleanups". > > > Applied a number of changes from Jason's comments. > > > > > > Changes v6 -> v7: > > > Rebased to linux-5.6.0-rc6 > > > Reverted back to just using mmu_interval_notifier_insert() and making > > > this series only introduce HMM self tests. > > > > > > Changes v5 -> v6: > > > Rebased to linux-5.5.0-rc6 > > > Refactored mmu interval notifier patches > > > Converted nouveau to use the new mmu interval notifier API > > > > > > Changes v4 -> v5: > > > Added mmu interval notifier insert/remove/update callable from the > > > invalidate() callback > > > Updated HMM tests to use the new core interval notifier API > > > > > > Changes v1 -> v4: > > > https://lore.kernel.org/linux-mm/20191104222141.5173-1-rcampbell@nvidia.com > > > > > > Ralph Campbell (3): > > > mm/hmm/test: add selftest driver for HMM > > > mm/hmm/test: add selftests for HMM > > > MAINTAINERS: add HMM selftests > > > > > > MAINTAINERS | 3 + > > > include/uapi/linux/test_hmm.h | 59 ++ > > > > Isn't UAPI folder supposed to be for user-visible interfaces that follow > > the rule of non-breaking user space and not for selftests? > > > > Thanks > > > > Most of the other kernel module tests seem to invoke the test as part of the > module load/init. I'm open to moving it if there is a more appropriate location. Is it even possible to create a user mm_struct and put crazy things in it soley from a kernel module? Jason