From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FA8DC3F2CD for ; Mon, 23 Mar 2020 03:53:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DF96020732 for ; Mon, 23 Mar 2020 03:53:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="wuviUgzO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF96020732 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7911A6B0005; Sun, 22 Mar 2020 23:53:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71B546B0006; Sun, 22 Mar 2020 23:53:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E2766B0007; Sun, 22 Mar 2020 23:53:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0128.hostedemail.com [216.40.44.128]) by kanga.kvack.org (Postfix) with ESMTP id 423D16B0005 for ; Sun, 22 Mar 2020 23:53:48 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 6A528180AD811 for ; Mon, 23 Mar 2020 03:53:48 +0000 (UTC) X-FDA: 76625258136.03.rifle23_5b651fe304e1d X-HE-Tag: rifle23_5b651fe304e1d X-Filterd-Recvd-Size: 3944 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Mon, 23 Mar 2020 03:53:47 +0000 (UTC) Received: from localhost (unknown [104.132.1.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8C9F32070A; Mon, 23 Mar 2020 03:53:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584935626; bh=JZ9FfTQC5hyfKYp2Fe1Ul7ymAHFUkesL0z+aqbPk+0k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wuviUgzOZ9I/ZxR0Qe6UoYpguDtb5vojJwuqb15B1ybVXKf98oY0z1TX6lmXfukQO GrFi7ly/HkosHLTiJjGp0HGiSSzpm7VLLduKNUyObGN0l5d1IvMgJGRKB9ZIFBs6l4 K/+ERiSC/J11ea857uMzNfIHBmBogvwEAROQ2s+8= Date: Sun, 22 Mar 2020 20:53:46 -0700 From: Jaegeuk Kim To: Matthew Wilcox Cc: Andrew Morton , linux-xfs@vger.kernel.org, William Kucharski , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-mm@kvack.org, ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-btrfs@vger.kernel.org Subject: Re: [f2fs-dev] [PATCH v9 23/25] f2fs: Pass the inode to f2fs_mpage_readpages Message-ID: <20200323035346.GA147648@google.com> References: <20200320142231.2402-1-willy@infradead.org> <20200320142231.2402-24-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200320142231.2402-24-willy@infradead.org> User-Agent: Mutt/1.12.2 (2019-09-21) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 03/20, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > This function now only uses the mapping argument to look up the inode, > and both callers already have the inode, so just pass the inode instead > of the mapping. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: William Kucharski Acked-by: Jaegeuk Kim > --- > fs/f2fs/data.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c > index 237dff36fe73..c8b042979fc4 100644 > --- a/fs/f2fs/data.c > +++ b/fs/f2fs/data.c > @@ -2159,12 +2159,11 @@ int f2fs_read_multi_pages(struct compress_ctx *cc, struct bio **bio_ret, > * use ->readpage() or do the necessary surgery to decouple ->readpages() > * from read-ahead. > */ > -static int f2fs_mpage_readpages(struct address_space *mapping, > +static int f2fs_mpage_readpages(struct inode *inode, > struct readahead_control *rac, struct page *page) > { > struct bio *bio = NULL; > sector_t last_block_in_bio = 0; > - struct inode *inode = mapping->host; > struct f2fs_map_blocks map; > #ifdef CONFIG_F2FS_FS_COMPRESSION > struct compress_ctx cc = { > @@ -2276,7 +2275,7 @@ static int f2fs_read_data_page(struct file *file, struct page *page) > if (f2fs_has_inline_data(inode)) > ret = f2fs_read_inline_data(inode, page); > if (ret == -EAGAIN) > - ret = f2fs_mpage_readpages(page_file_mapping(page), NULL, page); > + ret = f2fs_mpage_readpages(inode, NULL, page); > return ret; > } > > @@ -2293,7 +2292,7 @@ static void f2fs_readahead(struct readahead_control *rac) > if (f2fs_has_inline_data(inode)) > return; > > - f2fs_mpage_readpages(rac->mapping, rac, NULL); > + f2fs_mpage_readpages(inode, rac, NULL); > } > > int f2fs_encrypt_one_page(struct f2fs_io_info *fio) > -- > 2.25.1 > > > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel