From: Greg KH <gregkh@linuxfoundation.org>
To: Jaewon Kim <jaewon31.kim@samsung.com>
Cc: leon@kernel.org, vbabka@suse.cz, adobriyan@gmail.com,
akpm@linux-foundation.org, labbott@redhat.com,
sumit.semwal@linaro.org, minchan@kernel.org, ngupta@vflare.org,
sergey.senozhatsky.work@gmail.com, kasong@redhat.com,
bhe@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org,
jaewon31.kim@gmail.com, linux-api@vger.kernel.org,
kexec@lists.infradead.org
Subject: Re: [RFC PATCH v2 3/3] android: ion: include system heap size in meminfo extra
Date: Mon, 23 Mar 2020 10:49:46 +0100 [thread overview]
Message-ID: <20200323094946.GA425358@kroah.com> (raw)
In-Reply-To: <20200323080503.6224-4-jaewon31.kim@samsung.com>
On Mon, Mar 23, 2020 at 05:05:03PM +0900, Jaewon Kim wrote:
> In Android system ion system heap size is huge like hundreds of MB. To
> know overal system memory usage, include ion system heap size in
> proc/meminfo_extra.
>
> To include heap size, use register_meminfo_extra introduced in previous
> patch.
>
> Prior to register we need to add stats to show the ion heap usage. Add
> total_allocated into ion heap and count it on allocation and freeing. In
> a ion heap using ION_HEAP_FLAG_DEFER_FREE, a buffer can be freed from
> user but still live on deferred free list. Keep stats until the buffer
> is finally freed so that we can cover situation of deferred free thread
> stuck problem.
>
> i.e) cat /proc/meminfo_extra | grep IonSystemHeap
> IonSystemHeap: 242620 kB
>
> i.e.) show_mem on oom
> <6>[ 420.856428] Mem-Info:
> <6>[ 420.856433] IonSystemHeap:32813kB
>
> Signed-off-by: Jaewon Kim <jaewon31.kim@samsung.com>
> ---
> drivers/staging/android/ion/ion.c | 2 ++
> drivers/staging/android/ion/ion.h | 1 +
> drivers/staging/android/ion/ion_system_heap.c | 2 ++
> 3 files changed, 5 insertions(+)
Does this really give the proper granularity that ion users have? I
thought they wanted to know what each heap was doing.
Also, this code should be deleted really soon now, so I would not make
any core changes to the kernel based on it at all.
thanks,
greg k-h
next prev parent reply other threads:[~2020-03-23 9:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200323080507epcas1p44cdb9ecb70a7a7395b3acddeda3cfd89@epcas1p4.samsung.com>
2020-03-23 8:05 ` [RFC PATCH v2 0/3] meminfo_extra: introduce meminfo extra Jaewon Kim
[not found] ` <CGME20200323080508epcas1p387c9c19b480da53be40fe5d51e76a477@epcas1p3.samsung.com>
2020-03-23 8:05 ` [RFC PATCH v2 1/3] " Jaewon Kim
2020-03-23 9:53 ` Greg KH
2020-03-24 9:11 ` Jaewon Kim
2020-03-24 10:11 ` Greg KH
2020-03-24 11:37 ` Jaewon Kim
2020-03-24 11:46 ` Greg KH
2020-03-24 12:53 ` Jaewon Kim
2020-03-24 13:19 ` Greg KH
2020-03-26 8:21 ` Jaewon Kim
2020-03-29 7:19 ` Leon Romanovsky
2020-03-29 7:23 ` Greg KH
2020-03-29 8:19 ` Leon Romanovsky
2020-03-25 18:23 ` Alexey Dobriyan
2020-03-23 12:00 ` Dave Young
[not found] ` <CGME20200323080508epcas1p2dfe6517169a65936e5ab10c4e63a19a7@epcas1p2.samsung.com>
2020-03-23 8:05 ` [RFC PATCH v2 2/3] mm: zsmalloc: include zs page size in " Jaewon Kim
[not found] ` <CGME20200323080508epcas1p3c68190cd46635b9ff026a4ae70fc7a3b@epcas1p3.samsung.com>
2020-03-23 8:05 ` [RFC PATCH v2 3/3] android: ion: include system heap " Jaewon Kim
2020-03-23 9:49 ` Greg KH [this message]
2020-03-25 18:12 ` [RFC PATCH v2 0/3] meminfo_extra: introduce " Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200323094946.GA425358@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=jaewon31.kim@gmail.com \
--cc=jaewon31.kim@samsung.com \
--cc=kasong@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=labbott@redhat.com \
--cc=leon@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sumit.semwal@linaro.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).