linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Roman Gushchin <guro@fb.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Aslan Bakirov <aslan@fb.com>, Michal Hocko <mhocko@kernel.org>,
	<linux-mm@kvack.org>, <kernel-team@fb.com>,
	<linux-kernel@vger.kernel.org>, Rik van Riel <riel@surriel.com>,
	Mike Kravetz <mike.kravetz@oracle.com>
Subject: Re: [Potential Spoof] [PATCH] mm: hugetlb: fix per-node size calculation for hugetlb_cma
Date: Mon, 23 Mar 2020 16:36:01 -0700	[thread overview]
Message-ID: <20200323233601.GA30285@carbon.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200323221411.2152675-1-guro@fb.com>

On Mon, Mar 23, 2020 at 03:14:11PM -0700, Roman Gushchin wrote:
> Aslan found a bug in the per-node hugetlb_cma area size calculation:
> the total remaining size should cap the per-node area size instead
> of be the minimal possible allocation.
> 
> Without the fix:
> [    0.004136] hugetlb_cma: reserve 2048 MiB, up to 1024 MiB per node
> [    0.004138] cma: Reserved 2048 MiB at 0x0000000180000000
> [    0.004139] hugetlb_cma: reserved 2048 MiB on node 0
> 
> With the fix:
> [    0.006780] hugetlb_cma: reserve 2048 MiB, up to 1024 MiB per node
> [    0.006786] cma: Reserved 1024 MiB at 0x00000001c0000000
> [    0.006787] hugetlb_cma: reserved 1024 MiB on node 0
> [    0.006788] cma: Reserved 1024 MiB at 0x00000003c0000000
> [    0.006789] hugetlb_cma: reserved 1024 MiB on node 1
> 
> Reported-by: Aslan Barkirov <aslan@fb.com>
> Signed-off-by: Roman Gushchin <guro@fb.com>

I'm deeply sorry, I've made a typo in Aslan's name.

v2 fixes this.

Thanks!


      parent reply	other threads:[~2020-03-23 23:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-23 22:14 [PATCH] mm: hugetlb: fix per-node size calculation for hugetlb_cma Roman Gushchin
2020-03-23 23:34 ` [PATCH v2] " Roman Gushchin
2020-03-23 23:36 ` Roman Gushchin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200323233601.GA30285@carbon.dhcp.thefacebook.com \
    --to=guro@fb.com \
    --cc=akpm@linux-foundation.org \
    --cc=aslan@fb.com \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=mike.kravetz@oracle.com \
    --cc=riel@surriel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).