From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 896C8C4332B for ; Tue, 24 Mar 2020 07:34:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6345A20719 for ; Tue, 24 Mar 2020 07:34:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6345A20719 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 06B7A6B00DE; Tue, 24 Mar 2020 03:34:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 01A536B00DF; Tue, 24 Mar 2020 03:34:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E98FF6B00E0; Tue, 24 Mar 2020 03:34:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0143.hostedemail.com [216.40.44.143]) by kanga.kvack.org (Postfix) with ESMTP id CF2DD6B00DE for ; Tue, 24 Mar 2020 03:34:12 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 32BFC8248047 for ; Tue, 24 Mar 2020 07:34:13 +0000 (UTC) X-FDA: 76629442386.19.range65_24cc93f55402b X-HE-Tag: range65_24cc93f55402b X-Filterd-Recvd-Size: 1584 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Tue, 24 Mar 2020 07:34:12 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 4C1C568C4E; Tue, 24 Mar 2020 08:34:10 +0100 (CET) Date: Tue, 24 Mar 2020 08:34:09 +0100 From: Christoph Hellwig To: Jason Gunthorpe Cc: Jerome Glisse , Ralph Campbell , Felix.Kuehling@amd.com, linux-mm@kvack.org, John Hubbard , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Christoph Hellwig , Philip Yang , Jason Gunthorpe Subject: Re: [PATCH v2 hmm 6/9] mm/hmm: use device_private_entry_to_pfn() Message-ID: <20200324073409.GE23447@lst.de> References: <20200324011457.2817-1-jgg@ziepe.ca> <20200324011457.2817-7-jgg@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200324011457.2817-7-jgg@ziepe.ca> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 23, 2020 at 10:14:54PM -0300, Jason Gunthorpe wrote: > From: Jason Gunthorpe > > swp_offset() should not be called directly, the wrappers are supposed to > abstract away the encoding of the device_private specific information in > the swap entry. > > Reviewed-by: Ralph Campbell > Signed-off-by: Jason Gunthorpe Looks good, Reviewed-by: Christoph Hellwig