From: Baoquan He <bhe@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
iamjoonsoo.kim@lge.com, hannes@cmpxchg.org, mhocko@kernel.org,
vbabka@suse.cz, bhe@redhat.com
Subject: [PATCH 3/5] mm/vmstat.c: do not show lowmem reserve protection information of empty zone
Date: Tue, 24 Mar 2020 22:22:27 +0800 [thread overview]
Message-ID: <20200324142229.12028-4-bhe@redhat.com> (raw)
In-Reply-To: <20200324142229.12028-1-bhe@redhat.com>
Because the lowmem reserve protection of a zone can't tell anything if
the zone is empty, except of adding one more line in /proc/zoneinfo.
Let's remove it from that zone's showing.
Signed-off-by: Baoquan He <bhe@redhat.com>
---
mm/vmstat.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/mm/vmstat.c b/mm/vmstat.c
index 96d21a792b57..6fd1407f4632 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -1590,6 +1590,12 @@ static void zoneinfo_show_print(struct seq_file *m, pg_data_t *pgdat,
zone->present_pages,
zone_managed_pages(zone));
+ /* If unpopulated, no other information is useful */
+ if (!populated_zone(zone)) {
+ seq_putc(m, '\n');
+ return;
+ }
+
seq_printf(m,
"\n protection: (%ld",
zone->lowmem_reserve[0]);
@@ -1597,12 +1603,6 @@ static void zoneinfo_show_print(struct seq_file *m, pg_data_t *pgdat,
seq_printf(m, ", %ld", zone->lowmem_reserve[i]);
seq_putc(m, ')');
- /* If unpopulated, no other information is useful */
- if (!populated_zone(zone)) {
- seq_putc(m, '\n');
- return;
- }
-
for (i = 0; i < NR_VM_ZONE_STAT_ITEMS; i++)
seq_printf(m, "\n %-12s %lu", zone_stat_name(i),
zone_page_state(zone, i));
--
2.17.2
next prev parent reply other threads:[~2020-03-24 14:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 14:22 [PATCH 0/5] improvements about lowmem_reserve and /proc/zoneinfo Baoquan He
2020-03-24 14:22 ` [PATCH 1/5] mm/page_alloc.c: only tune sysctl_lowmem_reserve_ratio value once when changing it Baoquan He
2020-03-24 14:22 ` [PATCH 2/5] mm/page_alloc.c: clear out zone->lowmem_reserve[] if the zone is empty Baoquan He
2020-03-24 14:22 ` Baoquan He [this message]
2020-03-24 14:22 ` [PATCH 4/5] mm/vmstat.c: move the per-node stats to the front of /proc/zoneinfo Baoquan He
2020-03-24 19:25 ` David Rientjes
2020-03-25 5:53 ` Baoquan He
2020-03-25 8:55 ` Michal Hocko
2020-03-25 14:23 ` Baoquan He
2020-03-25 19:45 ` David Rientjes
2020-03-26 4:24 ` Baoquan He
2020-03-26 6:43 ` Michal Hocko
2020-03-26 11:22 ` Baoquan He
2020-03-24 14:22 ` [PATCH 5/5] mm/vmstat.c: remove the useless code Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200324142229.12028-4-bhe@redhat.com \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).