From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5D82C2D0E5 for ; Wed, 25 Mar 2020 20:22:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 84A5220740 for ; Wed, 25 Mar 2020 20:22:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="M3COaVcI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 84A5220740 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 143136B000E; Wed, 25 Mar 2020 16:22:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F41B6B006C; Wed, 25 Mar 2020 16:22:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F2C996B0070; Wed, 25 Mar 2020 16:22:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0018.hostedemail.com [216.40.44.18]) by kanga.kvack.org (Postfix) with ESMTP id D76016B000E for ; Wed, 25 Mar 2020 16:22:11 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id DBADB35087 for ; Wed, 25 Mar 2020 20:22:11 +0000 (UTC) X-FDA: 76635006462.29.ants95_6a6c1498ea15c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id B0CC618024E2D for ; Wed, 25 Mar 2020 20:22:11 +0000 (UTC) X-HE-Tag: ants95_6a6c1498ea15c X-Filterd-Recvd-Size: 4296 Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Wed, 25 Mar 2020 20:22:11 +0000 (UTC) Received: by mail-pj1-f66.google.com with SMTP id jz1so2608724pjb.0 for ; Wed, 25 Mar 2020 13:22:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PdpEIpQ/wKeSgsRAafJKurWryJo4Td2Yn8/4nS7DvLI=; b=M3COaVcIwpKVfcCr80swHvdh9xXacj7eY2qC2ds0xZUIr0GOt4mzJLwb1ZwbVI9+Bg XQEamHqFR+VeDMQ3FRvP7wohJct4eF4Q0yfFFLHyAiNgQdrXUvp5l3OBfu+dUDGlCeG8 TwUeNQNwBIaBtP7S7OlSpq0LgGwC0BvmnAp9E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PdpEIpQ/wKeSgsRAafJKurWryJo4Td2Yn8/4nS7DvLI=; b=J/Z/S1UytQoj2LLCuxg5TapL5zxUkmbiCQHhYXiFAjd2gptsjqjB9vpPDW890QSjZg rjonuFw29XM4eWdy1jtlma/n22fWmoxYBvjRzAHI+kS1kdFZ2nUeSH6uSblpeRGSBWbW P8+iUaznnefP/IKxwXkg/XMpGx1dthnQ1uQveiVG9fVhdyiNDgiIZ9c2uPSY9E++Oalt XW4raT4EqcJl75Tr3+eUc5TSaoR/PV0vbmMnRJWaSD+c8mZpzxAkTfJTy5Y2f7heG7Gp fZC66utydNa6EZraTd9+nn7IvP7CHeN5hf0f7orOPdxU+aYA8PQPiPnWnIaVx1Eg/whA RmBg== X-Gm-Message-State: ANhLgQ36cx+RQfSlSXCH2cFjvofHRuNWoB5TIdbhvQIYavJU4qgZiNj4 g3U6bmA8Xx6rKsarWkMfh5FQQA== X-Google-Smtp-Source: ADFU+vs+9qXw30Y/gM8gDtnz4iYFAg0dyECDyKOna2Nf6+mD+qup1rem6mTHJ82584OyB/TSrpCOAg== X-Received: by 2002:a17:902:9889:: with SMTP id s9mr4491897plp.252.1585167729772; Wed, 25 Mar 2020 13:22:09 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id q19sm8285835pgn.93.2020.03.25.13.22.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2020 13:22:08 -0700 (PDT) Date: Wed, 25 Mar 2020 13:22:07 -0700 From: Kees Cook To: Mark Rutland Cc: Thomas Gleixner , Elena Reshetova , x86@kernel.org, Andy Lutomirski , Peter Zijlstra , Catalin Marinas , Will Deacon , Alexander Potapenko , Ard Biesheuvel , Jann Horn , "Perla, Enrico" , kernel-hardening@lists.openwall.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/5] arm64: entry: Enable random_kstack_offset support Message-ID: <202003251319.AECA788D63@keescook> References: <20200324203231.64324-1-keescook@chromium.org> <20200324203231.64324-6-keescook@chromium.org> <20200325132127.GB12236@lakrids.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200325132127.GB12236@lakrids.cambridge.arm.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 25, 2020 at 01:21:27PM +0000, Mark Rutland wrote: > On Tue, Mar 24, 2020 at 01:32:31PM -0700, Kees Cook wrote: > > Allow for a randomized stack offset on a per-syscall basis, with roughly > > 5 bits of entropy. > > > > Signed-off-by: Kees Cook > > Just to check, do you have an idea of the impact on arm64? Patch 3 had > figures for x86 where it reads the TSC, and it's unclear to me how > get_random_int() compares to that. I didn't do a measurement on arm64 since I don't have a good bare-metal test environment. I know Andy Lutomirki has plans for making get_random_get() as fast as possible, so that's why I used it here. I couldn't figure out if there was a comparable instruction like rdtsc in aarch64 (it seems there's a cycle counter, but I found nothing in the kernel that seemed to actually use it)? > Otherwise, this looks sound to me; I'd jsut like to know whether the > overhead is in the same ballpark. Thanks! -Kees -- Kees Cook