From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3901C1975A for ; Wed, 25 Mar 2020 14:44:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B007A20775 for ; Wed, 25 Mar 2020 14:44:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B007A20775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 48B206B0005; Wed, 25 Mar 2020 10:44:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 43A956B000C; Wed, 25 Mar 2020 10:44:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 350DC6B000D; Wed, 25 Mar 2020 10:44:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0230.hostedemail.com [216.40.44.230]) by kanga.kvack.org (Postfix) with ESMTP id 1C6496B0005 for ; Wed, 25 Mar 2020 10:44:59 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D326A181AC544 for ; Wed, 25 Mar 2020 14:44:58 +0000 (UTC) X-FDA: 76634156676.04.table13_488c9b92da414 X-HE-Tag: table13_488c9b92da414 X-Filterd-Recvd-Size: 3899 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Wed, 25 Mar 2020 14:44:58 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id p10so3449261wrt.6 for ; Wed, 25 Mar 2020 07:44:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1wXJURRfaYTpe+TCjojzcV1WjXnlcA0INFVzjy7A9b0=; b=uCVy5YEDkNeH199FYXuWBaVOOGLpC0P0med9Ru3CyTX9wgRzSuI8kRTW79Jur2k6Zc oP3ZmGDw7isW+A6qdqVmgE0Yv5ehDF866/a9Z75NcqdMy+GjfwOxW+SzePtld3lB4Ozm OkMTPQhxeSPg7mfG00CNu9qTQhqHIRf6J9D25rxRSRkYlXZ2R6V5rlaPcmhV6uGvnPU/ jT+pF2HxXxZtFy2LjoOefkzDPiPgbMs/urzoP1dzBTyWmfHNzZoeWKe4tt+P0wJBrHog k3ODE3PTRjU73NpHJk/8xpNPFmowtWxZRIwRK5eVNUv0CGc1xK02lSK8flHVWa8rX75v kzzQ== X-Gm-Message-State: ANhLgQ1212ieZcANkTRYWd36yCGkVfld6GFuZpoibKgqeK/B86d/2fKG y/x4JBdDuLbXREPC+Sv62bFHh3H9 X-Google-Smtp-Source: ADFU+vtP5TbgvM97466nU7Ig6JQ0PKYu5gHQ/U5ZR4td856KE9KuAti5Bf+113PwA58BsS0hnY0XFQ== X-Received: by 2002:a5d:468c:: with SMTP id u12mr4074403wrq.394.1585147497291; Wed, 25 Mar 2020 07:44:57 -0700 (PDT) Received: from localhost (ip-37-188-135-150.eurotel.cz. [37.188.135.150]) by smtp.gmail.com with ESMTPSA id b82sm9241480wmb.46.2020.03.25.07.44.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2020 07:44:56 -0700 (PDT) Date: Wed, 25 Mar 2020 15:44:55 +0100 From: Michal Hocko To: Vlastimil Babka Cc: Luis Chamberlain , Kees Cook , Iurii Zaikin , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-mm@kvack.org, Ivan Teterevkov , David Rientjes , Matthew Wilcox , "Eric W . Biederman" , "Guilherme G . Piccoli" Subject: Re: [RFC v2 2/2] kernel/sysctl: support handling command line aliases Message-ID: <20200325144455.GE19542@dhcp22.suse.cz> References: <20200325120345.12946-1-vbabka@suse.cz> <20200325120345.12946-2-vbabka@suse.cz> <20200325142936.GC19542@dhcp22.suse.cz> <52faea3b-6442-3b1b-9404-6a018d1d1c44@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52faea3b-6442-3b1b-9404-6a018d1d1c44@suse.cz> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 25-03-20 15:36:23, Vlastimil Babka wrote: > On 3/25/20 3:29 PM, Michal Hocko wrote: > > Both patches look really great to me. I haven't really checked all the > > details but from a quick glance they both seem ok. > > Thanks. > > > I would just add a small clarification here. Unless I am mistaken > > early_param is called earlier than it would be now. But that shouldn't > > cause any problems because the underlying implementation is just a noop > > for backward compatibility. > > Yeah, indeed worth noting somewhere explicitly. The conversion can't be done > blindly, one has to consider whether the delay compared to early_param can be a > disadvantage or not. For example the nmi_watchdog parameter is probably best > left as it is? I wouldn't mind moving nmi_watchdog timeout initialization to later. If there is a usecase to rely on an early initialization then the patch can be reverted but I struggle to think of anything reasonable. If the early init code needs a lonter timeout to prevent from false positives then there is clearly a bug to be better fixed. And a necessary shorter timeout sounds quite exotic to me TBH. -- Michal Hocko SUSE Labs