From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8762C54FD5 for ; Wed, 25 Mar 2020 17:02:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 915DB20772 for ; Wed, 25 Mar 2020 17:02:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 915DB20772 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 275FC6B00B9; Wed, 25 Mar 2020 13:02:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 228516B00BA; Wed, 25 Mar 2020 13:02:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 13EA46B00BC; Wed, 25 Mar 2020 13:02:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0158.hostedemail.com [216.40.44.158]) by kanga.kvack.org (Postfix) with ESMTP id E835F6B00B9 for ; Wed, 25 Mar 2020 13:02:02 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 69FA696F08 for ; Wed, 25 Mar 2020 17:02:02 +0000 (UTC) X-FDA: 76634502084.05.stop72_6909e4a0abb14 X-HE-Tag: stop72_6909e4a0abb14 X-Filterd-Recvd-Size: 4298 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Wed, 25 Mar 2020 17:02:01 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6AEE21FB; Wed, 25 Mar 2020 10:02:00 -0700 (PDT) Received: from red-moon.cambridge.arm.com (unknown [10.57.20.165]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9E8223F52E; Wed, 25 Mar 2020 10:01:58 -0700 (PDT) Date: Wed, 25 Mar 2020 17:01:43 +0000 From: Lorenzo Pieralisi To: Vidya Sagar Cc: Bjorn Helgaas , Randy Dunlap , akpm@linux-foundation.org, broonie@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-next@vger.kernel.org, mhocko@suse.cz, mm-commits@vger.kernel.org, sfr@canb.auug.org.au, linux-pci Subject: Re: mmotm 2020-03-23-21-29 uploaded (pci/controller/dwc/pcie-tegra194.c) Message-ID: <20200325170122.GA29504@red-moon.cambridge.arm.com> References: <20200324161851.GA2300@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 25, 2020 at 08:43:32PM +0530, Vidya Sagar wrote: >=20 >=20 > On 3/24/2020 9:48 PM, Bjorn Helgaas wrote: > > External email: Use caution opening links or attachments > >=20 > >=20 > > On Tue, Mar 24, 2020 at 08:16:34AM -0700, Randy Dunlap wrote: > > > On 3/23/20 9:30 PM, akpm@linux-foundation.org wrote: > > > > The mm-of-the-moment snapshot 2020-03-23-21-29 has been uploaded = to > > > >=20 > > > > http://www.ozlabs.org/~akpm/mmotm/ > > > >=20 > > > > mmotm-readme.txt says > > > >=20 > > > > README for mm-of-the-moment: > > > >=20 > > > > http://www.ozlabs.org/~akpm/mmotm/ > > > >=20 > > > > This is a snapshot of my -mm patch queue. Uploaded at random hop= efully > > > > more than once a week. > > > >=20 > > > > You will need quilt to apply these patches to the latest Linus re= lease (5.x > > > > or 5.x-rcY). The series file is in broken-out.tar.gz and is dupl= icated in > > > > http://ozlabs.org/~akpm/mmotm/series > > >=20 > > >=20 > > > on x86_64: > > >=20 > > > ../drivers/pci/controller/dwc/pcie-tegra194.c: In function =E2=80=98= tegra_pcie_dw_parse_dt=E2=80=99: > > > ../drivers/pci/controller/dwc/pcie-tegra194.c:1160:24: error: impli= cit declaration of function =E2=80=98devm_gpiod_get=E2=80=99; did you mea= n =E2=80=98devm_phy_get=E2=80=99? [-Werror=3Dimplicit-function-declaratio= n] > > > pcie->pex_rst_gpiod =3D devm_gpiod_get(pcie->dev, "reset", GPIOD= _IN); > > > ^~~~~~~~~~~~~~ > > > devm_phy_get > >=20 > > Thanks a lot for the report! > >=20 > > This was found on mmotm, but I updated my -next branch with Lorenzo's > > latest pci/endpoint branch (current head 775d9e68f470) and reproduced > > this build failure with the .config you attached. > >=20 > > I dropped that branch from my -next branch for now and pushed it. > I found that one header file inclusion is missing. > The following patch fixes it. > Also, I wanted to know how can I catch this locally? i.e. How can I > generate the config file attached by Randy locally so that I can get th= e > source ready without these kind of issues? >=20 > Bjorn/Lorenzo, would you be able to apply below change in your trees or > do I need to send a patch for this? Squashed in and re-pushed out pci/endpoint, it should have fixed this issue. Thanks, Lorenzo > diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c > b/drivers/pci/controller/dwc/pcie-tegra194.c > index 97d3f3db1020..eeeca18892c6 100644 > --- a/drivers/pci/controller/dwc/pcie-tegra194.c > +++ b/drivers/pci/controller/dwc/pcie-tegra194.c > @@ -11,6 +11,7 @@ > #include > #include > #include > +#include > #include > #include > #include >=20 >=20 > >=20 > > Bjorn > >=20