Linux-mm Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] mm: Remove dummy struct bootmem_data/bootmem_data_t
@ 2020-03-26  2:26 Waiman Long
  2020-03-26  4:02 ` Baoquan He
  2020-03-26 14:25 ` Mike Rapoport
  0 siblings, 2 replies; 3+ messages in thread
From: Waiman Long @ 2020-03-26  2:26 UTC (permalink / raw)
  To: Andrew Morton, Richard Henderson, Ivan Kokshaysky, Matt Turner
  Cc: linux-mm, linux-kernel, linux-alpha, Waiman Long

Both bootmem_data and bootmem_data_t structures are no longer defined.
Remove the dummy forward declarations.

Signed-off-by: Waiman Long <longman@redhat.com>
---
 arch/alpha/include/asm/mmzone.h | 2 --
 include/linux/mmzone.h          | 1 -
 2 files changed, 3 deletions(-)

diff --git a/arch/alpha/include/asm/mmzone.h b/arch/alpha/include/asm/mmzone.h
index 7ee144f484f1..9b521c857436 100644
--- a/arch/alpha/include/asm/mmzone.h
+++ b/arch/alpha/include/asm/mmzone.h
@@ -8,8 +8,6 @@
 
 #include <asm/smp.h>
 
-struct bootmem_data_t; /* stupid forward decl. */
-
 /*
  * Following are macros that are specific to this numa platform.
  */
diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
index 462f6873905a..5c388eced889 100644
--- a/include/linux/mmzone.h
+++ b/include/linux/mmzone.h
@@ -706,7 +706,6 @@ struct deferred_split {
  * Memory statistics and page replacement data structures are maintained on a
  * per-zone basis.
  */
-struct bootmem_data;
 typedef struct pglist_data {
 	struct zone node_zones[MAX_NR_ZONES];
 	struct zonelist node_zonelists[MAX_ZONELISTS];
-- 
2.18.1



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mm: Remove dummy struct bootmem_data/bootmem_data_t
  2020-03-26  2:26 [PATCH] mm: Remove dummy struct bootmem_data/bootmem_data_t Waiman Long
@ 2020-03-26  4:02 ` Baoquan He
  2020-03-26 14:25 ` Mike Rapoport
  1 sibling, 0 replies; 3+ messages in thread
From: Baoquan He @ 2020-03-26  4:02 UTC (permalink / raw)
  To: Waiman Long
  Cc: Andrew Morton, Richard Henderson, Ivan Kokshaysky, Matt Turner,
	linux-mm, linux-kernel, linux-alpha

On 03/25/20 at 10:26pm, Waiman Long wrote:
> Both bootmem_data and bootmem_data_t structures are no longer defined.
> Remove the dummy forward declarations.
> 
> Signed-off-by: Waiman Long <longman@redhat.com>
> ---
>  arch/alpha/include/asm/mmzone.h | 2 --
>  include/linux/mmzone.h          | 1 -
>  2 files changed, 3 deletions(-)
> 
> diff --git a/arch/alpha/include/asm/mmzone.h b/arch/alpha/include/asm/mmzone.h
> index 7ee144f484f1..9b521c857436 100644
> --- a/arch/alpha/include/asm/mmzone.h
> +++ b/arch/alpha/include/asm/mmzone.h
> @@ -8,8 +8,6 @@
>  
>  #include <asm/smp.h>
>  
> -struct bootmem_data_t; /* stupid forward decl. */
> -
>  /*
>   * Following are macros that are specific to this numa platform.
>   */
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index 462f6873905a..5c388eced889 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -706,7 +706,6 @@ struct deferred_split {
>   * Memory statistics and page replacement data structures are maintained on a
>   * per-zone basis.
>   */
> -struct bootmem_data;
>  typedef struct pglist_data {
>  	struct zone node_zones[MAX_NR_ZONES];
>  	struct zonelist node_zonelists[MAX_ZONELISTS];

Looks good to me.

Reviewed-by: Baoquan He <bhe@redhat.com>



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mm: Remove dummy struct bootmem_data/bootmem_data_t
  2020-03-26  2:26 [PATCH] mm: Remove dummy struct bootmem_data/bootmem_data_t Waiman Long
  2020-03-26  4:02 ` Baoquan He
@ 2020-03-26 14:25 ` Mike Rapoport
  1 sibling, 0 replies; 3+ messages in thread
From: Mike Rapoport @ 2020-03-26 14:25 UTC (permalink / raw)
  To: Waiman Long
  Cc: Andrew Morton, Richard Henderson, Ivan Kokshaysky, Matt Turner,
	linux-mm, linux-kernel, linux-alpha

On Wed, Mar 25, 2020 at 10:26:17PM -0400, Waiman Long wrote:
> Both bootmem_data and bootmem_data_t structures are no longer defined.
> Remove the dummy forward declarations.
> 
> Signed-off-by: Waiman Long <longman@redhat.com>

Acked-by: Mike Rapoport <rppt@linux.ibm.com>

> ---
>  arch/alpha/include/asm/mmzone.h | 2 --
>  include/linux/mmzone.h          | 1 -
>  2 files changed, 3 deletions(-)
> 
> diff --git a/arch/alpha/include/asm/mmzone.h b/arch/alpha/include/asm/mmzone.h
> index 7ee144f484f1..9b521c857436 100644
> --- a/arch/alpha/include/asm/mmzone.h
> +++ b/arch/alpha/include/asm/mmzone.h
> @@ -8,8 +8,6 @@
>  
>  #include <asm/smp.h>
>  
> -struct bootmem_data_t; /* stupid forward decl. */
> -
>  /*
>   * Following are macros that are specific to this numa platform.
>   */
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index 462f6873905a..5c388eced889 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -706,7 +706,6 @@ struct deferred_split {
>   * Memory statistics and page replacement data structures are maintained on a
>   * per-zone basis.
>   */
> -struct bootmem_data;
>  typedef struct pglist_data {
>  	struct zone node_zones[MAX_NR_ZONES];
>  	struct zonelist node_zonelists[MAX_ZONELISTS];
> -- 
> 2.18.1
> 
> 

-- 
Sincerely yours,
Mike.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-26  2:26 [PATCH] mm: Remove dummy struct bootmem_data/bootmem_data_t Waiman Long
2020-03-26  4:02 ` Baoquan He
2020-03-26 14:25 ` Mike Rapoport

Linux-mm Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mm/0 linux-mm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mm linux-mm/ https://lore.kernel.org/linux-mm \
		linux-mm@kvack.org
	public-inbox-index linux-mm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kvack.linux-mm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git