From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 749CEC43331 for ; Tue, 31 Mar 2020 08:59:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1B44320787 for ; Tue, 31 Mar 2020 08:59:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (4096-bit key) header.d=d-silva.org header.i=@d-silva.org header.b="Kalaxq5z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B44320787 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=d-silva.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C49A26B006C; Tue, 31 Mar 2020 04:59:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD4986B006E; Tue, 31 Mar 2020 04:59:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC1916B0070; Tue, 31 Mar 2020 04:59:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0103.hostedemail.com [216.40.44.103]) by kanga.kvack.org (Postfix) with ESMTP id 9663D6B006C for ; Tue, 31 Mar 2020 04:59:34 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 4FEFF180AD80F for ; Tue, 31 Mar 2020 08:59:34 +0000 (UTC) X-FDA: 76655059068.19.hour13_1944265e1bd0e X-HE-Tag: hour13_1944265e1bd0e X-Filterd-Recvd-Size: 14767 Received: from ushosting.nmnhosting.com (ushosting.nmnhosting.com [66.55.73.32]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Tue, 31 Mar 2020 08:59:33 +0000 (UTC) Received: from mail2.nmnhosting.com (unknown [202.169.106.97]) by ushosting.nmnhosting.com (Postfix) with ESMTPS id 4BCB92DC6849; Mon, 30 Mar 2020 16:53:02 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=d-silva.org; s=201810a; t=1585547583; bh=4YGi5cIVTJtyQ3RAuYeIobqzlKnYrZhy+tDNyNbmbBI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Kalaxq5zVXcqXTV+7cShrpQDd+DPjZ0pPj3T9DCz6pKgtR1jC4i1QdZ4SEX5u98e8 mKVtVWsG0B4kjkBeXSf6ADl11fwAI/lJGptO7Tf+KvP3OWculqcOsJiOhWP/8WY0Mj YR9egnccj5YS2nT1mNHiRYvl+hfcbxFCe2QQnIAm0pnpRLBt5DP3TOBWlcReFrz7mR Vpy6p0JeKxz7QzJyGl5TtfstdMotqraAwA3yafv3XyqrYpXf0mzjw/Ypq6sRf+jyoD 3AclM8QlsKopRJ5p03zihQ4NjOKFUTGcAblvp3FJrml3mxvQgH8cNtpmsD+i/2ni4b YiUOoudKtzWsjftqEx3J/ZkF49wCnIG9Jdz6uT10iPY2K371GsYcxNmQOqSNfmOQ/r W1LReKTP0Rpv1vxZAyq4KSphvzy4rOjiQwSTpdVwVmA1yMFA412VOuZaAUD4pBudtt aLsEbJ/C7y/SDEGhxgz+KPhJByXpDmpN64EBQ8Q5oWbrBtYktHR4O6mR69Fmty4HeM aOfCKx0hdaJQ3THwIrsnPhX7aWWvs0U1KMN9vVKbgO1aezYhhjSdR+FEItYQdhRnUp OHl1LYLkwGFzo+zpxHnP+j8wleROH4fR17cfK6tCa/NmWejDWYK23qZP1t+SqmGftV sCXgC3b2hOmfKrutn8Fut04Y= Received: from localhost.lan ([10.0.1.179]) by mail2.nmnhosting.com (8.15.2/8.15.2) with ESMTP id 02R7C4Ap045934; Fri, 27 Mar 2020 18:12:18 +1100 (AEDT) (envelope-from alastair@d-silva.org) From: "Alastair D'Silva" To: alastair@d-silva.org Cc: "Aneesh Kumar K . V" , "Oliver O'Halloran" , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Frederic Barrat , Andrew Donnellan , Arnd Bergmann , Greg Kroah-Hartman , Dan Williams , Vishal Verma , Dave Jiang , Ira Weiny , Andrew Morton , Mauro Carvalho Chehab , "David S. Miller" , Rob Herring , Anton Blanchard , Krzysztof Kozlowski , Mahesh Salgaonkar , Madhavan Srinivasan , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Anju T Sudhakar , Hari Bathini , Thomas Gleixner , Greg Kurz , Nicholas Piggin , Masahiro Yamada , Alexey Kardashevskiy , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-nvdimm@lists.01.org, linux-mm@kvack.org Subject: [PATCH v4 16/25] nvdimm/ocxl: Implement the Read Error Log command Date: Fri, 27 Mar 2020 18:11:53 +1100 Message-Id: <20200327071202.2159885-17-alastair@d-silva.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200327071202.2159885-1-alastair@d-silva.org> References: <20200327071202.2159885-1-alastair@d-silva.org> MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mail2.nmnhosting.com [10.0.1.20]); Fri, 27 Mar 2020 18:12:18 +1100 (AEDT) Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The read error log command extracts information from the controller's internal error log. This patch exposes this information in 2 ways: - During probe, if an error occurs & a log is available, print it to the console - After probe, make the error log available to userspace via an IOCTL. Userspace is notified of pending error logs in a later patch ("powerpc/powernv/pmem: Forward events to userspace") Signed-off-by: Alastair D'Silva --- .../userspace-api/ioctl/ioctl-number.rst | 1 + drivers/nvdimm/ocxl/main.c | 240 ++++++++++++++++++ include/uapi/nvdimm/ocxlpmem.h | 46 ++++ 3 files changed, 287 insertions(+) create mode 100644 include/uapi/nvdimm/ocxlpmem.h diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst b/Documen= tation/userspace-api/ioctl/ioctl-number.rst index 9425377615ce..ba0ce7dca643 100644 --- a/Documentation/userspace-api/ioctl/ioctl-number.rst +++ b/Documentation/userspace-api/ioctl/ioctl-number.rst @@ -340,6 +340,7 @@ Code Seq# Include File = Comments 0xC0 00-0F linux/usb/iowarrior.h 0xCA 00-0F uapi/misc/cxl.h 0xCA 10-2F uapi/misc/ocxl.h +0xCA 30-3F uapi/nvdimm/ocxlpmem.h Ope= nCAPI Persistent Memory 0xCA 80-BF uapi/scsi/cxlflash_ioctl.h 0xCB 00-1F CBM= serial IEC bus in development: diff --git a/drivers/nvdimm/ocxl/main.c b/drivers/nvdimm/ocxl/main.c index 9b85fcd3f1c9..e6be0029f658 100644 --- a/drivers/nvdimm/ocxl/main.c +++ b/drivers/nvdimm/ocxl/main.c @@ -13,6 +13,7 @@ #include #include #include +#include #include "ocxlpmem.h" =20 static const struct pci_device_id pci_tbl[] =3D { @@ -401,10 +402,190 @@ static int file_release(struct inode *inode, struc= t file *file) return 0; } =20 +/** + * error_log_header_parse() - Parse the first 64 bits of the error log c= ommand response + * @ocxlpmem: the device metadata + * @length: out, returns the number of bytes in the response (excluding = the 64 bit header) + */ +static int error_log_header_parse(struct ocxlpmem *ocxlpmem, u16 *length= ) +{ + int rc; + u64 val; + u16 data_identifier; + u32 data_length; + + rc =3D ocxl_global_mmio_read64(ocxlpmem->ocxl_afu, + ocxlpmem->admin_command.data_offset, + OCXL_LITTLE_ENDIAN, &val); + if (rc) + return rc; + + data_identifier =3D val >> 48; + data_length =3D val & 0xFFFF; + + if (data_identifier !=3D 0x454C) { // 'EL' + dev_err(&ocxlpmem->dev, + "Bad data identifier for error log data, expected 'EL', got '%2s' (%#= x), data_length=3D%u\n", + (char *)&data_identifier, + (unsigned int)data_identifier, data_length); + return -EINVAL; + } + + *length =3D data_length; + return 0; +} + +static int read_error_log(struct ocxlpmem *ocxlpmem, + struct ioctl_ocxlpmem_error_log *log, + bool buf_is_user) +{ + u64 val; + u16 user_buf_length; + u16 buf_length; + u64 *buf =3D (u64 *)log->buf_ptr; + u16 i; + int rc; + + if (log->buf_size % 8) + return -EINVAL; + + rc =3D ocxlpmem_chi(ocxlpmem, &val); + if (rc) + return rc; + + if (!(val & GLOBAL_MMIO_CHI_ELA)) + return -EAGAIN; + + user_buf_length =3D log->buf_size; + + mutex_lock(&ocxlpmem->admin_command.lock); + + rc =3D admin_command_execute(ocxlpmem, ADMIN_COMMAND_ERRLOG); + if (rc !=3D STATUS_SUCCESS) { + warn_status(ocxlpmem, + "Unexpected status from retrieve error log", rc); + goto out; + } + + rc =3D error_log_header_parse(ocxlpmem, &log->buf_size); + if (rc) + goto out; + // log->buf_size now contains the returned buffer size, not the user si= ze + + rc =3D ocxl_global_mmio_read64(ocxlpmem->ocxl_afu, + ocxlpmem->admin_command.data_offset + 0x08, + OCXL_LITTLE_ENDIAN, &val); + if (rc) + goto out; + + log->log_identifier =3D val >> 32; + log->program_reference_code =3D val & 0xFFFFFFFF; + + rc =3D ocxl_global_mmio_read64(ocxlpmem->ocxl_afu, + ocxlpmem->admin_command.data_offset + 0x10, + OCXL_LITTLE_ENDIAN, &val); + if (rc) + goto out; + + log->error_log_type =3D val >> 56; + log->action_flags =3D (log->error_log_type =3D=3D OCXLPMEM_ERROR_LOG_TY= PE_GENERAL) ? + (val >> 32) & 0xFFFFFF : 0; + log->power_on_seconds =3D val & 0xFFFFFFFF; + + rc =3D ocxl_global_mmio_read64(ocxlpmem->ocxl_afu, + ocxlpmem->admin_command.data_offset + 0x18, + OCXL_LITTLE_ENDIAN, &log->timestamp); + if (rc) + goto out; + + rc =3D ocxl_global_mmio_read64(ocxlpmem->ocxl_afu, + ocxlpmem->admin_command.data_offset + 0x20, + OCXL_LITTLE_ENDIAN, &log->wwid[0]); + if (rc) + goto out; + + rc =3D ocxl_global_mmio_read64(ocxlpmem->ocxl_afu, + ocxlpmem->admin_command.data_offset + 0x28, + OCXL_LITTLE_ENDIAN, &log->wwid[1]); + if (rc) + goto out; + + rc =3D ocxl_global_mmio_read64(ocxlpmem->ocxl_afu, + ocxlpmem->admin_command.data_offset + 0x30, + OCXL_HOST_ENDIAN, (u64 *)log->fw_revision); + if (rc) + goto out; + log->fw_revision[8] =3D '\0'; + + buf_length =3D (user_buf_length < log->buf_size) ? + user_buf_length : log->buf_size; + for (i =3D 0; i < buf_length / (sizeof(u64)); i++) { + rc =3D ocxl_global_mmio_read64(ocxlpmem->ocxl_afu, + ocxlpmem->admin_command.data_offset + + i * sizeof(u64), + OCXL_HOST_ENDIAN, &val); + if (rc) + goto out; + + if (buf_is_user) { + if (copy_to_user((u64 __user *)&buf[i], &val, + sizeof(u64))) { + rc =3D -EFAULT; + goto out; + } + } else { + buf[i] =3D val; + } + } + + rc =3D admin_response_handled(ocxlpmem); + if (rc) + goto out; + +out: + mutex_unlock(&ocxlpmem->admin_command.lock); + return rc; +} + +static int ioctl_error_log(struct ocxlpmem *ocxlpmem, + struct ioctl_ocxlpmem_error_log __user *uarg) +{ + struct ioctl_ocxlpmem_error_log args; + int rc; + + if (copy_from_user(&args, uarg, sizeof(args))) + return -EFAULT; + + rc =3D read_error_log(ocxlpmem, &args, true); + if (rc) + return rc; + + if (copy_to_user(uarg, &args, sizeof(args))) + return -EFAULT; + + return 0; +} + +static long file_ioctl(struct file *file, unsigned int cmd, unsigned lon= g args) +{ + struct ocxlpmem *ocxlpmem =3D file->private_data; + int rc =3D -EINVAL; + + switch (cmd) { + case IOCTL_OCXLPMEM_ERROR_LOG: + rc =3D ioctl_error_log(ocxlpmem, + (struct ioctl_ocxlpmem_error_log __user *)args); + break; + } + return rc; +} + static const struct file_operations fops =3D { .owner =3D THIS_MODULE, .open =3D file_open, .release =3D file_release, + .unlocked_ioctl =3D file_ioctl, + .compat_ioctl =3D file_ioctl, }; =20 /** @@ -493,6 +674,60 @@ static int read_device_metadata(struct ocxlpmem *ocx= lpmem) return 0; } =20 +static const char *decode_error_log_type(u8 error_log_type) +{ + switch (error_log_type) { + case 0x00: + return "general"; + case 0x01: + return "predictive failure"; + case 0x02: + return "thermal warning"; + case 0x03: + return "data loss"; + case 0x04: + return "health & performance"; + default: + return "unknown"; + } +} + +static void dump_error_log(struct ocxlpmem *ocxlpmem) +{ + struct ioctl_ocxlpmem_error_log log; + u32 buf_size; + u8 *buf; + int rc; + + if (ocxlpmem->admin_command.data_size =3D=3D 0) + return; + + buf_size =3D ocxlpmem->admin_command.data_size - 0x48; + buf =3D kzalloc(buf_size, GFP_KERNEL); + if (!buf) + return; + + log.buf_ptr =3D (u64)buf; + log.buf_size =3D buf_size; + + rc =3D read_error_log(ocxlpmem, &log, false); + if (rc < 0) + goto out; + + dev_warn(&ocxlpmem->dev, + "OCXL PMEM Error log: WWID=3D0x%016llx%016llx LID=3D0x%x PRC=3D%x typ= e=3D0x%x %s, Uptime=3D%u seconds timestamp=3D0x%llx\n", + log.wwid[0], log.wwid[1], + log.log_identifier, log.program_reference_code, + log.error_log_type, + decode_error_log_type(log.error_log_type), + log.power_on_seconds, log.timestamp); + print_hex_dump(KERN_WARNING, "buf", DUMP_PREFIX_OFFSET, 16, 1, buf, + log.buf_size, false); + +out: + kfree(buf); +} + /** * probe_function0() - Set up function 0 for an OpenCAPI persistent memo= ry device * This is important as it enables templates higher than 0 across all ot= her @@ -656,6 +891,11 @@ static int probe(struct pci_dev *pdev, const struct = pci_device_id *ent) pci_set_drvdata(pdev, NULL); =20 err: + if (ocxlpmem && + (ocxlpmem_chi(ocxlpmem, &chi) =3D=3D 0) && + (chi & GLOBAL_MMIO_CHI_ELA)) + dump_error_log(ocxlpmem); + /* * Further cleanup is done in the release handler via free_ocxlpmem() * This allows us to keep the character device live to handle IOCTLs to diff --git a/include/uapi/nvdimm/ocxlpmem.h b/include/uapi/nvdimm/ocxlpme= m.h new file mode 100644 index 000000000000..5d3a03ea1e08 --- /dev/null +++ b/include/uapi/nvdimm/ocxlpmem.h @@ -0,0 +1,46 @@ +/* SPDX-License-Identifier: GPL-2.0+ WITH Linux-syscall-note */ +/* Copyright 2020 IBM Corp. */ +#ifndef _UAPI_OCXL_SCM_H +#define _UAPI_OCXL_SCM_H + +#include +#include + +#define OCXLPMEM_ERROR_LOG_ACTION_RESET (1 << (32 - 32)) +#define OCXLPMEM_ERROR_LOG_ACTION_CHKFW (1 << (53 - 32)) +#define OCXLPMEM_ERROR_LOG_ACTION_REPLACE (1 << (54 - 32)) +#define OCXLPMEM_ERROR_LOG_ACTION_DUMP (1 << (55 - 32)) + +#define OCXLPMEM_ERROR_LOG_TYPE_GENERAL (0x00) +#define OCXLPMEM_ERROR_LOG_TYPE_PREDICTIVE_FAILURE (0x01) +#define OCXLPMEM_ERROR_LOG_TYPE_THERMAL_WARNING (0x02) +#define OCXLPMEM_ERROR_LOG_TYPE_DATA_LOSS (0x03) +#define OCXLPMEM_ERROR_LOG_TYPE_HEALTH_PERFORMANCE (0x04) + +struct ioctl_ocxlpmem_error_log { + __u32 log_identifier; /* out */ + __u32 program_reference_code; /* out */ + __u32 action_flags; /* out, recommended course of action */ + __u32 power_on_seconds; /* out, Number of seconds the controller has be= en on when the error occurred */ + __u64 timestamp; /* out, relative time since the current IPL */ + __u64 wwid[2]; /* out, the NAA formatted WWID associated with the contr= oller */ + char fw_revision[8 + 1]; /* out, firmware revision as null terminated = text */ + __u8 reserved0[7]; + __u16 buf_size; /* in/out, buffer size provided/required. + * If required is greater than provided, the buffer + * will be truncated to the amount provided. If its + * less, then only the required bytes will be populated. + * If it is 0, then there are no more error log entries. + */ + __u8 error_log_type; + __u8 reserved1[5]; + __u64 buf_ptr; /* coerced pointer to output buffer */ + __u64 reserved2[2]; +}; + +/* ioctl numbers */ +#define OCXLPMEM_MAGIC 0xCA +/* OpenCAPI Persistent memory devices */ +#define IOCTL_OCXLPMEM_ERROR_LOG _IOWR(OCXLPMEM_MAGIC, 0x30, struct io= ctl_ocxlpmem_error_log) + +#endif /* _UAPI_OCXL_SCM_H */ --=20 2.24.1