From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66A5AC43331 for ; Sat, 28 Mar 2020 08:58:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2523A206F2 for ; Sat, 28 Mar 2020 08:58:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bmG8Fngn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2523A206F2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C6F986B0010; Sat, 28 Mar 2020 04:58:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF9C36B0032; Sat, 28 Mar 2020 04:58:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9AD86B0036; Sat, 28 Mar 2020 04:58:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0238.hostedemail.com [216.40.44.238]) by kanga.kvack.org (Postfix) with ESMTP id 8E2BA6B0010 for ; Sat, 28 Mar 2020 04:58:06 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 50DCF8245571 for ; Sat, 28 Mar 2020 08:58:06 +0000 (UTC) X-FDA: 76644168972.17.ocean61_80eaecfa9b83a X-HE-Tag: ocean61_80eaecfa9b83a X-Filterd-Recvd-Size: 5980 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Sat, 28 Mar 2020 08:58:05 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id 31so14567113wrs.3 for ; Sat, 28 Mar 2020 01:58:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to; bh=Hk5QBHZRLForL8IxdtPFDonNjjnSHHBgQoFEVQhsiQE=; b=bmG8FngnsfMDZyGz2Y6aVfpwS39pal1GzSzJT10vD/VQP8zANP3T8IvGfYv4Zjgi05 /uzFC5g9p37PW1zl570eNkWfWRZZAFMA3Krt24bMpWObQ9PsMEFS+4nh0/vP8yhwPvlz 2+3ggo6hW6g6JF2mB557BQRXc6RXD4lQ6w8WfZcIz0ynws/O2xREammWSbnIPzXlrjOS IiGXQ/2R2ir7JuMpoIn7FLct33kVvpCT9rC9RqFjYtfizOvPV494/gYxDMhRVhdCaVSQ JlQhXTqy2bDnlc2scjOFjUQ15JUqfhDS6JDYAZ005IrvdyOmSknQpYcB9VI1Fy+1Iktw KfZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to; bh=Hk5QBHZRLForL8IxdtPFDonNjjnSHHBgQoFEVQhsiQE=; b=Hg7R9EBR4QfHZBL/iGzVAyolVY6nSm1IhVH0sBbM7W6xQbdpi+d5GqQBq6cLgXr+3t erCJS0WjP1fF3GmhzAqF8evXlhbvsPRPtSEHIx/U2l5dJlEnC+ZshrksuJNkZqetRFDl zUWUUDR3x4hIuqDE1a6Vp/r3E9jgEOtI5zBzy8KRS6BiiOm0TZo66+2lCFY4f62VXEWM Ywa0KLGzoR4h8doOBgCsIvrptCt/h66I6SG1WJpOcqoEdtFp1kXd/w2d7Fj4HpDn8Epv 7GLU+XR657XUZ2HsGKNiZOgAI6xT6hIAG9SNDNaLRiQiTMmSBuFz3ky0RLg4739GsEr/ mpGQ== X-Gm-Message-State: ANhLgQ2cCmHMIpUsTAN2ytJ302GssZmz/iETSfl15AePXBVpMxGsrnUj 6hjq6LrSlMgWXcXQFrbcoX8= X-Google-Smtp-Source: ADFU+vvjdn14hIYWcgsmK8E3RUBnSIQAXrVnIl8g3DoIgmCHozbkYVS3i+s4E4s0vbmRyZ/R2e0Ofg== X-Received: by 2002:adf:b1c1:: with SMTP id r1mr3610121wra.337.1585385884481; Sat, 28 Mar 2020 01:58:04 -0700 (PDT) Received: from localhost.localdomain ([2a02:2450:10d2:194d:903b:8e3c:b688:90ef]) by smtp.gmail.com with ESMTPSA id 189sm7766207wme.31.2020.03.28.01.58.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Mar 2020 01:58:03 -0700 (PDT) From: SeongJae Park To: Michel Lespinasse Cc: Andrew Morton , linux-mm , LKML , Peter Zijlstra , Laurent Dufour , Vlastimil Babka , Matthew Wilcox , Liam Howlett , Jerome Glisse , Davidlohr Bueso , David Rientjes , Hugh Dickins , Ying Han , Jason Gunthorpe , Markus Elfring Subject: Re: [PATCH v3 01/10] mmap locking API: initial implementation as rwsem wrappers (Michel Lespinasse) Date: Sat, 28 Mar 2020 09:57:46 +0100 Message-Id: <20200328085746.4773-1-sj38.park@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200327225102.25061-2-walken@google.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2020-03-27T15:50:53-07:00 Michel Lespinasse wrote: > This change wraps the existing mmap_sem related rwsem calls into a new > mmap locking API. There are two justifications for the new API: > > - At first, it provides an easy hooking point to instrument mmap_sem > locking latencies independently of any other rwsems. > > - In the future, it may be a starting point for replacing the rwsem > implementation with a different one, such as range locks. > > Signed-off-by: Michel Lespinasse > --- > include/linux/mm.h | 1 + > include/linux/mmap_lock.h | 54 +++++++++++++++++++++++++++++++++++++++ > 2 files changed, 55 insertions(+) > create mode 100644 include/linux/mmap_lock.h > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index c54fb96cb1e6..2f13c9198999 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > #include > #include > #include > diff --git a/include/linux/mmap_lock.h b/include/linux/mmap_lock.h > new file mode 100644 > index 000000000000..8b5a3cd56118 > --- /dev/null > +++ b/include/linux/mmap_lock.h > @@ -0,0 +1,54 @@ > +#ifndef _LINUX_MMAP_LOCK_H > +#define _LINUX_MMAP_LOCK_H > + > +static inline void mmap_init_lock(struct mm_struct *mm) > +{ > + init_rwsem(&mm->mmap_sem); > +} > + > +static inline void mmap_write_lock(struct mm_struct *mm) > +{ > + down_write(&mm->mmap_sem); > +} > + > +static inline int mmap_write_lock_killable(struct mm_struct *mm) > +{ > + return down_write_killable(&mm->mmap_sem); > +} > + > +static inline bool mmap_write_trylock(struct mm_struct *mm) > +{ > + return down_write_trylock(&mm->mmap_sem) != 0; > +} > + > +static inline void mmap_write_unlock(struct mm_struct *mm) > +{ > + up_write(&mm->mmap_sem); > +} > + > +static inline void mmap_downgrade_write_lock(struct mm_struct *mm) > +{ > + downgrade_write(&mm->mmap_sem); > +} > + > +static inline void mmap_read_lock(struct mm_struct *mm) > +{ > + down_read(&mm->mmap_sem); > +} > + > +static inline int mmap_read_lock_killable(struct mm_struct *mm) > +{ > + return down_read_killable(&mm->mmap_sem); > +} > + > +static inline bool mmap_read_trylock(struct mm_struct *mm) > +{ > + return down_read_trylock(&mm->mmap_sem) != 0; > +} > + > +static inline void mmap_read_unlock(struct mm_struct *mm) > +{ > + up_read(&mm->mmap_sem); > +} > + > +#endif /* _LINUX_MMAP_LOCK_H */ Reviewed-by: SeongJae Park > -- > 2.26.0.rc2.310.g2932bb562d-goog >