From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AA1EC2D0E5 for ; Mon, 30 Mar 2020 17:40:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C72552073B for ; Mon, 30 Mar 2020 17:40:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="IoKCdJlI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C72552073B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 695CB8E0006; Mon, 30 Mar 2020 13:40:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6209C8E0001; Mon, 30 Mar 2020 13:40:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E72A8E0006; Mon, 30 Mar 2020 13:40:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0230.hostedemail.com [216.40.44.230]) by kanga.kvack.org (Postfix) with ESMTP id 3011B8E0001 for ; Mon, 30 Mar 2020 13:40:37 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id C681282499B9 for ; Mon, 30 Mar 2020 17:40:36 +0000 (UTC) X-FDA: 76652743272.23.comb23_54aa55738c50 X-HE-Tag: comb23_54aa55738c50 X-Filterd-Recvd-Size: 3533 Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Mon, 30 Mar 2020 17:40:36 +0000 (UTC) Received: by mail-pg1-f193.google.com with SMTP id o26so8987819pgc.12 for ; Mon, 30 Mar 2020 10:40:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=EIazmoWr1nLxxc8KNs37fnm42F/lDdp4/gYm3JHLHek=; b=IoKCdJlIr8dKSUui+FFl2O8BLgUnbJF6UcpsVTBUCUIxnVlSObs8uqbpJtVfo85MHD NSMiSHyRzun2Qw2uFSqKhacVvS9T1di6LetUQD1cCrF9rPt/SGxOjvQEku1cIwKpUsK4 Nyhahu2qk/o5MwyQBOY1XNgL+3twDOfx4D+Ls= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EIazmoWr1nLxxc8KNs37fnm42F/lDdp4/gYm3JHLHek=; b=McRu1xzMmJkBpqi4AkhOHFM/FqxHsuZo61EZKcwiY3eP8YYlcg2WkXn+VFFYhxCHwo jKYFaALmvnCnzxYz2886xS607O1F+8JfPy8mYbsydkdZoKTZlO35+PthnWN7ZtbKt2QK 3WOGVB7DY23rbSwy2Vzx/Wwmhfi7TtLA83E46/61DYRg339ro/eg6Hd0ltBXs3VX4Xwg 8lRT1pmXc31VODqDiO9eW/L3awOPSMmfd5U7UaFyzZbcz2Q4IDmh1gJlNwaAJHsyokFd QOKOlOp2uqYyezCtWxUEFgRbYiWBJbRC3plVlF6eJ2t4Hhiz9sklg3lMIfU/B0xk13/R 8J5g== X-Gm-Message-State: ANhLgQ3ZYl9mNuMC4C4jqY70XopMGZKiQhnbIzRmxHe2ZLXXED2RJqbW ivcDwW0ei5T2zyxWD0i4wxIQqw== X-Google-Smtp-Source: ADFU+vsp6F+mnbmu4oeH1BZE4z851b8UTWueJ6LJmiWqqkcFzAPvDpoG8s71ddjkdVNmXYn/ukbhqw== X-Received: by 2002:a63:cf:: with SMTP id 198mr14239682pga.447.1585590035454; Mon, 30 Mar 2020 10:40:35 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id i2sm10410628pfr.203.2020.03.30.10.40.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2020 10:40:34 -0700 (PDT) Date: Mon, 30 Mar 2020 10:40:33 -0700 From: Kees Cook To: Vlastimil Babka Cc: Luis Chamberlain , Iurii Zaikin , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-mm@kvack.org, Ivan Teterevkov , Michal Hocko , David Rientjes , Matthew Wilcox , "Eric W . Biederman" , "Guilherme G . Piccoli" , Alexey Dobriyan , Thomas Gleixner , Greg Kroah-Hartman , Christian Brauner Subject: Re: [PATCH 1/3] kernel/sysctl: support setting sysctl parameters from kernel command line Message-ID: <202003301040.E3099A957@keescook> References: <20200330115535.3215-1-vbabka@suse.cz> <20200330115535.3215-2-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 30, 2020 at 06:23:57PM +0200, Vlastimil Babka wrote: > Boo, all the error prints should terminate with \n > Will wait for feedback before resend. eek, yes, good catch. :) -- Kees Cook