From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73F4DC43331 for ; Wed, 1 Apr 2020 16:11:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 32CDF2071A for ; Wed, 1 Apr 2020 16:11:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32CDF2071A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D83308E0006; Wed, 1 Apr 2020 12:11:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D5A198E0001; Wed, 1 Apr 2020 12:11:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C96EC8E0006; Wed, 1 Apr 2020 12:11:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0105.hostedemail.com [216.40.44.105]) by kanga.kvack.org (Postfix) with ESMTP id AFF1A8E0001 for ; Wed, 1 Apr 2020 12:11:03 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 6DDE62C07 for ; Wed, 1 Apr 2020 16:11:03 +0000 (UTC) X-FDA: 76659775206.28.slip54_43646caf18928 X-HE-Tag: slip54_43646caf18928 X-Filterd-Recvd-Size: 4854 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Wed, 1 Apr 2020 16:11:02 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id m11so694197wrx.10 for ; Wed, 01 Apr 2020 09:11:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6SgSqYLabdht19WsqZYrt1JZCOHPoNOa62kgTyu4dDY=; b=GsJBp3Gm3JmU7h/FuIOxI438k5k5mnNA1XYc/WyJM1ihoha+n7uJDlFOIwbcvgYwFk D1DtoiN6lOxRQujnOgoxA/gskD5HJVREeeKUoNdv44bBQEyr7twbMSml4T6Nn8Mu2Nny HywLNw0FvQbWQV8+G65Bf9xh5KzEGcMmMbGof0qMb4hEzc4dgkptcAtlyrwC0DTG/TDZ zSlUgyo1FyOsA0WZBDrfw6SBSEg56OCCV2nM+YuLcE67eKBfLQPcXreNiHMTDenMNffC 991+fT4++Rqqhhxqw79MzPXtI22e1JpVyQq+uVYXbQyMZDcJBV5rJqRGaURSMFyA73oZ RfDw== X-Gm-Message-State: ANhLgQ3AAt7hJUBxDtSKSbGPRhwPDtYDeHoolfb4HVwJDMttMS03jbiX evJXvwaop5eTQp4qf80JHdA= X-Google-Smtp-Source: ADFU+vsJ7ptO/+sfU8MVbmxUQXnHszAgWJSKgC0msCpRCKplGfHo1pAnZvZsGDgekyFl//FlRsrmVg== X-Received: by 2002:adf:df8a:: with SMTP id z10mr25302935wrl.278.1585757461997; Wed, 01 Apr 2020 09:11:01 -0700 (PDT) Received: from localhost (ip-37-188-180-223.eurotel.cz. [37.188.180.223]) by smtp.gmail.com with ESMTPSA id i2sm3499892wrx.22.2020.04.01.09.11.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2020 09:11:01 -0700 (PDT) Date: Wed, 1 Apr 2020 18:10:59 +0200 From: Michal Hocko To: "Paul E. McKenney" Cc: Uladzislau Rezki , Joel Fernandes , linux-kernel@vger.kernel.org, linux-mm@kvack.org, rcu@vger.kernel.org, willy@infradead.org, peterz@infradead.org, neilb@suse.com, vbabka@suse.cz, mgorman@suse.de, Andrew Morton , Josh Triplett , Lai Jiangshan , Mathieu Desnoyers , Steven Rostedt Subject: Re: [PATCH RFC] rcu/tree: Use GFP_MEMALLOC for alloc memory to free memory pattern Message-ID: <20200401161059.GV22681@dhcp22.suse.cz> References: <20200331153450.GM30449@dhcp22.suse.cz> <20200331161215.GA27676@pc636> <20200401070958.GB22681@dhcp22.suse.cz> <20200401123230.GB32593@pc636> <20200401125503.GJ22681@dhcp22.suse.cz> <20200401130816.GA1320@pc636> <20200401131528.GK22681@dhcp22.suse.cz> <20200401132258.GA1953@pc636> <20200401152805.GN22681@dhcp22.suse.cz> <20200401155712.GA15147@paulmck-ThinkPad-P72> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200401155712.GA15147@paulmck-ThinkPad-P72> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 01-04-20 08:57:12, Paul E. McKenney wrote: [...] > > diff --git a/include/linux/gfp.h b/include/linux/gfp.h > > index e3ab1c0d9140..8f09cefdfa7b 100644 > > --- a/include/linux/gfp.h > > +++ b/include/linux/gfp.h > > @@ -127,6 +127,8 @@ struct vm_area_struct; > > * > > * Reclaim modifiers > > * ~~~~~~~~~~~~~~~~~ > > + * Please note that all the folloging flags are only applicable to sleepable > > s/folloging/following/ Fixed. I will add it on top of http://lkml.kernel.org/r/20200401120502.GH22681@dhcp22.suse.cz and post both later this week to Andrew. >From ce456c2f6c8fe0588c1d743a5b87e283aa4806f8 Mon Sep 17 00:00:00 2001 From: Michal Hocko Date: Wed, 1 Apr 2020 18:02:23 +0200 Subject: [PATCH] mm: make it clear that gfp reclaim modifiers are valid only for sleepable allocations While it might be really clear to MM developers that gfp reclaim modifiers are applicable only to sleepable allocations (those with __GFP_DIRECT_RECLAIM) it seems that actual users of the API are not always sure. Make it explicit that they are not applicable for GFP_NOWAIT or GFP_ATOMIC allocations which are the most commonly used non-sleepable allocation masks. Acked-by: Paul E. McKenney Signed-off-by: Michal Hocko --- include/linux/gfp.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/gfp.h b/include/linux/gfp.h index e3ab1c0d9140..8040fa944cd8 100644 --- a/include/linux/gfp.h +++ b/include/linux/gfp.h @@ -127,6 +127,8 @@ struct vm_area_struct; * * Reclaim modifiers * ~~~~~~~~~~~~~~~~~ + * Please note that all the following flags are only applicable to sleepable + * allocations (e.g. %GFP_NOWAIT and %GFP_ATOMIC will ignore them). * * %__GFP_IO can start physical IO. * -- 2.25.1 -- Michal Hocko SUSE Labs