From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88E55C43331 for ; Thu, 2 Apr 2020 01:26:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4116D2077D for ; Thu, 2 Apr 2020 01:26:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="asNX5KMJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4116D2077D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CF7618E0008; Wed, 1 Apr 2020 21:26:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA6EC8E0007; Wed, 1 Apr 2020 21:26:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B967E8E0008; Wed, 1 Apr 2020 21:26:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0197.hostedemail.com [216.40.44.197]) by kanga.kvack.org (Postfix) with ESMTP id 9E9DD8E0007 for ; Wed, 1 Apr 2020 21:26:01 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 5CE28180AD807 for ; Thu, 2 Apr 2020 01:26:01 +0000 (UTC) X-FDA: 76661173722.30.match46_6ec1f4d297817 X-HE-Tag: match46_6ec1f4d297817 X-Filterd-Recvd-Size: 2510 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Thu, 2 Apr 2020 01:26:00 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 153F220675; Thu, 2 Apr 2020 01:26:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585790760; bh=k6nasgdVB4utNvm45WpFc4xHWUi6hVlb66k5dkX71yI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=asNX5KMJqem55vTzY+UvookUbmJPwIcQb4Kn+BsjBf3KU9O0/qn95jTKiNopOG9cP G2odiq1CdDV/mEULd+DaT5rlHIbmMcPiev4hcScBRRN/9LWrNmjlWPKnYW4L3L3zyQ 9+isrJPj1Ul6NuiF//t+cuaH5Hr6JvNEfc1iBSvI= Date: Wed, 1 Apr 2020 18:25:59 -0700 From: Andrew Morton To: Li Xinhai Cc: linux-mm@kvack.org, Rik van Riel , "Kirill A. Shutemov" , Matthew Wilcox Subject: Re: [PATCH 0/3] mm: Fix misuse of parent anon_vma in dup_mmap path Message-Id: <20200401182559.e5d988f6491537f31323cb2c@linux-foundation.org> In-Reply-To: <1581150928-3214-1-git-send-email-lixinhai.lxh@gmail.com> References: <1581150928-3214-1-git-send-email-lixinhai.lxh@gmail.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 8 Feb 2020 08:35:25 +0000 Li Xinhai wrote: > This patchset fix the misuse of parenet anon_vma, which mainly caused by > child vma's vm_next and vm_prev are left same as its parent after > duplicate vma. Finally, code reached parent vma's neighbor by referring > pointer of child vma and executed wrong logic. > > The first two patches fix relevant issues, and the third patch sets vm_next > and vm_prev to NULL when duplicate vma to prevent potential misuse in future. > > Li Xinhai (3): > mm: don't prepare anon_vma if vma has VM_WIPEONFORK > Revert "mm/rmap.c: reuse mergeable anon_vma as parent when fork" > mm: set vm_next and vm_prev to NULL in vm_area_dup() > > kernel/fork.c | 10 ++++++---- > mm/rmap.c | 13 ------------- > 2 files changed, 6 insertions(+), 17 deletions(-) Can we please have some review input on this series?