From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E63B7C43331 for ; Thu, 2 Apr 2020 04:04:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A907C20747 for ; Thu, 2 Apr 2020 04:04:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="sw1rWyzU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A907C20747 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 579F58E001A; Thu, 2 Apr 2020 00:04:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 551D18E0007; Thu, 2 Apr 2020 00:04:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 466EC8E001A; Thu, 2 Apr 2020 00:04:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0250.hostedemail.com [216.40.44.250]) by kanga.kvack.org (Postfix) with ESMTP id 2A49D8E0007 for ; Thu, 2 Apr 2020 00:04:15 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id DE3038248047 for ; Thu, 2 Apr 2020 04:04:14 +0000 (UTC) X-FDA: 76661572428.23.doll13_250da16de7025 X-HE-Tag: doll13_250da16de7025 X-Filterd-Recvd-Size: 2842 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Thu, 2 Apr 2020 04:04:14 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7EB38206E9; Thu, 2 Apr 2020 04:04:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585800253; bh=2Y/AQpHaPXPWLhvJdFyJ/VYql+ZqPlGEDwOpyJbGjsI=; h=Date:From:To:Subject:In-Reply-To:From; b=sw1rWyzU8hKrIZb+2EWIZpSzeFhv1Ep74mTQhk7lte6DrbMniR5gt943CSBVSSrZg gbob8T0zkyDMC3No+Sh61KC1p7xcCtZVCMW6bzKc+0b3tnxDWNYkHGssxHaAkzfUTE OA5RO6l8QDJMEryniVb3jDSo6PsFekTpbR1+D9mA= Date: Wed, 01 Apr 2020 21:04:13 -0700 From: Andrew Morton To: akpm@linux-foundation.org, keescook@chromium.org, linux-mm@kvack.org, mm-commits@vger.kernel.org, seth.arnold@canonical.com, torvalds@linux-foundation.org, viro@zeniv.linux.org.uk Subject: [patch 021/155] fs_parse: remove pr_notice() about each validation Message-ID: <20200402040413.Zgd4kZt3B%akpm@linux-foundation.org> In-Reply-To: <20200401210155.09e3b9742e1c6e732f5a7250@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Kees Cook Subject: fs_parse: remove pr_notice() about each validation This notice fills my boot logs with scary-looking asterisks but doesn't really tell me anything. Let's just remove it; validation errors are already reported separately, so this is just a redundant list of filesystems. $ dmesg | grep VALIDATE [ 0.306256] *** VALIDATE tmpfs *** [ 0.307422] *** VALIDATE proc *** [ 0.308355] *** VALIDATE cgroup *** [ 0.308741] *** VALIDATE cgroup2 *** [ 0.813256] *** VALIDATE bpf *** [ 0.815272] *** VALIDATE ramfs *** [ 0.815665] *** VALIDATE hugetlbfs *** [ 0.876970] *** VALIDATE nfs *** [ 0.877383] *** VALIDATE nfs4 *** Link: http://lkml.kernel.org/r/202003061617.A8835CAAF@keescook Signed-off-by: Kees Cook Cc: Alexander Viro Reviewed-by: Seth Arnold Signed-off-by: Andrew Morton --- fs/fs_parser.c | 2 -- 1 file changed, 2 deletions(-) --- a/fs/fs_parser.c~fs_parse-remove-pr_notice-about-each-validation +++ a/fs/fs_parser.c @@ -368,8 +368,6 @@ bool fs_validate_description(const char const struct fs_parameter_spec *param, *p2; bool good = true; - pr_notice("*** VALIDATE %s ***\n", name); - for (param = desc; param->name; param++) { /* Check for duplicate parameter names */ for (p2 = desc; p2 < param; p2++) { _