From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B18AFC43331 for ; Thu, 2 Apr 2020 04:10:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 696472074D for ; Thu, 2 Apr 2020 04:10:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="h6LCl/pv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 696472074D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1337D8E007C; Thu, 2 Apr 2020 00:10:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F13E58E000D; Thu, 2 Apr 2020 00:10:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D65E98E007C; Thu, 2 Apr 2020 00:10:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0241.hostedemail.com [216.40.44.241]) by kanga.kvack.org (Postfix) with ESMTP id B47628E000D for ; Thu, 2 Apr 2020 00:10:17 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 711B38248047 for ; Thu, 2 Apr 2020 04:10:17 +0000 (UTC) X-FDA: 76661587674.13.soda56_59ce1a0cf3356 X-HE-Tag: soda56_59ce1a0cf3356 X-Filterd-Recvd-Size: 2566 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Thu, 2 Apr 2020 04:10:17 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0744B2074D; Thu, 2 Apr 2020 04:10:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585800616; bh=UcKPfN5XIJEoNuKrpFMKA5hFJKFwIwoIXV2BYE3tkJ4=; h=Date:From:To:Subject:In-Reply-To:From; b=h6LCl/pvcmWu+FlNGOFY3K6tH9qj08eWoTj0qhIyd12ASM54ybOpq0ukTCJiMbqtJ kCmUEnai/08yOWU8mt2E8PlRf0oYAo47fVoNpzNWynmfMOqj3JvmBMUNz7ivLT8bcs mNUKiqh02kNiCgCuT1+BsA8pFWP8a/GhzaBIuCBY= Date: Wed, 01 Apr 2020 21:10:15 -0700 From: Andrew Morton To: akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, mateusznosek0@gmail.com, mm-commits@vger.kernel.org, richard.weiyang@gmail.com, torvalds@linux-foundation.org, willy@infradead.org Subject: [patch 124/155] mm/vmscan.c: clean code by removing unnecessary assignment Message-ID: <20200402041015.Sm_nRspvB%akpm@linux-foundation.org> In-Reply-To: <20200401210155.09e3b9742e1c6e732f5a7250@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Mateusz Nosek Subject: mm/vmscan.c: clean code by removing unnecessary assignment Previously 0 was assigned to variable 'lruvec_size', but the variable was never read later. So the assignment can be removed. Link: http://lkml.kernel.org/r/20200229214022.11853-1-mateusznosek0@gmail.com Fixes: f87bccde6a7d ("mm/vmscan: remove unused lru_pages argument") Signed-off-by: Mateusz Nosek Reviewed-by: Matthew Wilcox (Oracle) Reviewed-by: Wei Yang Reviewed-by: David Hildenbrand Signed-off-by: Andrew Morton --- mm/vmscan.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/mm/vmscan.c~mm-vmscanc-clean-code-by-removing-unnecessary-assignment +++ a/mm/vmscan.c @@ -2427,10 +2427,8 @@ out: case SCAN_FILE: case SCAN_ANON: /* Scan one type exclusively */ - if ((scan_balance == SCAN_FILE) != file) { - lruvec_size = 0; + if ((scan_balance == SCAN_FILE) != file) scan = 0; - } break; default: /* Look ma, no brain */ _