From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B1FAC43331 for ; Thu, 2 Apr 2020 04:10:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5DF8D2074D for ; Thu, 2 Apr 2020 04:10:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="um1WKkS1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5DF8D2074D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 01F3C8E007D; Thu, 2 Apr 2020 00:10:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F119D8E000D; Thu, 2 Apr 2020 00:10:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2A438E007D; Thu, 2 Apr 2020 00:10:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0159.hostedemail.com [216.40.44.159]) by kanga.kvack.org (Postfix) with ESMTP id C39A68E000D for ; Thu, 2 Apr 2020 00:10:20 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8E1A4824805A for ; Thu, 2 Apr 2020 04:10:20 +0000 (UTC) X-FDA: 76661587800.23.quill02_5a40ecc330815 X-HE-Tag: quill02_5a40ecc330815 X-Filterd-Recvd-Size: 2732 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Thu, 2 Apr 2020 04:10:20 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3A09920784; Thu, 2 Apr 2020 04:10:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585800619; bh=THIrl+Gpw2gkRk8vfYqClL5EXWTLWmXDJi209CRo7SY=; h=Date:From:To:Subject:In-Reply-To:From; b=um1WKkS1vM8w7LiOFVdQelfizc1QERD2Z73XmpKjUxf6TijrJfD22FFHbov494h8Z NhlfWCReQiztHpqtmYNKGsPUbvV/X6Lz/FQdUSj4gPyjdtWdAFo9ajwVtU72iJa6RQ h1DH0eoI2cUkNdWsf4wmiTibUccNpFpn6x/OLU3U= Date: Wed, 01 Apr 2020 21:10:18 -0700 From: Andrew Morton To: akpm@linux-foundation.org, ktkhai@virtuozzo.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org Subject: [patch 125/155] mm/vmscan.c: make may_enter_fs bool in shrink_page_list() Message-ID: <20200402041018.Ql1JvqAUf%akpm@linux-foundation.org> In-Reply-To: <20200401210155.09e3b9742e1c6e732f5a7250@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Kirill Tkhai Subject: mm/vmscan.c: make may_enter_fs bool in shrink_page_list() This gives some size improvement: $size mm/vmscan.o (before) text data bss dec hex filename 53670 24123 12 77805 12fed mm/vmscan.o $size mm/vmscan.o (after) text data bss dec hex filename 53648 24123 12 77783 12fd7 mm/vmscan.o Link: http://lkml.kernel.org/r/Message-ID: Signed-off-by: Kirill Tkhai Reviewed-by: Andrew Morton Signed-off-by: Andrew Morton --- mm/vmscan.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) --- a/mm/vmscan.c~mm-make-may_enter_fs-bool-in-shrink_page_list +++ a/mm/vmscan.c @@ -1084,9 +1084,8 @@ static unsigned long shrink_page_list(st while (!list_empty(page_list)) { struct address_space *mapping; struct page *page; - int may_enter_fs; enum page_references references = PAGEREF_RECLAIM; - bool dirty, writeback; + bool dirty, writeback, may_enter_fs; unsigned int nr_pages; cond_resched(); @@ -1267,7 +1266,7 @@ static unsigned long shrink_page_list(st goto activate_locked_split; } - may_enter_fs = 1; + may_enter_fs = true; /* Adding to swap updated mapping */ mapping = page_mapping(page); _