From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52A58C2D0F3 for ; Thu, 2 Apr 2020 14:08:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1892C207FF for ; Thu, 2 Apr 2020 14:08:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="HIyBAkkG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1892C207FF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A91FB8E0008; Thu, 2 Apr 2020 10:08:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A42C68E0007; Thu, 2 Apr 2020 10:08:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9313A8E0008; Thu, 2 Apr 2020 10:08:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0100.hostedemail.com [216.40.44.100]) by kanga.kvack.org (Postfix) with ESMTP id 79E328E0007 for ; Thu, 2 Apr 2020 10:08:03 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id DE666824805A for ; Thu, 2 Apr 2020 14:08:02 +0000 (UTC) X-FDA: 76663094004.09.toy23_4638d2954af5c X-HE-Tag: toy23_4638d2954af5c X-Filterd-Recvd-Size: 3838 Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Thu, 2 Apr 2020 14:08:02 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id r7so3316851ljg.13 for ; Thu, 02 Apr 2020 07:08:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=h7bqkDqMHbPZ1ok9VoLpz0hENHZdWdqgE8s4bUha+nU=; b=HIyBAkkGbl51Xv3R6RwvwHVmCNqsBtgMFcw26vN6BOP1jlFrX/Kt6T60oqdI2p0xUt aRb3aLN9BZ6lLCkJdAZFDiv1k4ha+huruKfi1/1XOmgWfwhOT+E7+7Htg8frNUlwfo0z ZWEtKGrd/lmw68balWkzvbXlyujjoSGD74jc127tXC4LdOup7EWIb6/lW1bKIXvzVokS Paw/S4BgksSBNKbhbnbCyXSVVMqnqcnMRDVbDFLOBHlNoAdoHnwOfo4WP4SP1d9qfXvo Vj06rkT5NmgKdOCFH4S9ggYBy7pH5yD0MUmmwSvQDEIuMx5x4Ndk8horfoevLLEX5rBJ mjwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=h7bqkDqMHbPZ1ok9VoLpz0hENHZdWdqgE8s4bUha+nU=; b=UbGIB07EOMTx0EIUJx25bDLIbaVg6yZhO0JiZ/mUdJm8T1hsP5l4xkGGMtHomn0bAy BLstfjc1jDfCFz4g4dpFoX0A9ozTKkXe0QzyeHfG0ihSGkI6OKlIHgETSxkeS5amNNHt 0W0bTaVtqmAWeYlI0g0/5IjGG9C2TLD9tconRRQGKUPHqi7d/TysZd+7iWXmoACB3gja X3mlZotlo1VP4HAz7zFV+bbFGJzFWSSw4ZUJ4AdXLzHoSTdy2e4S7sq20pou5P97bAin XMgedxW13NDmRivmBzlb8Vhtg53w/nJfTLhQ9bDUqBRJ590QfzKH/TkPtdjSwIhQm+fx Hzjw== X-Gm-Message-State: AGi0PubP+CVBKJ+H7mhV3j9HFC42S400VIsCQVWmRCNKZwYC+BpLOGKT b1DosZj8QQkXM0p+sIWEA9fpQ5ZHt1c= X-Google-Smtp-Source: APiQypJpuXGE+cyfkA+hgM+Y97yViV6PC72CMfjPqPKPckXZMpY5y8geubkpCSQmQ3zkFUituOxftw== X-Received: by 2002:a2e:98c3:: with SMTP id s3mr2133884ljj.6.1585836480983; Thu, 02 Apr 2020 07:08:00 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id l21sm4490023lfh.63.2020.04.02.07.07.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2020 07:08:00 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 9D9FC1020A6; Thu, 2 Apr 2020 17:07:59 +0300 (+03) Date: Thu, 2 Apr 2020 17:07:59 +0300 From: "Kirill A. Shutemov" To: Li Xinhai Cc: linux-mm@kvack.org, akpm@linux-foundation.org, "Kirill A. Shutemov" , Matthew Wilcox , Johannes Weiner Subject: Re: [PATCH 3/3] mm: set vm_next and vm_prev to NULL in vm_area_dup() Message-ID: <20200402140759.3c6cuzqwhah7sasm@box> References: <1581150928-3214-1-git-send-email-lixinhai.lxh@gmail.com> <1581150928-3214-4-git-send-email-lixinhai.lxh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1581150928-3214-4-git-send-email-lixinhai.lxh@gmail.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Feb 08, 2020 at 08:35:28AM +0000, Li Xinhai wrote: > Set ->vm_next and ->vm_prev to NULL to prevent potential misuse from > the new duplicated vma. > > Currently, only in fork path there are misuse for handling anon_vma. No > other bugs been revealed with this patch applied. > > Signed-off-by: Li Xinhai > Cc: Kirill A. Shutemov > Cc: Matthew Wilcox > Cc: Johannes Weiner Looks okay to me. Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov